generic/733: disable for btrfs
David Sterba
maintainerPATCH 1/1 generic/733: disable for btrfs
This tests if a clone source can be read but in btrfs there's an exclusive lock and the test always fails. The functionality might be implemented in btrfs in the future but for now disable the test.
--- tests/generic/733 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/733 +1 -1
@@ -18,7 +18,7 @@ _begin_fstest auto clone punch . ./common/reflink # real QA test starts here -_supported_fs generic +_supported_fs generic ^btrfs _require_scratch_reflink _require_cp_reflink _require_xfs_io_command "fpunch"
Signature · 1 line
2.42.1
Quoted 7 lines · David Sterba
This tests if a clone source can be read but in btrfs there's an exclusive lock and the test always fails. The functionality might be implemented in btrfs in the future but for now disable the test.
CC Josef Bacik <[email protected]>Signed-off-by David Sterba <[email protected]>
Looks good, thanks.
Quoted 21 lines
--- tests/generic/733 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/733 +1
-2@@ -18,7 +18,7 @@ _begin_fstest auto clone punch . ./common/reflink # real QA test starts here -_supported_fs generic +_supported_fs generic ^btrfs _require_scratch_reflink _require_cp_reflink _require_xfs_io_command "fpunch" --2.42.1
Hi,
Quoted 3 lines
This tests if a clone source can be read but in btrfs there's an exclusive lock and the test always fails. The functionality might be implemented in btrfs in the future but for now disable the test.
On linux 6.8-rc5+, generic/733 with btrfs filesystem have some chance(>50%) to success now. Is this expected?
Best Regards
Wang Yugui ([email protected])
2024/02/24
Quoted 22 lines
CC Josef Bacik <[email protected]>Signed-off-by David Sterba <[email protected]>--- tests/generic/733 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/733 +1
-1@@ -18,7 +18,7 @@ _begin_fstest auto clone punch . ./common/reflink # real QA test starts here -_supported_fs generic +_supported_fs generic ^btrfs _require_scratch_reflink _require_cp_reflink _require_xfs_io_command "fpunch"Signature · 1 line
2.42.1
Quoted 8 lines · Wang Yugui
Hi,
Quoted 3 lines
This tests if a clone source can be read but in btrfs there's an exclusive lock and the test always fails. The functionality might be implemented in btrfs in the future but for now disable the test.
On linux 6.8-rc5+, generic/733 with btrfs filesystem have some chance(>50%) to success now. Is this expected?
The test may succeed because of lucky timing, but otherwise it's not relevant for btrfs.
Quoted 15 lines · David Sterba
This tests if a clone source can be read but in btrfs there's an exclusive lock and the test always fails. The functionality might be implemented in btrfs in the future but for now disable the test.
CC Josef Bacik <[email protected]>Signed-off-by David Sterba <[email protected]>--- tests/generic/733 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/733 +0
-0
tests/generic/733 _begin_fstest auto clone punch · line 21
Quoted 5 lines
tests/generic/733 +1
-1@@ -18,7 +18,7 @@ _begin_fstest auto clone punch . ./common/reflink # real QA test starts here -_supported_fs generic +_supported_fs generic ^btrfs
If only need a blacklist, you can write "^btrfs" directly, e.g.
_supported_fs ^btrfs
then others (except btrfs) are in whitelist, don't need the "generic".
Thanks,
Zorro
Quoted 7 lines
tests/generic/733 +0
-0_require_scratch_reflink _require_cp_reflink _require_xfs_io_command "fpunch"Signature · 1 line
2.42.1
Quoted 24 lines · Zorro Lang
Quoted 15 lines · David Sterba
This tests if a clone source can be read but in btrfs there's an exclusive lock and the test always fails. The functionality might be implemented in btrfs in the future but for now disable the test.
CC Josef Bacik <[email protected]>Signed-off-by David Sterba <[email protected]>--- tests/generic/733 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/733 +0
-0tests/generic/733 _begin_fstest auto clone punch · line 21
Quoted 5 lines
tests/generic/733 +1
-1@@ -18,7 +18,7 @@ _begin_fstest auto clone punch . ./common/reflink # real QA test starts here -_supported_fs generic +_supported_fs generic ^btrfsIf only need a blacklist, you can write "^btrfs" directly, e.g.
Quoted 3 lines
_supported_fs^btrfsthen others (except btrfs) are in whitelist, don't need the "generic".
Ok thanks, do I need to resend or would you update the commit?
Quoted 25 lines · David Sterba
Quoted 24 lines · Zorro Lang
Quoted 15 lines · David Sterba
This tests if a clone source can be read but in btrfs there's an exclusive lock and the test always fails. The functionality might be implemented in btrfs in the future but for now disable the test.
CC Josef Bacik <[email protected]>Signed-off-by David Sterba <[email protected]>--- tests/generic/733 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/733 +0
-0tests/generic/733 _begin_fstest auto clone punch · line 21
Quoted 5 lines
tests/generic/733 +1
-1@@ -18,7 +18,7 @@ _begin_fstest auto clone punch . ./common/reflink # real QA test starts here -_supported_fs generic +_supported_fs generic ^btrfsIf only need a blacklist, you can write "^btrfs" directly, e.g.
Quoted 5 lines
Quoted 3 lines
_supported_fs^btrfsthen others (except btrfs) are in whitelist, don't need the "generic".
Ok thanks, do I need to resend or would you update the commit?
I can help to change that, it's simple enough.
Thanks,
Zorro
Quoted 1 line
Quoted 26 lines · Zorro Lang
Quoted 25 lines · David Sterba
Quoted 24 lines · Zorro Lang
Quoted 15 lines · David Sterba
This tests if a clone source can be read but in btrfs there's an exclusive lock and the test always fails. The functionality might be implemented in btrfs in the future but for now disable the test.
CC Josef Bacik <[email protected]>Signed-off-by David Sterba <[email protected]>--- tests/generic/733 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/733 +0
-0tests/generic/733 _begin_fstest auto clone punch · line 21
Quoted 5 lines
tests/generic/733 +1
-1@@ -18,7 +18,7 @@ _begin_fstest auto clone punch . ./common/reflink # real QA test starts here -_supported_fs generic +_supported_fs generic ^btrfsIf only need a blacklist, you can write "^btrfs" directly, e.g.
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
_supported_fs^btrfsthen others (except btrfs) are in whitelist, don't need the "generic".
Ok thanks, do I need to resend or would you update the commit?
I can help to change that, it's simple enough.
Applied for the PR with this changed.
Thanks, Anand
Quoted 5 lines
Thanks,
ZorroQuoted 1 line
Quoted 29 lines · Anand Jain
Quoted 28 lines · Zorro Lang
Quoted 27 lines · David Sterba
Quoted 26 lines · Zorro Lang
Quoted 15 lines · David Sterba
This tests if a clone source can be read but in btrfs there's an exclusive lock and the test always fails. The functionality might be implemented in btrfs in the future but for now disable the test.
CC Josef Bacik <[email protected]>Signed-off-by David Sterba <[email protected]>--- tests/generic/733 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/733 +0
-0tests/generic/733 _begin_fstest auto clone punch · line 21
Quoted 5 lines
tests/generic/733 +1
-1@@ -18,7 +18,7 @@ _begin_fstest auto clone punch . ./common/reflink # real QA test starts here -_supported_fs generic +_supported_fs generic ^btrfsIf only need a blacklist, you can write "^btrfs" directly, e.g.
_supported_fs^btrfs
Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
then others (except btrfs) are in whitelist, don't need the "generic".
Ok thanks, do I need to resend or would you update the commit?
I can help to change that, it's simple enough.
Applied for the PR with this changed.
The test generic/733 works after patch
so please keep it.
Quoted 33 lines
Quoted 33 lines
Quoted 32 lines
Quoted 24 lines
Quoted 24 lines
Quoted 16 lines
This tests if a clone source can be read but in btrfs there's an exclusive lock and the test always fails. The functionality might be implemented in btrfs in the future but for now disable the test.
CC Josef Bacik <[email protected]>Signed-off-by David Sterba <[email protected]>--- tests/generic/733 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tests/generic/733 +0
-0tests/generic/733 _begin_fstest auto clone punch · line 21
Quoted 5 lines
tests/generic/733 +1
-1@@ -18,7 +18,7 @@ _begin_fstest auto clone punch . ./common/reflink # real QA test starts here -_supported_fs generic +_supported_fs generic ^btrfsIf only need a blacklist, you can write "^btrfs" directly, e.g.
Quoted 5 lines
Quoted 3 lines
_supported_fs^btrfsthen others (except btrfs) are in whitelist, don't need the "generic".
Ok thanks, do I need to resend or would you update the commit?
I can help to change that, it's simple enough.
Quoted 7 lines
Quoted 1 line
Applied for the PR with this changed.
The test generic/733 works after patch
so please keep it.
Ah, appreciate the heads-up!
Thanks, Anand