FAILED: patch "[PATCH] crypto: virtio/akcipher - Fix stack overflow on memcpy" failed to apply to 5.15-stable tree
Subsystems (4)
[email protected]
maintainerThe patch below does not apply to the 5.15-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-5.15.y
git checkout FETCH_HEAD
git cherry-pick -x c0ec2a712daf133d9996a8a1b7ee2d4996080363
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<[email protected]>' --in-reply-to '2024022629-defog-preoccupy-2fb8@gregkh' --subject-prefix 'PATCH 5.15.y' HEAD^..
Possible dependencies:
c0ec2a712daf ("crypto: virtio/akcipher - Fix stack overflow on memcpy") 0756ad15b1fe ("virtio-crypto: use private buffer for control request") 6fd763d15586 ("virtio-crypto: change code style") 59ca6c93387d ("virtio-crypto: implement RSA algorithm")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From c0ec2a712daf133d9996a8a1b7ee2d4996080363 Mon Sep 17 00:00:00 2001
From: zhenwei pi <[email protected]>
Date: Tue, 30 Jan 2024 19:27:40 +0800
Subject: [PATCH] crypto: virtio/akcipher - Fix stack overflow on memcpy
sizeof(struct virtio_crypto_akcipher_session_para) is less than sizeof(struct virtio_crypto_op_ctrl_req::u), copying more bytes from stack variable leads stack overflow. Clang reports this issue by commands:
make -j CC=clang-14 mrproper >/dev/null 2>&1
make -j O=/tmp/crypto-build CC=clang-14 allmodconfig >/dev/null 2>&1 make -j O=/tmp/crypto-build W=1 CC=clang-14 drivers/crypto/virtio/
virtio_crypto_akcipher_algs.o
drivers/crypto/virtio/virtio_crypto_akcipher_algs.c +3 -2
@@ -104,7 +104,8 @@ static void virtio_crypto_dataq_akcipher_callback(struct virtio_crypto_request * }static int virtio_crypto_alg_akcipher_init_session (struct virtio_crypto_akcipher_ctx *ctx, -struct virtio_crypto_ctrl_header *header,void *para, +struct virtio_crypto_ctrl_header *header, +struct virtio_crypto_akcipher_session_para *para,const uint8_t *key,unsigned int keylen) {struct scatterlist outhdr_sg, key_sg, inhdr_sg, *sgs[3 ];
@@ -128,7 +129,7 @@ static int virtio_crypto_alg_akcipher_init_session(struct virtio_crypto_akcipher ctrl = &vc_ctrl_req->ctrl;memcpy (&ctrl->header, header,sizeof (ctrl->header)); -memcpy (&ctrl->u, para,sizeof (ctrl->u)); +memcpy (&ctrl->u.akcipher_create_session.para, para,sizeof (*para)); input = &vc_ctrl_req->input; input->status =cpu_to_le32 (VIRTIO_CRYPTO_ERR );