Skip to contentSkip to conversation

power: supply: bq2415x_charger: report online status

PATCH Applied Sicelo A. Mhlongo 2 participants 3 messages Feb 29, 2024 – Mar 1, 2024

Subsystems (2)
Power supply Nokia N900 power supply drivers
lore
Share & tools
lore

Sicelo A. Mhlongo

author
#0 lore raw

PATCH v3 1/1 power: supply: bq2415x_charger: report online status

Provide the Online property. This chip does not have specific flags to indicate the presence of an input voltage, but this is implied by all valid charging states. Fault states also only occur when VBUS is present, so set Online true for those as well.

Signed-off-by Sicelo A. Mhlongo <[email protected]>
---
 drivers/power/supply/bq2415x_charger.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/power/supply/bq2415x_charger.c +11 -0
index 6a4798a62588..7b93ba20348a 100644
@@ -991,6 +991,7 @@ static enum power_supply_property bq2415x_power_supply_props[] = {
 	/* TODO: maybe add more power supply properties */
 	POWER_SUPPLY_PROP_STATUS,
 	POWER_SUPPLY_PROP_MODEL_NAME,
+	POWER_SUPPLY_PROP_ONLINE,
 };
 
 static int bq2415x_power_supply_get_property(struct power_supply *psy,

@@ -1017,6 +1018,16 @@ static int bq2415x_power_supply_get_property(struct power_supply *psy,
 	case POWER_SUPPLY_PROP_MODEL_NAME:
 		val->strval = bq->model;
 		break;
+	case POWER_SUPPLY_PROP_ONLINE:
+		/* VBUS is present for all charging and fault states,
+		 * except the 'Ready' state.
+		 */
+		ret = bq2415x_exec_command(bq, BQ2415X_CHARGE_STATUS);
+		if (ret < 0)
+			return ret;
+		else
+			val->intval = ret > 0;
+		break;
 	default:
 		return -EINVAL;
 	}
Signature · 1 line
2.43.0
Applied
#1 lore raw
Quoted 6 lines · Sicelo A. Mhlongo

Provide the Online property. This chip does not have specific flags to indicate the presence of an input voltage, but this is implied by all valid charging states. Fault states also only occur when VBUS is present, so set Online true for those as well.

Applied, thanks!

[1/1] power: supply: bq2415x_charger: report online status

      commit: 9a451f1b028e116d037a93bf13eb8f8620994205

Best regards,

Signature · 1 line
Sebastian Reichel <[email protected]>
#2 lore raw
In reply to Sicelo A. Mhlongo

Hi,

drivers/power/supply/bq2415x_charger.c static int bq2415x_power_supply_get_property(struct power_supply *psy, · line 1028

Quoted 4 lines · Sicelo A. Mhlongo
drivers/power/supply/bq2415x_charger.c +4 -0
+		ret = bq2415x_exec_command(bq, BQ2415X_CHARGE_STATUS);
+		if (ret < 0)
+			return ret;
+		else

The else is not needed, since the if returns. I dropped it while applying.

Greetings,

-- Sebastian