dmaengine: tegra186: Fix residual calculation
Subsystems (3)
PATCH 1/1 dmaengine: tegra186: Fix residual calculation
The exisiting residual calculation returns an incorrect value when bytes_xfer == bytes_req. This scenario occurs particularly with drivers like UART where DMA is scheduled for maximum number of bytes and is terminated when the bytes inflow stops. At higher baud rates, it could request the tx_status while there is no bytes left to transfer. This will lead to incorrect residual being set. Hence return residual as '0' when bytes transferred equals to the bytes requested.
--- drivers/dma/tegra186-gpc-dma.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/dma/tegra186-gpc-dma.c +3 -0
@@ -746,6 +746,9 @@ static int tegra_dma_get_residual(struct tegra_dma_channel *tdc) bytes_xfer = dma_desc->bytes_xfer + sg_req[dma_desc->sg_idx].len - (wcount *4 ); +if (dma_desc->bytes_req == bytes_xfer) +return 0 ; + residual = dma_desc->bytes_req - (bytes_xfer % dma_desc->bytes_req);return residual;
Signature · 1 line
2.43.2
Quoted 1 line · Akhil R
The exisiting residual calculation returns an incorrect value when
s/exisiting/existing/
Quoted 18 lines
bytes_xfer==bytes_req. This scenario occurs particularly with drivers like UART where DMA is scheduled for maximum number of bytes and is terminated when the bytes inflow stops. At higher baud rates, it could request thetx_statuswhile there is no bytes left to transfer. This will lead to incorrect residual being set. Hence return residual as '0' when bytes transferred equals to the bytes requested.Fixes ee17028009d4 ("dmaengine: tegra: Add tegra gpcdma driver")Signed-off-by Akhil R <[email protected]>--- drivers/dma/tegra186-gpc-dma.c | 3 +++ 1 file changed, 3 insertions(+)drivers/dma/tegra186-gpc-dma.c +0
-0
drivers/dma/tegra186-gpc-dma.c static int tegra_dma_get_residual(struct tegra_dma_channel *tdc) · line 754
Quoted 9 lines
drivers/dma/tegra186-gpc-dma.c +3
-0@@ -746,6 +746,9 @@ static int tegra_dma_get_residual(struct tegra_dma_channel *tdc) bytes_xfer = dma_desc->bytes_xfer + sg_req[dma_desc->sg_idx].len - (wcount *4 ); +if (dma_desc->bytes_req == bytes_xfer) +return 0 ; + residual = dma_desc->bytes_req - (bytes_xfer % dma_desc->bytes_req);return residual;
Thanks! Apart from the typo, looks good to me ...
Jon
Signature · 1 line
nvpublic