Skip to contentSkip to conversation

dt-bindings: leds: pwm-multicolour: re-allow active-low

PATCH RESEND Applied Conor Dooley 3 participants 3 messages Feb 29, 2024 – Mar 4, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 dt-bindings: leds: pwm-multicolour: re-allow active-low

From: Conor Dooley <[email protected]>

active-low was lifted to the common schema for leds, but it went unnoticed that the leds-multicolour binding had "additionalProperties:
false" where the other users had "unevaluatedProperties: false", thereby disallowing active-low for multicolour leds. Explicitly permit it again.

Fixes c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common")

---

This needs to go via netdev as the commit it fixes (and is based on) is there

CC Pavel Machek <[email protected]>
CC Lee Jones <[email protected]>
CC Rob Herring <[email protected]>
CC Krzysztof Kozlowski <[email protected]>
CC Conor Dooley <[email protected]>
CC Sven Schwermer <[email protected]>
CC Christian Marangi <[email protected]>
CC "David S. Miller" <[email protected]>
CC Eric Dumazet <[email protected]>
CC Jakub Kicinski <[email protected]>
CC Paolo Abeni <[email protected]>
---
 Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml +2 -0
index 5edfbe347341..a31a202afe5c 100644
@@ -41,6 +41,8 @@ properties:
 
           pwm-names: true
 
+          active-low: true
+
           color: true
 
         required:
Signature · 1 line
2.43.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 30 lines · Conor Dooley

From: Conor Dooley <[email protected]>

active-low was lifted to the common schema for leds, but it went unnoticed that the leds-multicolour binding had "additionalProperties:
false" where the other users had "unevaluatedProperties: false", thereby disallowing active-low for multicolour leds. Explicitly permit it again.

Fixes c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common")

---

This needs to go via netdev as the commit it fixes (and is based on) is there

CC Pavel Machek <[email protected]>
CC Lee Jones <[email protected]>
CC Rob Herring <[email protected]>
CC Krzysztof Kozlowski <[email protected]>
CC Conor Dooley <[email protected]>
CC Sven Schwermer <[email protected]>
CC Christian Marangi <[email protected]>
CC "David S. Miller" <[email protected]>
CC Eric Dumazet <[email protected]>
CC Jakub Kicinski <[email protected]>
CC Paolo Abeni <[email protected]>
Quoted 3 lines
---
 Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
 1 file changed, 2 insertions(+)

Please take this via netdev.

Quoted 17 lines
Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml +2 -0
index 5edfbe347341..a31a202afe5c 100644
@@ -41,6 +41,8 @@ properties:
 
           pwm-names: true
 
+          active-low: true
+
           color: true
 
         required:
Signature · 1 line
2.43.0
Signature · 1 line
Lee Jones [李琼斯]
#2 lore raw
In reply to Conor Dooley
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:

Quoted 8 lines · On Thu, 29 Feb 2024 18:24:00 +0000 you wrote:

From: Conor Dooley <[email protected]>

active-low was lifted to the common schema for leds, but it went unnoticed that the leds-multicolour binding had "additionalProperties:
false" where the other users had "unevaluatedProperties: false", thereby disallowing active-low for multicolour leds. Explicitly permit it again.

[...]

Here is the summary with links:
- [RESEND] dt-bindings: leds: pwm-multicolour: re-allow active-low

    https://git.kernel.org/netdev/net-next/c/df620d7fabe9

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html