Skip to contentSkip to conversation

dt-bindings: dma: fsl-edma: remove 'clocks' from required

PATCH Superseded Frank Li 2 participants 12 messages Mar 1, 2024 – Mar 4, 2024

Subsystems (4)

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH v2 1/2 dt-bindings: dma: fsl-edma: remove 'clocks' from required

fsl,imx8qm-adma and fsl,imx8qm-edma don't require 'clocks'. Remove it from required and add 'if' block for other compatible string to keep the same restrictions.

---

Notes:
Change from v1 to v2
- add Krzysztof's ACK.

 .../devicetree/bindings/dma/fsl,edma.yaml        | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +15 -1
index aa51d278cb67b..cf0aa8e6b9ec3 100644
@@ -70,7 +70,6 @@ required:
   - compatible
   - reg
   - interrupts
-  - clocks
   - dma-channels
 
 allOf:
@@ -151,6 +150,21 @@ allOf:
         dma-channels:
           const: 32
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,vf610-edma
+              - fsl,imx7ulp-edma
+              - fsl,imx93-edma3
+              - fsl,imx93-edma4
+              - fsl,imx95-edma5
+              - fsl,ls1028a-edma
+    then:
+      required:
+        - clocks
+
 unevaluatedProperties: false
 
 examples:
Signature · 1 line
2.34.1
author maintainer
#1 lore raw

PATCH v2 2/2 dt-bindings: dma: fsl-edma: allow 'power-domains' property

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +15 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
+  power-domains:
+    minItems: 1
+    maxItems: 64
+
   big-endian:
     description: |
       If present registers and hardware scatter/gather descriptors of the
@@ -165,6 +169,17 @@ allOf:
       required:
         - clocks
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx8qm-adma
+              - fsl,imx8qm-edma
+    then:
+      required:
+        - power-domains
+
 unevaluatedProperties: false
 
 examples:
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

Quoted 23 lines · Frank Li

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +0 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644

Documentation/devicetree/bindings/dma/fsl,edma.yaml properties: · line 64

Quoted 6 lines
Documentation/devicetree/bindings/dma/fsl,edma.yaml +3 -0
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
+  power-domains:
+    minItems: 1
+    maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power domains.

Best regards,
Krzysztof

author maintainer
#3 lore raw

Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

Quoted 27 lines · Krzysztof Kozlowski
Quoted 26 lines · Frank Li

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +0 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
Quoted 6 lines

Documentation/devicetree/bindings/dma/fsl,edma.yaml properties: · line 64

Quoted 3 lines
Documentation/devicetree/bindings/dma/fsl,edma.yaml +3 -0
+  power-domains:
+    minItems: 1
+    maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power domains.

Sorry, what's your means? 'power-domains' belong to 'properties'. 'maxItems' belong to 'power-domains'.It is similar with 'clocks'. what's wrong?

Frank

Quoted 4 lines

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

Quoted 35 lines · Frank Li
Quoted 27 lines · Krzysztof Kozlowski
Quoted 26 lines · Frank Li

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +0 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
Quoted 6 lines

Documentation/devicetree/bindings/dma/fsl,edma.yaml properties: · line 64

Quoted 3 lines
Documentation/devicetree/bindings/dma/fsl,edma.yaml +3 -0
+  power-domains:
+    minItems: 1
+    maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power domains.

Quoted 3 lines

Sorry, what's your means? 'power-domains' belong to 'properties'. 'maxItems' belong to 'power-domains'.It is similar with 'clocks'. what's wrong?

That one device belong to 64 power domains. That's just random code...

Best regards,
Krzysztof

author maintainer
#5 lore raw

Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

Quoted 36 lines · Krzysztof Kozlowski
Quoted 35 lines · Frank Li
Quoted 33 lines · Krzysztof Kozlowski
Quoted 23 lines · Frank Li

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +0 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644

Documentation/devicetree/bindings/dma/fsl,edma.yaml properties: · line 64

Quoted 6 lines
Documentation/devicetree/bindings/dma/fsl,edma.yaml +3 -0
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
+  power-domains:
+    minItems: 1
+    maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power domains.

Quoted 5 lines
Quoted 3 lines

Sorry, what's your means? 'power-domains' belong to 'properties'. 'maxItems' belong to 'power-domains'.It is similar with 'clocks'. what's wrong?

That one device belong to 64 power domains. That's just random code...

Yes, each dma channel have one power domain. Total 64 dma channel. So there are 64 power-domains.

Frank

Quoted 4 lines

Best regards,
Krzysztof

#6 lore raw

Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

Quoted 37 lines · Frank Li
Quoted 36 lines · Krzysztof Kozlowski
Quoted 35 lines · Frank Li
Quoted 33 lines · Krzysztof Kozlowski
Quoted 23 lines · Frank Li

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +0 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644

Documentation/devicetree/bindings/dma/fsl,edma.yaml properties: · line 64

Quoted 6 lines
Documentation/devicetree/bindings/dma/fsl,edma.yaml +3 -0
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
+  power-domains:
+    minItems: 1
+    maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power domains.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Sorry, what's your means? 'power-domains' belong to 'properties'. 'maxItems' belong to 'power-domains'.It is similar with 'clocks'. what's wrong?

That one device belong to 64 power domains. That's just random code...

Yes, each dma channel have one power domain. Total 64 dma channel. So there are 64 power-domains.

OK, then how about extending the example to be complete?

Best regards,
Krzysztof

author maintainer
#7 lore raw

Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

Quoted 42 lines · Krzysztof Kozlowski
Quoted 41 lines · Frank Li
Quoted 40 lines · Krzysztof Kozlowski
Quoted 38 lines · Frank Li
Quoted 27 lines · Krzysztof Kozlowski
Quoted 26 lines · Frank Li

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +0 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
Quoted 6 lines

Documentation/devicetree/bindings/dma/fsl,edma.yaml properties: · line 64

Quoted 3 lines
Documentation/devicetree/bindings/dma/fsl,edma.yaml +3 -0
+  power-domains:
+    minItems: 1
+    maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power domains.

Sorry, what's your means? 'power-domains' belong to 'properties'. 'maxItems' belong to 'power-domains'.It is similar with 'clocks'. what's wrong?

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

That one device belong to 64 power domains. That's just random code...

Yes, each dma channel have one power domain. Total 64 dma channel. So there are 64 power-domains.

OK, then how about extending the example to be complete?

Let's add 8qxp example at next version.

Frank

Quoted 4 lines

Best regards,
Krzysztof

#8 lore raw

Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

Quoted 43 lines · Frank Li
Quoted 42 lines · Krzysztof Kozlowski
Quoted 41 lines · Frank Li
Quoted 40 lines · Krzysztof Kozlowski
Quoted 38 lines · Frank Li
Quoted 27 lines · Krzysztof Kozlowski
Quoted 26 lines · Frank Li

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +0 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
Quoted 6 lines

Documentation/devicetree/bindings/dma/fsl,edma.yaml properties: · line 64

Quoted 3 lines
Documentation/devicetree/bindings/dma/fsl,edma.yaml +3 -0
+  power-domains:
+    minItems: 1
+    maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power domains.

Sorry, what's your means? 'power-domains' belong to 'properties'. 'maxItems' belong to 'power-domains'.It is similar with 'clocks'. what's wrong?

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line

That one device belong to 64 power domains. That's just random code...

Yes, each dma channel have one power domain. Total 64 dma channel. So there are 64 power-domains.

OK, then how about extending the example to be complete?

Let's add 8qxp example at next version.

You have already enough of examples there and your change here claims they user power domains, so why this cannot be added to existing examples?

Best regards,
Krzysztof

author maintainer
#9 lore raw

Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

Quoted 49 lines · Krzysztof Kozlowski
Quoted 48 lines · Frank Li
Quoted 47 lines · Krzysztof Kozlowski
Quoted 45 lines · Frank Li
Quoted 36 lines · Krzysztof Kozlowski
Quoted 35 lines · Frank Li
Quoted 33 lines · Krzysztof Kozlowski
Quoted 23 lines · Frank Li

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +0 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644

Documentation/devicetree/bindings/dma/fsl,edma.yaml properties: · line 64

Quoted 6 lines
Documentation/devicetree/bindings/dma/fsl,edma.yaml +3 -0
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
+  power-domains:
+    minItems: 1
+    maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power domains.

Quoted 5 lines
Quoted 3 lines

Sorry, what's your means? 'power-domains' belong to 'properties'. 'maxItems' belong to 'power-domains'.It is similar with 'clocks'. what's wrong?

That one device belong to 64 power domains. That's just random code...

Yes, each dma channel have one power domain. Total 64 dma channel. So there are 64 power-domains.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

OK, then how about extending the example to be complete?

Let's add 8qxp example at next version.

You have already enough of examples there and your change here claims they user power domains, so why this cannot be added to existing examples?

Only imx8qxp/8qm need power-domains now. The example in yaml is vf610, 7ulp and imx93. If add power-domains at existed example, it will mislead reader.

Frank

Quoted 4 lines

Best regards,
Krzysztof

#10 lore raw

Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

Quoted 50 lines · Frank Li
Quoted 49 lines · Krzysztof Kozlowski
Quoted 48 lines · Frank Li
Quoted 47 lines · Krzysztof Kozlowski
Quoted 45 lines · Frank Li
Quoted 36 lines · Krzysztof Kozlowski
Quoted 35 lines · Frank Li
Quoted 33 lines · Krzysztof Kozlowski
Quoted 23 lines · Frank Li

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +0 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644

Documentation/devicetree/bindings/dma/fsl,edma.yaml properties: · line 64

Quoted 6 lines
Documentation/devicetree/bindings/dma/fsl,edma.yaml +3 -0
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
+  power-domains:
+    minItems: 1
+    maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power domains.

Quoted 5 lines
Quoted 3 lines

Sorry, what's your means? 'power-domains' belong to 'properties'. 'maxItems' belong to 'power-domains'.It is similar with 'clocks'. what's wrong?

That one device belong to 64 power domains. That's just random code...

Yes, each dma channel have one power domain. Total 64 dma channel. So there are 64 power-domains.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

OK, then how about extending the example to be complete?

Let's add 8qxp example at next version.

You have already enough of examples there and your change here claims they user power domains, so why this cannot be added to existing examples?

Only imx8qxp/8qm need power-domains now. The example in yaml is vf610, 7ulp

Need? Hardware is either part of power domain or not. It's not dual-state.

Quoted 1 line

and imx93. If add power-domains at existed example, it will mislead reader.

Then please disallow the domains for other variants. You can convert imx93 to imx95 example, because it's no different than other one. There is little point in putting so many same examples in the binding. You are just duplicating DTS.

Best regards,
Krzysztof

author maintainer
#11 lore raw

Re: [PATCH v2 2/2] dt-bindings: dma: fsl-edma: allow 'power-domains' property

Quoted 60 lines · Krzysztof Kozlowski
Quoted 50 lines · Frank Li
Quoted 49 lines · Krzysztof Kozlowski
Quoted 48 lines · Frank Li
Quoted 47 lines · Krzysztof Kozlowski
Quoted 45 lines · Frank Li
Quoted 36 lines · Krzysztof Kozlowski
Quoted 35 lines · Frank Li
Quoted 33 lines · Krzysztof Kozlowski
Quoted 23 lines · Frank Li

Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need it.

Fixed below DTB_CHECK warning:
dma-controller@599f0000: Unevaluated properties are not allowed ('power-domains' was unexpected)

---

Notes:
Change from v1 to v2
- using maxitem: 64. Each channel have one power domain. Max 64 dmachannel.
- add power-domains to 'required' when compatible string is fsl,imx8qm-adma or fsl,imx8qm-edma

 .../devicetree/bindings/dma/fsl,edma.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/dma/fsl,edma.yaml +0 -0
index cf0aa8e6b9ec3..76c1716b8b95c 100644

Documentation/devicetree/bindings/dma/fsl,edma.yaml properties: · line 64

Quoted 6 lines
Documentation/devicetree/bindings/dma/fsl,edma.yaml +3 -0
@@ -59,6 +59,10 @@ properties:
     minItems: 1
     maxItems: 2
 
+  power-domains:
+    minItems: 1
+    maxItems: 64

Hm, this is odd. Blocks do not belong to almost infinite number of power domains.

Quoted 5 lines
Quoted 3 lines

Sorry, what's your means? 'power-domains' belong to 'properties'. 'maxItems' belong to 'power-domains'.It is similar with 'clocks'. what's wrong?

That one device belong to 64 power domains. That's just random code...

Yes, each dma channel have one power domain. Total 64 dma channel. So there are 64 power-domains.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

OK, then how about extending the example to be complete?

Let's add 8qxp example at next version.

You have already enough of examples there and your change here claims they user power domains, so why this cannot be added to existing examples?

Only imx8qxp/8qm need power-domains now. The example in yaml is vf610, 7ulp

Quoted 8 lines

Need? Hardware is either part of power domain or not. It's not dual-state.

Quoted 1 line

and imx93. If add power-domains at existed example, it will mislead reader.

Then please disallow the domains for other variants. You can convert imx93 to imx95 example, because it's no different than other one. There is little point in putting so many same examples in the binding. You are just duplicating DTS.

both imx93 and imx95 have not power domain now. Do you means 'imx95' as 'imx8qxp' ?

Frank?

Quoted 4 lines

Best regards,
Krzysztof