media: ir-spi: Remove unused of_gpio.h
Subsystems (2)
PATCH 1/1 media: ir-spi: Remove unused of_gpio.h
of_gpio.h is deprecated and subject to remove.
The driver doesn't use it, simply remove the unused header.
--- drivers/media/rc/ir-spi.c | 1 - 1 file changed, 1 deletion(-)
drivers/media/rc/ir-spi.c +0 -1
@@ -8,7 +8,6 @@#include <linux/fs.h> #include <linux/module.h> #include <linux/mutex.h> -#include <linux/of_gpio.h> #include <linux/regulator/consumer.h> #include <linux/spi/spi.h> #include <media/rc-core.h>
Signature · 1 line
2.43.0.rc1.1.gbec44491f096
Sean Young
maintainerQuoted 13 lines · Andy Shevchenko
of_gpio.his deprecated and subject to remove.
The driver doesn't use it, simply remove the unused header.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/media/rc/ir-spi.c | 1 - 1 file changed, 1 deletion(-)drivers/media/rc/ir-spi.c +0
-0
drivers/media/rc/ir-spi.c line 11
Quoted 4 lines
drivers/media/rc/ir-spi.c +0
-1@@ -8,7 +8,6 @@#include <linux/fs.h> #include <linux/module.h> #include <linux/mutex.h> -#include <linux/of_gpio.h>
This does not build, I get errors saying of_property_read_bool() is undefined. I think we need linux/of.h instead of linux/of_gpio.h.
Sean
Quoted 5 lines
drivers/media/rc/ir-spi.c +0
-0#include <linux/regulator/consumer.h> #include <linux/spi/spi.h> #include <media/rc-core.h> Signature · 1 line
2.43.0.rc1.1.gbec44491f096
Quoted 1 line · Sean Young
On Mon, Mar 04, 2024 at 08:03:31PM +0200, Andy Shevchenko wrote:
...
Quoted 4 lines
Quoted 1 line
-#include <
linux/of_gpio.h>This does not build, I get errors saying
of_property_read_bool()is undefined. I think we needlinux/of.hinstead oflinux/of_gpio.h.
Oh, good catch! The header block there is a mess. I will replace this patch by something better, I'll Cc you.
Signature · 2 lines
With Best Regards, Andy Shevchenko