Skip to contentSkip to conversation

media: Kconfig: Select MEDIA_CONTROLLER for VIDEO_V4L2_SUBDEV_API

PATCH In review Sakari Ailus 2 participants 5 messages Mar 4, 2024 – May 23, 2024 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: Kconfig: Select MEDIA_CONTROLLER for VIDEO_V4L2_SUBDEV_API

MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both.

---
Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies anymore.

 drivers/media/v4l2-core/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/v4l2-core/Kconfig +2 -1
index 331b8e535e5b..d55eff3f31b0 100644
@@ -10,7 +10,8 @@ config VIDEO_V4L2_I2C
 
 config VIDEO_V4L2_SUBDEV_API
 	bool
-	depends on VIDEO_DEV && MEDIA_CONTROLLER
+	depends on VIDEO_DEV
+	select MEDIA_CONTROLLER
 	help
 	  Enables the V4L2 sub-device pad-level userspace API used to configure
 	  video format, size and frame rate between hardware blocks.
Signature · 1 line
2.39.2
#1 lore raw

Hi Sakari,

Thank you for the patch.

Quoted 8 lines · Sakari Ailus

MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both.

---
Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies anymore.

It seems reasonable to me too, but I think it would make sense to drop in the same patch the manual selection of MEDIA_CONTROLLER for the Kconfig symbols that already select VIDEO_V4L2_SUBDEV_API.

Quoted 17 lines
 drivers/media/v4l2-core/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/v4l2-core/Kconfig +2 -1
index 331b8e535e5b..d55eff3f31b0 100644
@@ -10,7 +10,8 @@ config VIDEO_V4L2_I2C
 
 config VIDEO_V4L2_SUBDEV_API
 	bool
-	depends on VIDEO_DEV && MEDIA_CONTROLLER
+	depends on VIDEO_DEV
+	select MEDIA_CONTROLLER
 	help
 	  Enables the V4L2 sub-device pad-level userspace API used to configure
 	  video format, size and frame rate between hardware blocks.
Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw

Hi Laurent,

Quoted 9 lines · Laurent Pinchart

Hi Sakari,

Thank you for the patch.

Quoted 4 lines · Sakari Ailus

MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both.

Quoted 8 lines
Quoted 4 lines

---
Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies anymore.

It seems reasonable to me too, but I think it would make sense to drop in the same patch the manual selection of MEDIA_CONTROLLER for the Kconfig symbols that already select VIDEO_V4L2_SUBDEV_API.

This should be done, yes, but I'd add a separate patch for it: this one doesn't require changes elsewhere as such, just enables making them. Same for the other, few users that depend on MEDIA_CONTROLLER, they need to be converted, too.

Quoted 18 lines
Quoted 18 lines
 drivers/media/v4l2-core/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/v4l2-core/Kconfig +2 -1
index 331b8e535e5b..d55eff3f31b0 100644
@@ -10,7 +10,8 @@ config VIDEO_V4L2_I2C
 
 config VIDEO_V4L2_SUBDEV_API
 	bool
-	depends on VIDEO_DEV && MEDIA_CONTROLLER
+	depends on VIDEO_DEV
+	select MEDIA_CONTROLLER
 	help
 	  Enables the V4L2 sub-device pad-level userspace API used to configure
 	  video format, size and frame rate between hardware blocks.
Signature · 3 lines
Regards,

Sakari Ailus
#3 lore raw
Quoted 11 lines · Sakari Ailus
Quoted 10 lines · Laurent Pinchart
Quoted 8 lines · Sakari Ailus

MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both.

---
Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies anymore.

Quoted 8 lines
Quoted 3 lines

It seems reasonable to me too, but I think it would make sense to drop in the same patch the manual selection of MEDIA_CONTROLLER for the Kconfig symbols that already select VIDEO_V4L2_SUBDEV_API.

This should be done, yes, but I'd add a separate patch for it: this one doesn't require changes elsewhere as such, just enables making them. Same for the other, few users that depend on MEDIA_CONTROLLER, they need to be converted, too.

I'm OK with a separate patch, but can you send one ? :-)

Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
 drivers/media/v4l2-core/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/v4l2-core/Kconfig +2 -1
index 331b8e535e5b..d55eff3f31b0 100644
@@ -10,7 +10,8 @@ config VIDEO_V4L2_I2C
 
 config VIDEO_V4L2_SUBDEV_API
 	bool
-	depends on VIDEO_DEV && MEDIA_CONTROLLER
+	depends on VIDEO_DEV
+	select MEDIA_CONTROLLER
 	help
 	  Enables the V4L2 sub-device pad-level userspace API used to configure
 	  video format, size and frame rate between hardware blocks.
Signature · 3 lines
Regards,

Laurent Pinchart
#4 lore raw
Quoted 16 lines · Laurent Pinchart
Quoted 15 lines · Sakari Ailus
Quoted 13 lines · Laurent Pinchart
Quoted 8 lines · Sakari Ailus

MEDIA_CONTROLLER has no dependencies and VIDEO_V4L2_SUBDEV_API depends on it. Select MEDIA_CONTROLLER instead of depending on it. This way Kconfig options elsewhere do only need to select VIDEO_V4L2_SUBDEV_API, not both.

---
Mostly untested but seems reasonable. MEDIA_CONTROLLER has no dependencies anymore.

It seems reasonable to me too, but I think it would make sense to drop in the same patch the manual selection of MEDIA_CONTROLLER for the Kconfig symbols that already select VIDEO_V4L2_SUBDEV_API.

Quoted 6 lines
Quoted 4 lines

This should be done, yes, but I'd add a separate patch for it: this one doesn't require changes elsewhere as such, just enables making them. Same for the other, few users that depend on MEDIA_CONTROLLER, they need to be converted, too.

I'm OK with a separate patch, but can you send one ? :-)

Yes, a bit later on. This is worth merging without such a change as also new drivers will need to select both options.

Signature · 1 line
Sakari Ailus