Btrfs fixes for 6.8-rc7, part 2
David Sterba
maintainerHi,
a few more fixes. Please pull, thanks.
- fix freeing allocated id for anon dev when snapshot creation fails
- fiemap fixes
- followup for a recent deadlock fix, ranges that fiemap can access can still race with ordered extent completion
- make sure fiemap with SYNC flag does not race with writes
----------------------------------------------------------------
The following changes since commit c7bb26b847e5b97814f522686068c5628e2b3646:
btrfs: fix data race at btrfs_use_block_rsv() when accessing block reserve (2024-02-22 12:15:12 +0100)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git tags/for-6.8-rc6-tag
for you to fetch changes up to e2b54eaf28df0c978626c9736b94f003b523b451:
btrfs: fix double free of anonymous device after snapshot creation failure (2024-02-29 22:34:11 +0100)
----------------------------------------------------------------
Filipe Manana (3):
btrfs: fix race between ordered extent completion and fiemap
btrfs: ensure fiemap doesn't race with writes when FIEMAP_FLAG_SYNC is given
btrfs: fix double free of anonymous device after snapshot creation failure
fs/btrfs/disk-io.c | 22 ++++----- fs/btrfs/disk-io.h | 2 +- fs/btrfs/extent_io.c | 124 +++++++++++++++++++++++++++++++++++++++++-------- fs/btrfs/inode.c | 22 ++++++++- fs/btrfs/ioctl.c | 2 +- fs/btrfs/transaction.c | 2 +- 6 files changed, 139 insertions(+), 35 deletions(-)
The pull request you sent on Fri, 1 Mar 2024 14:32:55 +0100:
The pull request you sent on Fri, 1 Mar 2024 14:32:55 +0100:
Quoted 1 line
git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.gittags/for-6.8-rc6-tag
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/7505aa147adb10913c1b72e947006b6070753eb6
Thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html
Hi,
After pulling lasteast version, I can't compile, here's the error message.
In file included from ./arch/x86/include/generated/asm/rwonce.h:1,
from ./include/linux/compiler.h:251,
from ./include/linux/instrumented.h:10,
from ./include/linux/uaccess.h:6,
from net/core/dev.c:71:net/core/dev.c: In function ‘netdev_dpll_pin_assign’:./include/linux/rcupdate.h:462:36: error: dereferencing pointer to incomplete type ‘struct dpll_pin’
462 | #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v)
| ^~~~./include/asm-generic/rwonce.h:55:33: note: in definition of macro ‘__WRITE_ONCE’
55 | *(volatile typeof(x) *)&(x) = (val); \
| ^~~./arch/x86/include/asm/barrier.h:67:2: note: in expansion of macro ‘WRITE_ONCE’
67 | WRITE_ONCE(*p, v); \
| ^~~~~~~~~~./include/asm-generic/barrier.h:172:55: note: in expansion of macro ‘__smp_store_release’
172 | #define smp_store_release(p, v) do { kcsan_release();__smp_store_release(p, v); } while (0)
|
^~~~~~~~~~~~~~~~~~~
./include/linux/rcupdate.h:503:3: note: in expansion of macro
‘smp_store_release’
503 | smp_store_release(&p, RCU_INITIALIZER((typeof(p))_r_a_p__v)); \
| ^~~~~~~~~~~~~~~~~
./include/linux/rcupdate.h:503:25: note: in expansion of macro ‘RCU_INITIALIZER’
503 | smp_store_release(&p, RCU_INITIALIZER((typeof(p))_r_a_p__v)); \
| ^~~~~~~~~~~~~~~
net/core/dev.c:9081:2: note: in expansion of macro ‘rcu_assign_pointer’
9081 | rcu_assign_pointer(dev->dpll_pin, dpll_pin);
| ^~~~~~~~~~~~~~~~~~Quoted 39 lines · David Sterba <[email protected]> 于2024年3月1日周五 21:40写道:
Hi,
a few more fixes. Please pull, thanks.
- fix freeing allocated id for anon dev when snapshot creation fails
- fiemap fixes
- followup for a recent deadlock fix, ranges that fiemap can access can still race with ordered extent completion
- make sure fiemap with SYNC flag does not race with writes----------------------------------------------------------------
The following changes since commitc7bb26b847e5b97814f522686068c5628e2b3646:btrfs: fix data race at
btrfs_use_block_rsv()when accessing block reserve (2024-02-22 12:15:12 +0100)are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.gittags/for-6.8-rc6-tagfor you to fetch changes up to
e2b54eaf28df0c978626c9736b94f003b523b451:btrfs: fix double free of anonymous device after snapshot creation failure (2024-02-29 22:34:11 +0100)
----------------------------------------------------------------
Filipe Manana (3):
btrfs: fix race between ordered extent completion and fiemap
btrfs: ensure fiemap doesn't race with writes whenFIEMAP_FLAG_SYNCis given
btrfs: fix double free of anonymous device after snapshot creation failurefs/btrfs/disk-io.c | 22 ++++----- fs/btrfs/disk-io.h | 2 +- fs/btrfs/extent_io.c | 124 +++++++++++++++++++++++++++++++++++++++++-------- fs/btrfs/inode.c | 22 ++++++++- fs/btrfs/ioctl.c | 2 +- fs/btrfs/transaction.c | 2 +- 6 files changed, 139 insertions(+), 35 deletions(-)
Quoted 4 lines · li zhang
Hi,
After pulling lasteast version, I can't compile, here's the error message.
Quoted 8 lines
In file included from
./arch/x86/include/generated/asm/rwonce.h:1,from ./include/linux/compiler.h:251, from ./include/linux/instrumented.h:10, from ./include/linux/uaccess.h:6, from net/core/dev.c:71:
net/core/dev.c: In function ‘netdev_dpll_pin_assign’:./include/linux/rcupdate.h:462:36: error: dereferencing pointer to incomplete type ‘struct dpll_pin’
Unknown type struct dpll_pin, that's not related to btrfs.