clocksource: timer-riscv: Clear timer interrupt on timer initialization
Subsystems (3)
PATCH v3 1/1 clocksource: timer-riscv: Clear timer interrupt on timer initialization
In the RISC-V specification, the stimecmp register doesn't have a default value. To prevent the timer interrupt from being triggered during timer initialization, clear the timer interrupt by writing stimecmp with a maximum value.
---
v3:
Resolved comment from Samuel Holland.
- Function riscv_clock_event_stop() needs to be called before clockevents_config_and_register(), move riscv_clock_event_stop().
v2:
Resolved comments from Anup.
- Moved riscv_clock_event_stop() to riscv_timer_starting_cpu().
- Added Fixes tag
--- drivers/clocksource/timer-riscv.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/clocksource/timer-riscv.c +3 -0
@@ -108,6 +108,9 @@ static int riscv_timer_starting_cpu(unsigned int cpu) {struct clock_event_device *ce =per_cpu_ptr (&riscv_clock_event, cpu); +/* Clear timer interrupt */ +riscv_clock_event_stop (); + ce->cpumask =cpumask_of (cpu); ce->irq = riscv_clock_event_irq;if (riscv_timer_cannot_wake_cpu)
Signature · 1 line
2.43.0
Quoted 15 lines · Ley Foon Tan
In the RISC-V specification, the stimecmp register doesn't have a default value. To prevent the timer interrupt from being triggered during timer initialization, clear the timer interrupt by writing stimecmp with a maximum value.
Fixes 9f7a8ff6391f ("RISC-V: Prefer sstc extension if available")Cc <[email protected]>Signed-off-by Ley Foon Tan <[email protected]>---
v3:
Resolved comment from Samuel Holland.
- Functionriscv_clock_event_stop()needs to be called beforeclockevents_config_and_register(), moveriscv_clock_event_stop().
Quoted 7 lines
v2:
Resolved comments from Anup.
- Movedriscv_clock_event_stop()toriscv_timer_starting_cpu().
- Added Fixes tag--- drivers/clocksource/timer-riscv.c | 3 +++ 1 file changed, 3 insertions(+)
Atish Kumar Patra
Reviewed-byQuoted 25 lines · Samuel Holland
Quoted 15 lines · Ley Foon Tan
In the RISC-V specification, the stimecmp register doesn't have a default value. To prevent the timer interrupt from being triggered during timer initialization, clear the timer interrupt by writing stimecmp with a maximum value.
Fixes 9f7a8ff6391f ("RISC-V: Prefer sstc extension if available")Cc <[email protected]>Signed-off-by Ley Foon Tan <[email protected]>---
v3:
Resolved comment from Samuel Holland.
- Functionriscv_clock_event_stop()needs to be called beforeclockevents_config_and_register(), moveriscv_clock_event_stop().Quoted 7 lines
v2:
Resolved comments from Anup.
- Movedriscv_clock_event_stop()toriscv_timer_starting_cpu().
- Added Fixes tag--- drivers/clocksource/timer-riscv.c | 3 +++ 1 file changed, 3 insertions(+)
Quoted 3 lines
Reviewed-by Samuel Holland <[email protected]>Tested-by Samuel Holland <[email protected]>
Daniel Lezcano
AppliedQuoted 10 lines · Ley Foon Tan
In the RISC-V specification, the stimecmp register doesn't have a default value. To prevent the timer interrupt from being triggered during timer initialization, clear the timer interrupt by writing stimecmp with a maximum value.
Fixes 9f7a8ff6391f ("RISC-V: Prefer sstc extension if available")Cc <[email protected]>Signed-off-by Ley Foon Tan <[email protected]>---
Applied, thanks
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
[tip: timers/core] clocksource/drivers/timer-riscv: Clear timer interrupt on timer initialization
In reply to Ley Foon TanThe following commit has been merged into the timers/core branch of tip:
The following commit has been merged into the timers/core branch of tip:
Commit-ID: 8248ca30ef89f9cc74ace62ae1b9a22b5f16736c Gitweb: https://git.kernel.org/tip/8248ca30ef89f9cc74ace62ae1b9a22b5f16736c Author: Ley Foon Tan <[email protected]> AuthorDate: Thu, 07 Mar 2024 01:23:30 +08:00 Committer: Daniel Lezcano <[email protected]> CommitterDate: Wed, 13 Mar 2024 12:08:59 +01:00
clocksource/drivers/timer-riscv: Clear timer interrupt on timer initialization
In the RISC-V specification, the stimecmp register doesn't have a default value. To prevent the timer interrupt from being triggered during timer initialization, clear the timer interrupt by writing stimecmp with a maximum value.
--- drivers/clocksource/timer-riscv.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/clocksource/timer-riscv.c +3 -0
@@ -108,6 +108,9 @@ static int riscv_timer_starting_cpu(unsigned int cpu) {struct clock_event_device *ce =per_cpu_ptr (&riscv_clock_event, cpu); +/* Clear timer interrupt */ +riscv_clock_event_stop (); + ce->cpumask =cpumask_of (cpu); ce->irq = riscv_clock_event_irq;if (riscv_timer_cannot_wake_cpu)