drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

PATCH In review Wayne Lin 7 participants 16 messages Mar 7, 2024 – May 21, 2024

Subsystems (9)

Stable branch DRM drivers DRM misc Intel i915 +5 more subsystems

lore

Share & tools

lore

Wayne Lin

author

2024-03-07 06:30 UTC #0 lore raw

PATCH 1/1 drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression.

[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().

Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement")

Reported-by Leon Weiß <[email protected]>

Link https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.camel@ruhr-uni-bochum.de/ open here

Cc [email protected]

Signed-off-by Wayne Lin <[email protected]>

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
 drivers/gpu/drm/display/drm_dp_mst_topology.c             | 4 +---
 drivers/gpu/drm/i915/display/intel_dp_mst.c               | 2 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c                   | 2 +-
 include/drm/display/drm_dp_mst_helper.h                   | 1 -
 5 files changed, 4 insertions(+), 7 deletions(-)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1 -1

index c27063305a13..2c36f3d00ca2 100644
@@ -363,7 +363,7 @@ void dm_helpers_dp_mst_send_payload_allocation(
 	mst_state = to_drm_dp_mst_topology_state(mst_mgr->base.state);
 	new_payload = drm_atomic_get_mst_payload_state(mst_state, aconnector->mst_output_port);
 
-	ret = drm_dp_add_payload_part2(mst_mgr, mst_state->base.state, new_payload);
+	ret = drm_dp_add_payload_part2(mst_mgr, new_payload);
 
 	if (ret) {
 		amdgpu_dm_set_mst_status(&aconnector->mst_status,

drivers/gpu/drm/display/drm_dp_mst_topology.c +1 -3

index 03d528209426..95fd18f24e94 100644
@@ -3421,7 +3421,6 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
 /**
  * drm_dp_add_payload_part2() - Execute payload update part 2
  * @mgr: Manager to use.
- * @state: The global atomic state
  * @payload: The payload to update
  *
  * If @payload was successfully assigned a starting time slot by drm_dp_add_payload_part1(), this

@@ -3430,14 +3429,13 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
  * Returns: 0 on success, negative error code on failure.
  */
 int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-			     struct drm_atomic_state *state,
 			     struct drm_dp_mst_atomic_payload *payload)
 {
 	int ret = 0;
 
 	/* Skip failed payloads */
 	if (payload->payload_allocation_status != DRM_DP_MST_PAYLOAD_ALLOCATION_DFP) {
-		drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
+		drm_dbg_kms(mgr->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
 			    payload->port->connector->name);
 		return -EIO;
 	}

drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -1

index 53aec023ce92..2fba66aec038 100644
@@ -1160,7 +1160,7 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
 	if (first_mst_stream)
 		intel_ddi_wait_for_fec_status(encoder, pipe_config, true);
 
-	drm_dp_add_payload_part2(&intel_dp->mst_mgr, &state->base,
+	drm_dp_add_payload_part2(&intel_dp->mst_mgr,
 				 drm_atomic_get_mst_payload_state(mst_state, connector->port));
 
 	if (DISPLAY_VER(dev_priv) >= 12)

drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -1

index 0c3d88ad0b0e..88728a0b2c25 100644
@@ -915,7 +915,7 @@ nv50_msto_cleanup(struct drm_atomic_state *state,
 		msto->disabled = false;
 		drm_dp_remove_payload_part2(mgr, new_mst_state, old_payload, new_payload);
 	} else if (msto->enabled) {
-		drm_dp_add_payload_part2(mgr, state, new_payload);
+		drm_dp_add_payload_part2(mgr, new_payload);
 		msto->enabled = false;
 	}
 }

include/drm/display/drm_dp_mst_helper.h +0 -1

index 9b19d8bd520a..6c9145abc7e2 100644
@@ -851,7 +851,6 @@ int drm_dp_add_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
 			     struct drm_dp_mst_topology_state *mst_state,
 			     struct drm_dp_mst_atomic_payload *payload);
 int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-			     struct drm_atomic_state *state,
 			     struct drm_dp_mst_atomic_payload *payload);
 void drm_dp_remove_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
 				 struct drm_dp_mst_topology_state *mst_state,

Signature · 1 line

2.37.3

Patchwork

2024-03-07 07:20 UTC #1 lore raw

✗ Fi.CI.CHECKPATCH: warning for drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

== Series Details ==

Series: drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
URL : https://patchwork.freedesktop.org/series/130851/
State : warning

== Summary ==

Error: dim checkpatch failed
54fc3a878567 drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
-:12: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #12:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement")

-:22: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report #22:

Reported-by Leon Weiß <[email protected]>

Link https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.camel@ruhr-uni-bochum.de/ open here

total: 0 errors, 2 warnings, 0 checks, 53 lines checked

Patchwork

2024-03-07 07:20 UTC #2 lore raw

✗ Fi.CI.SPARSE: warning for drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

In reply to Wayne Lin

== Series Details ==

Series: drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
URL : https://patchwork.freedesktop.org/series/130851/
State : warning

== Summary ==

Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.

Patchwork

2024-03-07 07:33 UTC #3 lore raw

✓ Fi.CI.BAT: success for drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

In reply to Wayne Lin

== Series Details ==

Series: drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
URL : https://patchwork.freedesktop.org/series/130851/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_14400 -> Patchwork_130851v1
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/index.html

Participating hosts (40 -> 40)
------------------------------

Additional (1): fi-glk-j4005
Missing (1): fi-snb-2520m

Known issues
------------

Here are the changes found in Patchwork_130851v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_huc_copy@huc-copy:
- fi-glk-j4005: NOTRUN -> [SKIP][1] ([i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/fi-glk-j4005/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-glk-j4005: NOTRUN -> [SKIP][2] ([i915#4613]) +3 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/fi-glk-j4005/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- bat-mtlp-6: NOTRUN -> [SKIP][3] ([i915#4613]) +3 other tests skip
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@i915_pm_rps@basic-api:
- bat-mtlp-6: NOTRUN -> [SKIP][4] ([i915#6621])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-glk-j4005: NOTRUN -> [SKIP][5] +10 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/fi-glk-j4005/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- bat-mtlp-6: NOTRUN -> [SKIP][6] ([i915#9792])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@kms_force_connector_basic@prune-stale-modes:
- bat-mtlp-6: NOTRUN -> [SKIP][7] ([i915#5274] / [i915#9792])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- bat-mtlp-6: NOTRUN -> [SKIP][8] ([i915#4342] / [i915#5354] / [i915#9792])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@kms_pipe_crc_basic@hang-read-crc:
- bat-mtlp-6: NOTRUN -> [SKIP][9] ([i915#10295] / [i915#9792]) +6 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@kms_pm_backlight@basic-brightness:
- bat-mtlp-6: NOTRUN -> [SKIP][10] ([i915#5354] / [i915#9792])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@kms_psr@psr-cursor-plane-move:
- bat-mtlp-6: NOTRUN -> [SKIP][11] ([i915#9673] / [i915#9732] / [i915#9792]) +3 other tests skip
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- bat-mtlp-6: NOTRUN -> [SKIP][12] ([i915#3555] / [i915#8809] / [i915#9792])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@prime_vgem@basic-fence-flip:
- bat-mtlp-6: NOTRUN -> [SKIP][13] ([i915#3708] / [i915#9792])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@prime_vgem@basic-fence-mmap:
- bat-mtlp-6: NOTRUN -> [SKIP][14] ([i915#3708] / [i915#4077]) +1 other test skip
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

* igt@prime_vgem@basic-write:
- bat-mtlp-6: NOTRUN -> [SKIP][15] ([i915#3708]) +2 other tests skip
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/bat-mtlp-6/igt@[email protected]

Build changes
-------------

* Linux: CI_DRM_14400 -> Patchwork_130851v1

CI-20190529: 20190529
CI_DRM_14400: c9b9b8d4449209d2451127f98cdfe2b99bec3da7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7749: 2fd91b8c3cf9aa2b0bb78537a6b5e2bc3de50e0e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_130851v1: c9b9b8d4449209d2451127f98cdfe2b99bec3da7 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

f711251f0686 drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/index.html

Patchwork

2024-03-07 17:37 UTC #4 lore raw

✗ Fi.CI.IGT: failure for drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

In reply to Wayne Lin

== Series Details ==

Series: drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
URL : https://patchwork.freedesktop.org/series/130851/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_14400_full -> Patchwork_130851v1_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_130851v1_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_130851v1_full, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/index.html

Participating hosts (8 -> 8)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_130851v1_full:

### IGT changes ###

#### Possible regressions ####

* igt@api_intel_bb@blit-reloc-purge-cache:
- shard-dg2: NOTRUN -> [TIMEOUT][1] +1 other test timeout
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-tglu: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-tglu-2/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@[email protected]

* igt@i915_selftest@live@requests:
- shard-snb: [PASS][4] -> [ABORT][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-snb5/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-snb5/igt@i915_selftest@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-glk: NOTRUN -> [INCOMPLETE][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk3/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html

New tests
---------

New tests have been introduced between CI_DRM_14400_full and Patchwork_130851v1_full:

### New IGT tests (1) ###

* igt@kms_flip:
- Statuses :
- Exec time: [None] s

Known issues
------------

Here are the changes found in Patchwork_130851v1_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@drm_fdinfo@busy-idle-check-all@ccs3:
- shard-dg2: NOTRUN -> [SKIP][7] ([i915#8414]) +33 other tests skip
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@drm_fdinfo@[email protected]

* igt@drm_fdinfo@idle@rcs0:
- shard-rkl: [PASS][8] -> [FAIL][9] ([i915#7742])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-rkl-5/igt@drm_fdinfo@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-1/igt@drm_fdinfo@[email protected]

* igt@drm_fdinfo@virtual-busy-idle:
- shard-mtlp: NOTRUN -> [SKIP][10] ([i915#8414]) +6 other tests skip
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][11] ([i915#8414])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@gem_busy@semaphore:
- shard-dg2: NOTRUN -> [SKIP][12] ([i915#3936])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-2/igt@[email protected]

* igt@gem_close_race@multigpu-basic-threads:
- shard-dg1: NOTRUN -> [SKIP][13] ([i915#7697])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][14] ([i915#7697])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@[email protected]

* igt@gem_create@create-ext-cpu-access-big:
- shard-mtlp: NOTRUN -> [SKIP][15] ([i915#6335])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]
- shard-rkl: NOTRUN -> [SKIP][16] ([i915#6335])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][17] -> [FAIL][18] ([i915#6268])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-rkl-3/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-1/igt@[email protected]

* igt@gem_ctx_persistence@hang:
- shard-mtlp: NOTRUN -> [SKIP][19] ([i915#8555])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][20] ([i915#8555])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@gem_eio@reset-stress:
- shard-dg1: [PASS][21] -> [FAIL][22] ([i915#5784])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg1-19/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@gem_exec_balancer@bonded-pair:
- shard-dg2: NOTRUN -> [SKIP][23] ([i915#4771])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@gem_exec_balancer@bonded-sync:
- shard-mtlp: NOTRUN -> [SKIP][24] ([i915#4771])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@gem_exec_balancer@noheartbeat:
- shard-dg2: NOTRUN -> [SKIP][25] ([i915#8555]) +1 other test skip
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-rkl: NOTRUN -> [SKIP][26] ([i915#4525])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@gem_exec_capture@capture@vecs0-lmem0:
- shard-dg2: NOTRUN -> [FAIL][27] ([i915#10386]) +3 other tests fail
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-2/igt@gem_exec_capture@[email protected]

* igt@gem_exec_capture@many-4k-incremental:
- shard-glk: NOTRUN -> [FAIL][28] ([i915#9606])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk7/igt@[email protected]
- shard-mtlp: NOTRUN -> [FAIL][29] ([i915#9606])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo:
- shard-mtlp: NOTRUN -> [SKIP][30] ([i915#4473])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-6/igt@[email protected]

* igt@gem_exec_fair@basic-pace:
- shard-mtlp: NOTRUN -> [SKIP][31] ([i915#4473] / [i915#4771])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: NOTRUN -> [FAIL][32] ([i915#2842])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-rkl: NOTRUN -> [FAIL][33] ([i915#2842])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fence@submit3:
- shard-dg2: NOTRUN -> [SKIP][34] ([i915#4812]) +1 other test skip
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gem_exec_flush@basic-uc-prw-default:
- shard-dg1: NOTRUN -> [SKIP][35] ([i915#3539])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@gem_exec_flush@basic-uc-ro-default:
- shard-dg2: NOTRUN -> [SKIP][36] ([i915#3539] / [i915#4852]) +3 other tests skip
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@gem_exec_reloc@basic-write-read-active:
- shard-dg2: NOTRUN -> [SKIP][37] ([i915#3281]) +7 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@gem_exec_reloc@basic-write-read-noreloc:
- shard-dg1: NOTRUN -> [SKIP][38] ([i915#3281]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-chain:
- shard-mtlp: NOTRUN -> [SKIP][39] ([i915#4537] / [i915#4812])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-contexts-chain:
- shard-dg2: NOTRUN -> [SKIP][40] ([i915#4537] / [i915#4812])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@gem_fenced_exec_thrash@no-spare-fences:
- shard-mtlp: NOTRUN -> [SKIP][41] ([i915#4860])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@gem_fenced_exec_thrash@no-spare-fences-busy-interruptible:
- shard-dg2: NOTRUN -> [SKIP][42] ([i915#4860]) +2 other tests skip
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-multi-ccs@lmem0:
- shard-dg2: NOTRUN -> [FAIL][43] ([i915#10378])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random:
- shard-rkl: NOTRUN -> [SKIP][44] ([i915#4613]) +3 other tests skip
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@gem_lmem_swapping@heavy-verify-random-ccs:
- shard-glk: NOTRUN -> [SKIP][45] ([i915#4613]) +2 other tests skip
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk7/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][46] ([i915#4613]) +3 other tests skip
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- shard-tglu: NOTRUN -> [SKIP][47] ([i915#4613])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@[email protected]

* igt@gem_media_fill@media-fill:
- shard-dg2: NOTRUN -> [SKIP][48] ([i915#8289])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gem_mmap@basic-small-bo:
- shard-mtlp: NOTRUN -> [SKIP][49] ([i915#4083]) +2 other tests skip
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@gem_mmap@pf-nonblock:
- shard-dg2: NOTRUN -> [SKIP][50] ([i915#4083]) +5 other tests skip
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-dg1: NOTRUN -> [SKIP][51] ([i915#4077]) +2 other tests skip
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@gem_mmap_wc@close:
- shard-dg1: NOTRUN -> [SKIP][52] ([i915#4083])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@gem_partial_pwrite_pread@reads-uncached:
- shard-dg2: NOTRUN -> [SKIP][53] ([i915#3282]) +6 other tests skip
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-glk: NOTRUN -> [WARN][54] ([i915#2658])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk7/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-rkl: NOTRUN -> [SKIP][55] ([i915#3282]) +1 other test skip
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@gem_pxp@create-valid-protected-context:
- shard-dg1: NOTRUN -> [SKIP][56] ([i915#4270]) +1 other test skip
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-16/igt@[email protected]

* igt@gem_pxp@dmabuf-shared-protected-dst-is-context-refcounted:
- shard-dg2: NOTRUN -> [SKIP][57] ([i915#4270]) +1 other test skip
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@gem_pxp@reject-modify-context-protection-off-1:
- shard-mtlp: NOTRUN -> [SKIP][58] ([i915#4270]) +1 other test skip
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@[email protected]

* igt@gem_pxp@reject-modify-context-protection-on:
- shard-rkl: NOTRUN -> [SKIP][59] ([i915#4270]) +1 other test skip
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@gem_readwrite@read-write:
- shard-mtlp: NOTRUN -> [SKIP][60] ([i915#3282]) +3 other tests skip
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@gem_render_copy@linear-to-vebox-yf-tiled:
- shard-dg2: NOTRUN -> [SKIP][61] ([i915#5190]) +6 other tests skip
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gem_render_copy@y-tiled-ccs-to-y-tiled-mc-ccs:
- shard-mtlp: NOTRUN -> [SKIP][62] ([i915#8428]) +3 other tests skip
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@gem_set_tiling_vs_blt@untiled-to-tiled:
- shard-mtlp: NOTRUN -> [SKIP][63] ([i915#4079]) +2 other tests skip
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]
- shard-rkl: NOTRUN -> [SKIP][64] ([i915#8411])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@gem_softpin@evict-snoop:
- shard-dg2: NOTRUN -> [SKIP][65] ([i915#4885])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@gem_tiled_partial_pwrite_pread@reads:
- shard-mtlp: NOTRUN -> [SKIP][66] ([i915#4077]) +6 other tests skip
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-6/igt@[email protected]

* igt@gem_tiled_partial_pwrite_pread@writes:
- shard-dg2: NOTRUN -> [SKIP][67] ([i915#4077]) +9 other tests skip
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gem_unfence_active_buffers:
- shard-dg2: NOTRUN -> [SKIP][68] ([i915#4879])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@gem_unfence_active_buffers.html

* igt@gem_userptr_blits@access-control:
- shard-mtlp: NOTRUN -> [SKIP][69] ([i915#3297]) +2 other tests skip
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-6/igt@[email protected]

* igt@gem_userptr_blits@coherency-unsync:
- shard-rkl: NOTRUN -> [SKIP][70] ([i915#3297])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-rkl: NOTRUN -> [SKIP][71] ([i915#3323])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@gem_userptr_blits@invalid-mmap-offset-unsync:
- shard-dg1: NOTRUN -> [SKIP][72] ([i915#3297])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate:
- shard-dg2: NOTRUN -> [SKIP][73] ([i915#3297] / [i915#4880]) +1 other test skip
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gem_userptr_blits@relocations:
- shard-mtlp: NOTRUN -> [SKIP][74] ([i915#3281]) +7 other tests skip
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-dg2: NOTRUN -> [SKIP][75] ([i915#3297])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-dg2: NOTRUN -> [SKIP][76] ([i915#2856]) +3 other tests skip
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglu: NOTRUN -> [SKIP][77] ([i915#2527] / [i915#2856])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@[email protected]

* igt@gen9_exec_parse@batch-zero-length:
- shard-mtlp: NOTRUN -> [SKIP][78] ([i915#2856]) +1 other test skip
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@gen9_exec_parse@bb-start-out:
- shard-rkl: NOTRUN -> [SKIP][79] ([i915#2527]) +2 other tests skip
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@i915_fb_tiling:
- shard-mtlp: NOTRUN -> [SKIP][80] ([i915#4881])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@i915_fb_tiling.html
- shard-dg1: NOTRUN -> [SKIP][81] ([i915#4881])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@i915_fb_tiling.html

* igt@i915_module_load@load:
- shard-dg2: NOTRUN -> [SKIP][82] ([i915#6227])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-rkl: [PASS][83] -> [INCOMPLETE][84] ([i915#9820] / [i915#9849])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-rkl-5/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-4/igt@[email protected]

* igt@i915_pm_rps@min-max-config-idle:
- shard-dg2: NOTRUN -> [SKIP][85] ([i915#6621])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@i915_pm_rps@thresholds-park@gt0:
- shard-mtlp: NOTRUN -> [SKIP][86] ([i915#8925])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@i915_pm_rps@[email protected]

* igt@i915_pm_rps@thresholds-park@gt1:
- shard-mtlp: NOTRUN -> [SKIP][87] ([i915#3555] / [i915#8925])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@i915_pm_rps@[email protected]

* igt@i915_pm_sseu@full-enable:
- shard-rkl: NOTRUN -> [SKIP][88] ([i915#4387])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@i915_suspend@basic-s3-without-i915:
- shard-tglu: NOTRUN -> [INCOMPLETE][89] ([i915#7443])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@[email protected]

* igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling:
- shard-dg2: NOTRUN -> [SKIP][90] ([i915#4212])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-1-y-rc-ccs-cc:
- shard-rkl: NOTRUN -> [SKIP][91] ([i915#8709]) +3 other tests skip
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-1-y-rc-ccs-cc.html

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-dp-4-4-rc-ccs-cc:
- shard-dg2: NOTRUN -> [SKIP][92] ([i915#8709]) +11 other tests skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@kms_async_flips@[email protected]

* igt@kms_async_flips@invalid-async-flip:
- shard-mtlp: NOTRUN -> [SKIP][93] ([i915#6228])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-mtlp: NOTRUN -> [SKIP][94] ([i915#1769] / [i915#3555])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
- shard-dg2: NOTRUN -> [SKIP][95] ([i915#1769] / [i915#3555])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html
- shard-glk: NOTRUN -> [SKIP][96] ([i915#1769])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk6/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels.html

* igt@kms_big_fb@4-tiled-32bpp-rotate-90:
- shard-snb: NOTRUN -> [SKIP][97] +3 other tests skip
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-snb4/igt@[email protected]

* igt@kms_big_fb@4-tiled-addfb-size-offset-overflow:
- shard-dg1: NOTRUN -> [SKIP][98] ([i915#5286])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@kms_big_fb@4-tiled-addfb-size-overflow:
- shard-tglu: NOTRUN -> [SKIP][99] ([i915#5286])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-mtlp: [PASS][100] -> [FAIL][101] ([i915#5138])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-mtlp-7/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-rkl: NOTRUN -> [SKIP][102] ([i915#5286])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html

* igt@kms_big_fb@x-tiled-32bpp-rotate-90:
- shard-dg1: NOTRUN -> [SKIP][103] ([i915#3638])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-tglu: [PASS][104] -> [FAIL][105] ([i915#3743])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-tglu-2/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-16bpp-rotate-270:
- shard-dg1: NOTRUN -> [SKIP][106] ([i915#4538])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-16/igt@[email protected]

* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- shard-dg2: NOTRUN -> [SKIP][107] ([i915#4538] / [i915#5190]) +11 other tests skip
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_big_fb@yf-tiled-addfb-size-overflow:
- shard-mtlp: NOTRUN -> [SKIP][108] ([i915#6187]) +1 other test skip
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@kms_cdclk@mode-transition-all-outputs:
- shard-mtlp: NOTRUN -> [SKIP][109] ([i915#7213] / [i915#9010])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@kms_cdclk@plane-scaling@pipe-b-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][110] ([i915#4087]) +3 other tests skip
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@kms_cdclk@[email protected]

* igt@kms_chamelium_edid@dp-edid-stress-resolution-non-4k:
- shard-dg2: NOTRUN -> [SKIP][111] ([i915#7828]) +7 other tests skip
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_chamelium_edid@hdmi-edid-read:
- shard-dg1: NOTRUN -> [SKIP][112] ([i915#7828])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@kms_chamelium_frames@vga-frame-dump:
- shard-rkl: NOTRUN -> [SKIP][113] ([i915#7828]) +3 other tests skip
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@kms_chamelium_hpd@hdmi-hpd-with-enabled-mode:
- shard-mtlp: NOTRUN -> [SKIP][114] ([i915#7828]) +4 other tests skip
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@kms_content_protection@atomic-dpms:
- shard-mtlp: NOTRUN -> [SKIP][115] ([i915#6944] / [i915#9424])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][116] ([i915#7116] / [i915#9424])
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-dg2: NOTRUN -> [SKIP][117] ([i915#3299]) +1 other test skip
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-rkl: NOTRUN -> [SKIP][118] ([i915#3116])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][119] ([i915#3299])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@kms_content_protection@lic-type-1:
- shard-dg2: NOTRUN -> [SKIP][120] ([i915#9424])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@kms_content_protection@uevent@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [FAIL][121] ([i915#1339])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@kms_content_protection@[email protected]

* igt@kms_cursor_crc@cursor-offscreen-512x512:
- shard-rkl: NOTRUN -> [SKIP][122] ([i915#3359])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-32x32:
- shard-dg1: NOTRUN -> [SKIP][123] ([i915#3555]) +2 other tests skip
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@kms_cursor_crc@cursor-random-32x10:
- shard-mtlp: NOTRUN -> [SKIP][124] ([i915#3555] / [i915#8814]) +3 other tests skip
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@kms_cursor_crc@cursor-rapid-movement-64x21:
- shard-mtlp: NOTRUN -> [SKIP][125] ([i915#8814]) +2 other tests skip
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@kms_cursor_crc@cursor-sliding-512x170:
- shard-dg2: NOTRUN -> [SKIP][126] ([i915#3359]) +1 other test skip
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-dg2: NOTRUN -> [SKIP][127] ([i915#5354]) +33 other tests skip
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- shard-mtlp: NOTRUN -> [SKIP][128] ([i915#4213])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]
- shard-rkl: NOTRUN -> [SKIP][129] ([i915#4103])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb-atomic:
- shard-mtlp: NOTRUN -> [SKIP][130] ([i915#9809]) +1 other test skip
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@kms_cursor_legacy@modeset-atomic-cursor-hotspot:
- shard-rkl: NOTRUN -> [SKIP][131] ([i915#9067])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-dg2: NOTRUN -> [SKIP][132] ([i915#4103] / [i915#4213])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_display_modes@extended-mode-basic:
- shard-mtlp: NOTRUN -> [SKIP][133] ([i915#3555] / [i915#8827])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@[email protected]

* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][134] ([i915#3804])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-1/igt@kms_dither@[email protected]

* igt@kms_dp_aux_dev:
- shard-tglu: NOTRUN -> [SKIP][135] ([i915#1257])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@kms_dp_aux_dev.html

* igt@kms_dsc@dsc-fractional-bpp:
- shard-dg2: NOTRUN -> [SKIP][136] ([i915#3840] / [i915#9688])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@kms_dsc@dsc-fractional-bpp-with-bpc:
- shard-rkl: NOTRUN -> [SKIP][137] ([i915#3840])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][138] ([i915#3840])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@kms_dsc@dsc-with-output-formats:
- shard-rkl: NOTRUN -> [SKIP][139] ([i915#3555] / [i915#3840])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@kms_feature_discovery@display-2x:
- shard-tglu: NOTRUN -> [SKIP][140] ([i915#1839])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@[email protected]

* igt@kms_feature_discovery@display-3x:
- shard-mtlp: NOTRUN -> [SKIP][141] ([i915#1839])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@kms_feature_discovery@dp-mst:
- shard-dg2: NOTRUN -> [SKIP][142] ([i915#9337])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@kms_flip@2x-flip-vs-panning-interruptible:
- shard-dg1: NOTRUN -> [SKIP][143] ([i915#9934]) +2 other tests skip
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-dg2: NOTRUN -> [SKIP][144] +28 other tests skip
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-mtlp: NOTRUN -> [SKIP][145] ([i915#3637]) +7 other tests skip
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@kms_flip@2x-plain-flip:
- shard-rkl: NOTRUN -> [SKIP][146] +26 other tests skip
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][147] ([i915#2672])
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode:
- shard-dg1: NOTRUN -> [SKIP][148] ([i915#2587] / [i915#2672])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][149] ([i915#8810])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][150] ([i915#2672])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode:
- shard-dg2: NOTRUN -> [SKIP][151] ([i915#2672]) +4 other tests skip
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][152] ([i915#3555] / [i915#8810]) +1 other test skip
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-32bpp-xtile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling@pipe-a-default-mode:
- shard-mtlp: NOTRUN -> [SKIP][153] ([i915#2672] / [i915#3555]) +1 other test skip
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-upscaling@pipe-a-default-mode.html

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-pwrite:
- shard-dg2: [PASS][154] -> [FAIL][155] ([i915#6880]) +1 other test fail
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg2-1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-pwrite.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][156] ([i915#8708]) +3 other tests skip
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
- shard-snb: [PASS][157] -> [SKIP][158]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-snb6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-snb6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-pgflip-blt:
- shard-dg1: NOTRUN -> [SKIP][159] +14 other tests skip
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-tiling-y:
- shard-dg2: NOTRUN -> [SKIP][160] ([i915#10055])
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-rkl: NOTRUN -> [SKIP][161] ([i915#3023]) +10 other tests skip
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt:
- shard-tglu: NOTRUN -> [SKIP][162] +5 other tests skip
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-mtlp: NOTRUN -> [SKIP][163] ([i915#8708]) +6 other tests skip
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][164] ([i915#1825]) +15 other tests skip
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-cpu:
- shard-mtlp: NOTRUN -> [SKIP][165] ([i915#1825]) +25 other tests skip
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-shrfb-fliptrack-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][166] ([i915#8708]) +22 other tests skip
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-tiling-4:
- shard-rkl: NOTRUN -> [SKIP][167] ([i915#5439])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@kms_frontbuffer_tracking@plane-fbc-rte:
- shard-mtlp: NOTRUN -> [SKIP][168] ([i915#10070])
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
- shard-dg2: NOTRUN -> [SKIP][169] ([i915#3458]) +14 other tests skip
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-rgb565-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][170] ([i915#3458]) +3 other tests skip
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@kms_hdr@static-swap:
- shard-rkl: NOTRUN -> [SKIP][171] ([i915#3555] / [i915#8228])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@kms_hdr@static-toggle:
- shard-dg2: NOTRUN -> [SKIP][172] ([i915#3555] / [i915#8228]) +1 other test skip
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_hdr@static-toggle-dpms:
- shard-mtlp: NOTRUN -> [SKIP][173] ([i915#3555] / [i915#8228]) +1 other test skip
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-6/igt@[email protected]

* igt@kms_panel_fitting@atomic-fastset:
- shard-dg2: NOTRUN -> [SKIP][174] ([i915#6301])
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_pipe_b_c_ivb@pipe-b-dpms-off-modeset-pipe-c:
- shard-mtlp: NOTRUN -> [SKIP][175] +15 other tests skip
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@kms_plane_multiple@tiling-yf:
- shard-dg2: NOTRUN -> [SKIP][176] ([i915#3555] / [i915#8806])
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [FAIL][177] ([i915#8292])
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [SKIP][178] ([i915#9423]) +7 other tests skip
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-rotation@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][179] ([i915#9423]) +3 other tests skip
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][180] ([i915#5176]) +3 other tests skip
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-75-with-rotation@pipe-d-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][181] ([i915#9423]) +3 other tests skip
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-scaler-unity-scaling-with-rotation@pipe-d-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][182] ([i915#9423]) +11 other tests skip
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-15/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][183] ([i915#5235] / [i915#9423]) +7 other tests skip
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-5/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-downscale-factor-0-5-unity-scaling@pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][184] ([i915#5235]) +6 other tests skip
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-hdmi-a-4:
- shard-dg1: NOTRUN -> [SKIP][185] ([i915#5235]) +3 other tests skip
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-16/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][186] ([i915#5235]) +5 other tests skip
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-1/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][187] +218 other tests skip
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk7/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-1.html

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][188] ([i915#3555] / [i915#5235])
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-edp-1.html

* igt@kms_pm_backlight@fade-with-suspend:
- shard-rkl: NOTRUN -> [SKIP][189] ([i915#5354])
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@kms_pm_lpsp@screens-disabled:
- shard-dg2: NOTRUN -> [SKIP][190] ([i915#8430])
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@kms_pm_rpm@dpms-non-lpsp:
- shard-mtlp: NOTRUN -> [SKIP][191] ([i915#9519])
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]
- shard-rkl: NOTRUN -> [SKIP][192] ([i915#9519])
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp:
- shard-dg1: NOTRUN -> [SKIP][193] ([i915#9519])
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]

* igt@kms_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-dg2: NOTRUN -> [SKIP][194] ([i915#9519])
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@kms_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-rkl: [PASS][195] -> [SKIP][196] ([i915#9519])
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-rkl-1/igt@[email protected]
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-4/igt@[email protected]

* igt@kms_psr2_sf@fbc-plane-move-sf-dmg-area@psr2-pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][197] ([i915#9808]) +1 other test skip
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@kms_psr2_sf@[email protected]

* igt@kms_psr2_su@page_flip-p010:
- shard-dg2: NOTRUN -> [SKIP][198] ([i915#9683]) +1 other test skip
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@kms_psr2_su@page_flip-p010.html

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-mtlp: NOTRUN -> [SKIP][199] ([i915#4348])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@kms_psr2_su@page_flip-xrgb8888.html
- shard-dg1: NOTRUN -> [SKIP][200] ([i915#9683])
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_psr@fbc-psr-cursor-mmap-gtt@edp-1:
- shard-mtlp: NOTRUN -> [SKIP][201] ([i915#9688]) +10 other tests skip
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@kms_psr@[email protected]

* igt@kms_psr@fbc-psr-cursor-plane-onoff:
- shard-tglu: NOTRUN -> [SKIP][202] ([i915#9732]) +3 other tests skip
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@[email protected]

* igt@kms_psr@fbc-psr2-sprite-mmap-cpu:
- shard-dg2: NOTRUN -> [SKIP][203] ([i915#9732]) +19 other tests skip
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@kms_psr@psr-cursor-blt:
- shard-rkl: NOTRUN -> [SKIP][204] ([i915#9732]) +9 other tests skip
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@kms_psr@psr2-no-drrs:
- shard-dg2: NOTRUN -> [SKIP][205] ([i915#9673] / [i915#9732]) +4 other tests skip
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@kms_psr@psr2-primary-mmap-cpu:
- shard-dg1: NOTRUN -> [SKIP][206] ([i915#9732]) +7 other tests skip
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-16/igt@[email protected]

* igt@kms_psr@psr2-sprite-mmap-gtt@edp-1:
- shard-mtlp: NOTRUN -> [SKIP][207] ([i915#4077] / [i915#9688])
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@kms_psr@[email protected]

* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-rkl: NOTRUN -> [SKIP][208] ([i915#9685])
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@kms_rotation_crc@bad-pixel-format:
- shard-dg2: NOTRUN -> [SKIP][209] ([i915#4235]) +1 other test skip
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@kms_rotation_crc@primary-4-tiled-reflect-x-180:
- shard-rkl: NOTRUN -> [SKIP][210] ([i915#5289])
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@kms_rotation_crc@primary-y-tiled-reflect-x-90:
- shard-mtlp: NOTRUN -> [SKIP][211] ([i915#4235])
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@[email protected]

* igt@kms_scaling_modes@scaling-mode-none:
- shard-rkl: NOTRUN -> [SKIP][212] ([i915#3555]) +5 other tests skip
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@kms_scaling_modes@scaling-mode-none@pipe-a-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][213] ([i915#5030]) +2 other tests skip
[213]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@kms_scaling_modes@[email protected]

* igt@kms_scaling_modes@scaling-mode-none@pipe-d-edp-1:
- shard-mtlp: NOTRUN -> [SKIP][214] ([i915#5030] / [i915#9041])
[214]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@kms_scaling_modes@[email protected]

* igt@kms_setmode@basic-clone-single-crtc:
- shard-dg2: NOTRUN -> [SKIP][215] ([i915#3555]) +5 other tests skip
[215]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@kms_setmode@clone-exclusive-crtc:
- shard-mtlp: NOTRUN -> [SKIP][216] ([i915#3555] / [i915#8809])
[216]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@kms_sysfs_edid_timing:
- shard-dg2: [PASS][217] -> [FAIL][218] ([IGT#2])
[217]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg2-11/igt@kms_sysfs_edid_timing.html
[218]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-2/igt@kms_sysfs_edid_timing.html

* igt@kms_universal_plane@cursor-fb-leak@pipe-a-edp-1:
- shard-mtlp: [PASS][219] -> [FAIL][220] ([i915#9196])
[219]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-mtlp-5/igt@kms_universal_plane@[email protected]
[220]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-5/igt@kms_universal_plane@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][221] ([i915#9196])
[221]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-1/igt@kms_universal_plane@[email protected]

* igt@kms_vrr@max-min:
- shard-dg2: NOTRUN -> [SKIP][222] ([i915#9906])
[222]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_vrr@seamless-rr-switch-drrs:
- shard-dg1: NOTRUN -> [SKIP][223] ([i915#9906])
[223]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][224] ([i915#8808] / [i915#9906])
[224]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-glk: NOTRUN -> [SKIP][225] ([i915#2437])
[225]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk3/igt@[email protected]

* igt@perf@global-sseu-config-invalid:
- shard-mtlp: NOTRUN -> [SKIP][226] ([i915#7387])
[226]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@perf_pmu@busy-idle-check-all@vcs0:
- shard-dg2: NOTRUN -> [FAIL][227] ([i915#4349]) +3 other tests fail
[227]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@perf_pmu@[email protected]

* igt@perf_pmu@busy-idle-check-all@vecs0:
- shard-mtlp: [PASS][228] -> [FAIL][229] ([i915#4349])
[228]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-mtlp-8/igt@perf_pmu@[email protected]
[229]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-1/igt@perf_pmu@[email protected]

* igt@perf_pmu@rc6@other-idle-gt0:
- shard-dg2: NOTRUN -> [SKIP][230] ([i915#8516])
[230]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-2/igt@perf_pmu@[email protected]

* igt@perf_pmu@rc6@runtime-pm-long-gt0:
- shard-dg2: NOTRUN -> [ABORT][231] ([i915#9853])
[231]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-2/igt@perf_pmu@[email protected]

* igt@prime_vgem@basic-read:
- shard-mtlp: NOTRUN -> [SKIP][232] ([i915#3708])
[232]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-6/igt@[email protected]
- shard-dg1: NOTRUN -> [SKIP][233] ([i915#3708])
[233]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-16/igt@[email protected]

* igt@prime_vgem@basic-write:
- shard-dg2: NOTRUN -> [SKIP][234] ([i915#3291] / [i915#3708])
[234]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@prime_vgem@coherency-gtt:
- shard-dg1: NOTRUN -> [SKIP][235] ([i915#3708] / [i915#4077])
[235]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][236] ([i915#3708] / [i915#4077])
[236]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@[email protected]

* igt@sriov_basic@bind-unbind-vf:
- shard-dg2: NOTRUN -> [SKIP][237] ([i915#9917])
[237]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@[email protected]

* igt@sriov_basic@enable-vfs-autoprobe-off:
- shard-rkl: NOTRUN -> [SKIP][238] ([i915#9917])
[238]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@[email protected]

* igt@sriov_basic@enable-vfs-bind-unbind-each:
- shard-dg1: NOTRUN -> [SKIP][239] ([i915#9917])
[239]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@[email protected]
- shard-mtlp: NOTRUN -> [SKIP][240] ([i915#9917]) +1 other test skip
[240]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@[email protected]

* igt@syncobj_timeline@invalid-wait-zero-handles:
- shard-rkl: NOTRUN -> [FAIL][241] ([i915#9781])
[241]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@syncobj_wait@invalid-wait-zero-handles:
- shard-rkl: NOTRUN -> [FAIL][242] ([i915#9779])
[242]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@[email protected]

* igt@v3d/v3d_mmap@mmap-bo:
- shard-mtlp: NOTRUN -> [SKIP][243] ([i915#2575]) +8 other tests skip
[243]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@v3d/[email protected]

* igt@v3d/v3d_perfmon@create-single-perfmon:
- shard-dg2: NOTRUN -> [SKIP][244] ([i915#2575]) +11 other tests skip
[244]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@v3d/[email protected]

* igt@v3d/v3d_submit_cl@bad-perfmon:
- shard-tglu: NOTRUN -> [SKIP][245] ([i915#2575]) +1 other test skip
[245]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-8/igt@v3d/[email protected]

* igt@v3d/v3d_submit_cl@job-perfmon:
- shard-dg1: NOTRUN -> [SKIP][246] ([i915#2575]) +2 other tests skip
[246]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@v3d/[email protected]

* igt@vc4/vc4_label_bo@set-label:
- shard-dg1: NOTRUN -> [SKIP][247] ([i915#7711])
[247]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-19/igt@vc4/[email protected]

* igt@vc4/vc4_purgeable_bo@mark-purgeable-twice:
- shard-mtlp: NOTRUN -> [SKIP][248] ([i915#7711]) +4 other tests skip
[248]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-4/igt@vc4/[email protected]

* igt@vc4/vc4_tiling@get-bad-handle:
- shard-rkl: NOTRUN -> [SKIP][249] ([i915#7711]) +3 other tests skip
[249]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-7/igt@vc4/[email protected]

* igt@vc4/vc4_tiling@get-bad-modifier:
- shard-dg2: NOTRUN -> [SKIP][250] ([i915#7711]) +8 other tests skip
[250]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@vc4/[email protected]

#### Possible fixes ####

* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [FAIL][251] ([i915#7742]) -> [PASS][252]
[251]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-rkl-3/igt@drm_fdinfo@[email protected]
[252]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-5/igt@drm_fdinfo@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][253] ([i915#2842]) -> [PASS][254]
[253]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-glk9/igt@gem_exec_fair@[email protected]
[254]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-rkl: [FAIL][255] ([i915#2842]) -> [PASS][256]
[255]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-rkl-7/igt@gem_exec_fair@[email protected]
[256]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglu: [FAIL][257] ([i915#2842]) -> [PASS][258]
[257]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-tglu-3/igt@gem_exec_fair@[email protected]
[258]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-9/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@heavy-random@lmem0:
- shard-dg2: [FAIL][259] ([i915#10378]) -> [PASS][260]
[259]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg2-5/igt@gem_lmem_swapping@[email protected]
[260]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@gem_lmem_swapping@[email protected]

* igt@gem_lmem_swapping@parallel-random-verify@lmem0:
- shard-dg2: [INCOMPLETE][261] -> [PASS][262]
[261]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg2-5/igt@gem_lmem_swapping@[email protected]
[262]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-6/igt@gem_lmem_swapping@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-glk: [INCOMPLETE][263] ([i915#5566]) -> [PASS][264]
[263]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-glk4/igt@[email protected]
[264]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk6/igt@[email protected]

* igt@i915_pm_rps@reset:
- shard-snb: [INCOMPLETE][265] ([i915#7790]) -> [PASS][266]
[265]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-snb5/igt@[email protected]
[266]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-snb4/igt@[email protected]

* igt@kms_big_fb@4-tiled-64bpp-rotate-180:
- shard-mtlp: [FAIL][267] ([i915#5138]) -> [PASS][268]
[267]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-mtlp-5/igt@[email protected]
[268]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-2/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-tglu: [FAIL][269] ([i915#3743]) -> [PASS][270]
[269]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-tglu-7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
[270]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html

* igt@kms_busy@extended-modeset-hang-oldfb-with-reset@pipe-a:
- shard-dg2: [ABORT][271] -> [PASS][272]
[271]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg2-11/igt@kms_busy@[email protected]
[272]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-2/igt@kms_busy@[email protected]

* igt@kms_dp_aux_dev:
- shard-dg2: [SKIP][273] ([i915#1257]) -> [PASS][274]
[273]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg2-10/igt@kms_dp_aux_dev.html
[274]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@kms_dp_aux_dev.html

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-dg2: [FAIL][275] ([i915#6880]) -> [PASS][276]
[275]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg2-5/igt@[email protected]
[276]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-1/igt@[email protected]

* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-rkl: [SKIP][277] ([i915#9519]) -> [PASS][278] +1 other test pass
[277]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-rkl-5/igt@[email protected]
[278]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-1/igt@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-a-hdmi-a-1:
- shard-tglu: [FAIL][279] ([i915#9196]) -> [PASS][280]
[279]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-tglu-7/igt@kms_universal_plane@[email protected]
[280]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-tglu-4/igt@kms_universal_plane@[email protected]

* igt@perf_pmu@busy-double-start@ccs0:
- shard-mtlp: [FAIL][281] ([i915#4349]) -> [PASS][282] +1 other test pass
[281]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-mtlp-7/igt@perf_pmu@[email protected]
[282]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-mtlp-7/igt@perf_pmu@[email protected]

#### Warnings ####

* igt@device_reset@unbind-reset-rebind:
- shard-glk: [INCOMPLETE][283] ([i915#1982] / [i915#5507]) -> [INCOMPLETE][284] ([i915#5507])
[283]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-glk3/igt@[email protected]
[284]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-glk8/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- shard-dg1: [INCOMPLETE][285] ([i915#9820] / [i915#9849]) -> [INCOMPLETE][286] ([i915#9849])
[285]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg1-14/igt@[email protected]
[286]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg1-18/igt@[email protected]

* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][287] ([i915#4816]) -> [SKIP][288] ([i915#4070] / [i915#4816])
[287]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-rkl-4/igt@[email protected]
[288]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-rkl-1/igt@[email protected]

* igt@kms_psr@psr-cursor-render:
- shard-dg2: [SKIP][289] ([i915#9673] / [i915#9732]) -> [SKIP][290] ([i915#9732]) +5 other tests skip
[289]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg2-11/igt@[email protected]
[290]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-5/igt@[email protected]

* igt@kms_psr@psr2-primary-blt:
- shard-dg2: [SKIP][291] ([i915#9732]) -> [SKIP][292] ([i915#9673] / [i915#9732]) +14 other tests skip
[291]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg2-5/igt@[email protected]
[292]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@[email protected]

* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][293] ([i915#7484]) -> [FAIL][294] ([i915#3089])
[293]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14400/shard-dg2-5/igt@perf@[email protected]
[294]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/shard-dg2-11/igt@perf@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes
-------------

* Linux: CI_DRM_14400 -> Patchwork_130851v1
* Piglit: piglit_4509 -> None

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_130851v1/index.html

Lin, Wayne

author

2024-04-15 02:55 UTC #5 lore raw

In reply to Wayne Lin

[Public]

Ping for code review. Thanks!

Regards,
Wayne

________________________________________
From: Wayne Lin <[email protected]>
Sent: Thursday, March 7, 2024 14:29
To: [email protected]; [email protected]; [email protected]
Cc: [email protected]; Wentland, Harry; [email protected]; Lin, Wayne; Leon Weiß; [email protected]; [email protected]
Subject: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2

[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().

Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement")

Reported-by Leon Weiß <[email protected]>

Link https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.camel@ruhr-uni-bochum.de/ open here

Cc [email protected]

Signed-off-by Wayne Lin <[email protected]>

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
 drivers/gpu/drm/display/drm_dp_mst_topology.c             | 4 +---
 drivers/gpu/drm/i915/display/intel_dp_mst.c               | 2 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c                   | 2 +-
 include/drm/display/drm_dp_mst_helper.h                   | 1 -
 5 files changed, 4 insertions(+), 7 deletions(-)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1 -1

index c27063305a13..2c36f3d00ca2 100644
@@ -363,7 +363,7 @@ void dm_helpers_dp_mst_send_payload_allocation(
        mst_state = to_drm_dp_mst_topology_state(mst_mgr->base.state);
        new_payload = drm_atomic_get_mst_payload_state(mst_state, aconnector->mst_output_port);
 
-       ret = drm_dp_add_payload_part2(mst_mgr, mst_state->base.state, new_payload);
+       ret = drm_dp_add_payload_part2(mst_mgr, new_payload);
 
        if (ret) {
                amdgpu_dm_set_mst_status(&aconnector->mst_status,

drivers/gpu/drm/display/drm_dp_mst_topology.c +1 -3

index 03d528209426..95fd18f24e94 100644
@@ -3421,7 +3421,6 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
 /**
  * drm_dp_add_payload_part2() - Execute payload update part 2
  * @mgr: Manager to use.
- * @state: The global atomic state
  * @payload: The payload to update
  *
  * If @payload was successfully assigned a starting time slot by drm_dp_add_payload_part1(), this

@@ -3430,14 +3429,13 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
  * Returns: 0 on success, negative error code on failure.
  */
 int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-                            struct drm_atomic_state *state,
                             struct drm_dp_mst_atomic_payload *payload)
 {
        int ret = 0;
 
        /* Skip failed payloads */
        if (payload->payload_allocation_status != DRM_DP_MST_PAYLOAD_ALLOCATION_DFP) {
-               drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
+               drm_dbg_kms(mgr->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
                            payload->port->connector->name);
                return -EIO;
        }

drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -1

index 53aec023ce92..2fba66aec038 100644
@@ -1160,7 +1160,7 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
        if (first_mst_stream)
                intel_ddi_wait_for_fec_status(encoder, pipe_config, true);
 
-       drm_dp_add_payload_part2(&intel_dp->mst_mgr, &state->base,
+       drm_dp_add_payload_part2(&intel_dp->mst_mgr,
                                 drm_atomic_get_mst_payload_state(mst_state, connector->port));
 
        if (DISPLAY_VER(dev_priv) >= 12)

drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -1

index 0c3d88ad0b0e..88728a0b2c25 100644
@@ -915,7 +915,7 @@ nv50_msto_cleanup(struct drm_atomic_state *state,
                msto->disabled = false;
                drm_dp_remove_payload_part2(mgr, new_mst_state, old_payload, new_payload);
        } else if (msto->enabled) {
-               drm_dp_add_payload_part2(mgr, state, new_payload);
+               drm_dp_add_payload_part2(mgr, new_payload);
                msto->enabled = false;
        }
 }

include/drm/display/drm_dp_mst_helper.h +0 -1

index 9b19d8bd520a..6c9145abc7e2 100644
@@ -851,7 +851,6 @@ int drm_dp_add_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
                             struct drm_dp_mst_topology_state *mst_state,
                             struct drm_dp_mst_atomic_payload *payload);
 int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-                            struct drm_atomic_state *state,
                             struct drm_dp_mst_atomic_payload *payload);
 void drm_dp_remove_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
                                 struct drm_dp_mst_topology_state *mst_state,

--
2.37.3

Patchwork

2024-04-15 20:31 UTC #6 lore raw

✗ Fi.CI.BUILD: failure for drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2 (rev2)

In reply to Wayne Lin

== Series Details ==

Series: drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2 (rev2)
URL : https://patchwork.freedesktop.org/series/130851/
State : failure

== Summary ==

Error: patch https://patchwork.freedesktop.org/api/1.0/series/130851/revisions/2/mbox/ not applied
Applying: drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
error: patch failed: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c:363
error: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c: patch does not apply
error: patch failed: drivers/gpu/drm/display/drm_dp_mst_topology.c:3430
error: drivers/gpu/drm/display/drm_dp_mst_topology.c: patch does not apply
error: patch failed: drivers/gpu/drm/i915/display/intel_dp_mst.c:1160
error: drivers/gpu/drm/i915/display/intel_dp_mst.c: patch does not apply
error: patch failed: drivers/gpu/drm/nouveau/dispnv50/disp.c:915
error: drivers/gpu/drm/nouveau/dispnv50/disp.c: patch does not apply
error: patch failed: include/drm/display/drm_dp_mst_helper.h:851
error: include/drm/display/drm_dp_mst_helper.h: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
M drivers/gpu/drm/display/drm_dp_mst_topology.c
M drivers/gpu/drm/i915/display/intel_dp_mst.c
M include/drm/display/drm_dp_mst_helper.h
Patch failed at 0001 drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2 When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Build failed, no error log produced

Harry Wentland

maintainer Reviewed-by on v1 1/1

2024-04-18 19:43 UTC #7 lore raw

In reply to Wayne Lin

Quoted 11 lines · Wayne Lin

[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression.
[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().

Quoted 8 lines

Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement")
Reported-by Leon Weiß <[email protected]>
Link https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.camel@ruhr-uni-bochum.de/ open here
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Wayne Lin <[email protected]>

I haven't been deep in MST code in a while but this all looks pretty straightforward and good.

Reviewed-by Harry Wentland <[email protected]>

Harry

Quoted 87 lines

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
 drivers/gpu/drm/display/drm_dp_mst_topology.c             | 4 +---
 drivers/gpu/drm/i915/display/intel_dp_mst.c               | 2 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c                   | 2 +-
 include/drm/display/drm_dp_mst_helper.h                   | 1 -
 5 files changed, 4 insertions(+), 7 deletions(-)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1 -1

index c27063305a13..2c36f3d00ca2 100644
@@ -363,7 +363,7 @@ void dm_helpers_dp_mst_send_payload_allocation(
 	mst_state = to_drm_dp_mst_topology_state(mst_mgr->base.state);
 	new_payload = drm_atomic_get_mst_payload_state(mst_state, aconnector->mst_output_port);
 
-	ret = drm_dp_add_payload_part2(mst_mgr, mst_state->base.state, new_payload);
+	ret = drm_dp_add_payload_part2(mst_mgr, new_payload);
 
 	if (ret) {
 		amdgpu_dm_set_mst_status(&aconnector->mst_status,

drivers/gpu/drm/display/drm_dp_mst_topology.c +1 -3

index 03d528209426..95fd18f24e94 100644
@@ -3421,7 +3421,6 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
 /**
  * drm_dp_add_payload_part2() - Execute payload update part 2
  * @mgr: Manager to use.
- * @state: The global atomic state
  * @payload: The payload to update
  *
  * If @payload was successfully assigned a starting time slot by drm_dp_add_payload_part1(), this

@@ -3430,14 +3429,13 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
  * Returns: 0 on success, negative error code on failure.
  */
 int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-			     struct drm_atomic_state *state,
 			     struct drm_dp_mst_atomic_payload *payload)
 {
 	int ret = 0;
 
 	/* Skip failed payloads */
 	if (payload->payload_allocation_status != DRM_DP_MST_PAYLOAD_ALLOCATION_DFP) {
-		drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
+		drm_dbg_kms(mgr->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
 			    payload->port->connector->name);
 		return -EIO;
 	}

drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -1

index 53aec023ce92..2fba66aec038 100644
@@ -1160,7 +1160,7 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
 	if (first_mst_stream)
 		intel_ddi_wait_for_fec_status(encoder, pipe_config, true);
 
-	drm_dp_add_payload_part2(&intel_dp->mst_mgr, &state->base,
+	drm_dp_add_payload_part2(&intel_dp->mst_mgr,
 				 drm_atomic_get_mst_payload_state(mst_state, connector->port));
 
 	if (DISPLAY_VER(dev_priv) >= 12)

drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -1

index 0c3d88ad0b0e..88728a0b2c25 100644
@@ -915,7 +915,7 @@ nv50_msto_cleanup(struct drm_atomic_state *state,
 		msto->disabled = false;
 		drm_dp_remove_payload_part2(mgr, new_mst_state, old_payload, new_payload);
 	} else if (msto->enabled) {
-		drm_dp_add_payload_part2(mgr, state, new_payload);
+		drm_dp_add_payload_part2(mgr, new_payload);
 		msto->enabled = false;
 	}
 }

include/drm/display/drm_dp_mst_helper.h +0 -1

index 9b19d8bd520a..6c9145abc7e2 100644
@@ -851,7 +851,6 @@ int drm_dp_add_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
 			     struct drm_dp_mst_topology_state *mst_state,
 			     struct drm_dp_mst_atomic_payload *payload);
 int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-			     struct drm_atomic_state *state,
 			     struct drm_dp_mst_atomic_payload *payload);
 void drm_dp_remove_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
 				 struct drm_dp_mst_topology_state *mst_state,

Linux regression tracking (Thorsten Leemhuis)

2024-05-09 12:43 UTC #8 lore raw

Quoted 21 lines · Harry Wentland

Quoted 11 lines · Wayne Lin
[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression.
[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().
Quoted 8 lines
Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement")
Reported-by Leon Weiß <[email protected]>
Link https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.camel@ruhr-uni-bochum.de/ open here
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Wayne Lin <[email protected]>

Quoted 4 lines

I haven't been deep in MST code in a while but this all looks pretty straightforward and good.
Reviewed-by Harry Wentland <[email protected]>

Hmmm, that was three weeks ago, but it seems since then nothing happened to fix the linked regression through this or some other patch. Is there a reason? The build failure report from the CI maybe?

Wayne Lin, do you know what's up?

Ciao, Thorsten

Quoted 90 lines

Quoted 87 lines

---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
 drivers/gpu/drm/display/drm_dp_mst_topology.c             | 4 +---
 drivers/gpu/drm/i915/display/intel_dp_mst.c               | 2 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c                   | 2 +-
 include/drm/display/drm_dp_mst_helper.h                   | 1 -
 5 files changed, 4 insertions(+), 7 deletions(-)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1 -1

index c27063305a13..2c36f3d00ca2 100644
@@ -363,7 +363,7 @@ void dm_helpers_dp_mst_send_payload_allocation(
 	mst_state = to_drm_dp_mst_topology_state(mst_mgr->base.state);
 	new_payload = drm_atomic_get_mst_payload_state(mst_state, aconnector->mst_output_port);
 
-	ret = drm_dp_add_payload_part2(mst_mgr, mst_state->base.state, new_payload);
+	ret = drm_dp_add_payload_part2(mst_mgr, new_payload);
 
 	if (ret) {
 		amdgpu_dm_set_mst_status(&aconnector->mst_status,

drivers/gpu/drm/display/drm_dp_mst_topology.c +1 -3

index 03d528209426..95fd18f24e94 100644
@@ -3421,7 +3421,6 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
 /**
  * drm_dp_add_payload_part2() - Execute payload update part 2
  * @mgr: Manager to use.
- * @state: The global atomic state
  * @payload: The payload to update
  *
  * If @payload was successfully assigned a starting time slot by drm_dp_add_payload_part1(), this

@@ -3430,14 +3429,13 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
  * Returns: 0 on success, negative error code on failure.
  */
 int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-			     struct drm_atomic_state *state,
 			     struct drm_dp_mst_atomic_payload *payload)
 {
 	int ret = 0;
 
 	/* Skip failed payloads */
 	if (payload->payload_allocation_status != DRM_DP_MST_PAYLOAD_ALLOCATION_DFP) {
-		drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
+		drm_dbg_kms(mgr->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
 			    payload->port->connector->name);
 		return -EIO;
 	}

drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -1

index 53aec023ce92..2fba66aec038 100644
@@ -1160,7 +1160,7 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
 	if (first_mst_stream)
 		intel_ddi_wait_for_fec_status(encoder, pipe_config, true);
 
-	drm_dp_add_payload_part2(&intel_dp->mst_mgr, &state->base,
+	drm_dp_add_payload_part2(&intel_dp->mst_mgr,
 				 drm_atomic_get_mst_payload_state(mst_state, connector->port));
 
 	if (DISPLAY_VER(dev_priv) >= 12)

drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -1

index 0c3d88ad0b0e..88728a0b2c25 100644
@@ -915,7 +915,7 @@ nv50_msto_cleanup(struct drm_atomic_state *state,
 		msto->disabled = false;
 		drm_dp_remove_payload_part2(mgr, new_mst_state, old_payload, new_payload);
 	} else if (msto->enabled) {
-		drm_dp_add_payload_part2(mgr, state, new_payload);
+		drm_dp_add_payload_part2(mgr, new_payload);
 		msto->enabled = false;
 	}
 }

include/drm/display/drm_dp_mst_helper.h +0 -1

index 9b19d8bd520a..6c9145abc7e2 100644
@@ -851,7 +851,6 @@ int drm_dp_add_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
 			     struct drm_dp_mst_topology_state *mst_state,
 			     struct drm_dp_mst_atomic_payload *payload);
 int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-			     struct drm_atomic_state *state,
 			     struct drm_dp_mst_atomic_payload *payload);
 void drm_dp_remove_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
 				 struct drm_dp_mst_topology_state *mst_state,

Mario Limonciello

2024-05-09 19:18 UTC #9 lore raw

Quoted 22 lines · Linux regression tracking (Thorsten Leemhuis)

Quoted 21 lines · Harry Wentland
Quoted 19 lines · Wayne Lin
[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression.
[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().
Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement")
Reported-by Leon Weiß <[email protected]>
Link https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.camel@ruhr-uni-bochum.de/ open here
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Wayne Lin <[email protected]>

Quoted 8 lines

Quoted 4 lines
I haven't been deep in MST code in a while but this all looks pretty straightforward and good.
Reviewed-by Harry Wentland <[email protected]>
Hmmm, that was three weeks ago, but it seems since then nothing happened to fix the linked regression through this or some other patch. Is there a reason? The build failure report from the CI maybe?

It touches files outside of amd but only has an ack from AMD. I think we /probably/ want an ack from i915 and nouveau to take it through.

Quoted 96 lines

Wayne Lin, do you know what's up?

Ciao, Thorsten

Quoted 90 lines

Quoted 87 lines

---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
  drivers/gpu/drm/display/drm_dp_mst_topology.c             | 4 +---
  drivers/gpu/drm/i915/display/intel_dp_mst.c               | 2 +-
  drivers/gpu/drm/nouveau/dispnv50/disp.c                   | 2 +-
  include/drm/display/drm_dp_mst_helper.h                   | 1 -
  5 files changed, 4 insertions(+), 7 deletions(-)

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1 -1

index c27063305a13..2c36f3d00ca2 100644
@@ -363,7 +363,7 @@ void dm_helpers_dp_mst_send_payload_allocation(
  	mst_state = to_drm_dp_mst_topology_state(mst_mgr->base.state);
  	new_payload = drm_atomic_get_mst_payload_state(mst_state, aconnector->mst_output_port);
 
-	ret = drm_dp_add_payload_part2(mst_mgr, mst_state->base.state, new_payload);
+	ret = drm_dp_add_payload_part2(mst_mgr, new_payload);
 
  	if (ret) {
  		amdgpu_dm_set_mst_status(&aconnector->mst_status,

drivers/gpu/drm/display/drm_dp_mst_topology.c +1 -3

index 03d528209426..95fd18f24e94 100644
@@ -3421,7 +3421,6 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
  /**
   * drm_dp_add_payload_part2() - Execute payload update part 2
   * @mgr: Manager to use.
- * @state: The global atomic state
   * @payload: The payload to update
   *
   * If @payload was successfully assigned a starting time slot by drm_dp_add_payload_part1(), this

@@ -3430,14 +3429,13 @@ EXPORT_SYMBOL(drm_dp_remove_payload_part2);
   * Returns: 0 on success, negative error code on failure.
   */
  int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-			     struct drm_atomic_state *state,
  			     struct drm_dp_mst_atomic_payload *payload)
  {
  	int ret = 0;
 
  	/* Skip failed payloads */
  	if (payload->payload_allocation_status != DRM_DP_MST_PAYLOAD_ALLOCATION_DFP) {
-		drm_dbg_kms(state->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
+		drm_dbg_kms(mgr->dev, "Part 1 of payload creation for %s failed, skipping part 2\n",
  			    payload->port->connector->name);
  		return -EIO;
  	}

drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -1

index 53aec023ce92..2fba66aec038 100644
@@ -1160,7 +1160,7 @@ static void intel_mst_enable_dp(struct intel_atomic_state *state,
  	if (first_mst_stream)
  		intel_ddi_wait_for_fec_status(encoder, pipe_config, true);
 
-	drm_dp_add_payload_part2(&intel_dp->mst_mgr, &state->base,
+	drm_dp_add_payload_part2(&intel_dp->mst_mgr,
  				 drm_atomic_get_mst_payload_state(mst_state, connector->port));
 
  	if (DISPLAY_VER(dev_priv) >= 12)

drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -1

index 0c3d88ad0b0e..88728a0b2c25 100644
@@ -915,7 +915,7 @@ nv50_msto_cleanup(struct drm_atomic_state *state,
  		msto->disabled = false;
  		drm_dp_remove_payload_part2(mgr, new_mst_state, old_payload, new_payload);
  	} else if (msto->enabled) {
-		drm_dp_add_payload_part2(mgr, state, new_payload);
+		drm_dp_add_payload_part2(mgr, new_payload);
  		msto->enabled = false;
  	}
  }

include/drm/display/drm_dp_mst_helper.h +0 -1

index 9b19d8bd520a..6c9145abc7e2 100644
@@ -851,7 +851,6 @@ int drm_dp_add_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
  			     struct drm_dp_mst_topology_state *mst_state,
  			     struct drm_dp_mst_atomic_payload *payload);
  int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-			     struct drm_atomic_state *state,
  			     struct drm_dp_mst_atomic_payload *payload);
  void drm_dp_remove_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
  				 struct drm_dp_mst_topology_state *mst_state,

Lin, Wayne

author

2024-05-10 03:18 UTC #10 lore raw

[Public]

Quoted 40 lines

-----Original Message-----
From: Limonciello, Mario <[email protected]>
Sent: Friday, May 10, 2024 3:18 AM
To: Linux regressions mailing list <[email protected]>; Wentland, Harry <[email protected]>; Lin, Wayne <[email protected]>
Cc: [email protected]; [email protected]; Leon Weiß <leon.weiss@ruhr-uni- bochum.de>; [email protected]; [email protected]; amd- [email protected]; [email protected]
Subject: Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
Quoted 28 lines · Linux regression tracking (Thorsten Leemhuis)
Quoted 27 lines · Harry Wentland
Quoted 14 lines · Wayne Lin
[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression.
[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().
Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload
allocation/removement")
Reported-by Leon Weiß <[email protected]>
Quoted 8 lines
Link:
https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.c
[email protected]/
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Wayne Lin <[email protected]>
I haven't been deep in MST code in a while but this all looks pretty straightforward and good.

Quoted 8 lines

Quoted 5 lines
Quoted 1 line
Reviewed-by Harry Wentland <[email protected]>
Hmmm, that was three weeks ago, but it seems since then nothing happened to fix the linked regression through this or some other patch. Is there a reason? The build failure report from the CI maybe?
It touches files outside of amd but only has an ack from AMD. I think we /probably/ want an ack from i915 and nouveau to take it through.

Thanks, Mario!

Hi Thorsten,
Yeah, like what Mario said. Would also like to have ack from i915 and nouveau.

Quoted 105 lines

Quoted 25 lines
Wayne Lin, do you know what's up?
Ciao, Thorsten
Quoted 19 lines
Quoted 19 lines
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
  drivers/gpu/drm/display/drm_dp_mst_topology.c             | 4 +---
  drivers/gpu/drm/i915/display/intel_dp_mst.c               | 2 +-
  drivers/gpu/drm/nouveau/dispnv50/disp.c                   | 2 +-
  include/drm/display/drm_dp_mst_helper.h                   | 1 -
  5 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c index c27063305a13..2c36f3d00ca2 100644
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +0 -0
@@ -363,7 +363,7 @@ void dm_helpers_dp_mst_send_payload_allocation(
          mst_state = to_drm_dp_mst_topology_state(mst_mgr->base.state);
          new_payload = drm_atomic_get_mst_payload_state(mst_state,
 aconnector->mst_output_port);
 
Quoted 1 line
Quoted 1 line
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c void dm_helpers_dp_mst_send_payload_allocation( · line 367
Quoted 1 line
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +0 -1
- ret = drm_dp_add_payload_part2(mst_mgr, mst_state->base.state,
new_payload);
Quoted 10 lines
Quoted 10 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c
Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1 -0
+ ret = drm_dp_add_payload_part2(mst_mgr, new_payload);
 
          if (ret) {
                  amdgpu_dm_set_mst_status(&aconnector->mst_status,
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -0
index 03d528209426..95fd18f24e94 100644
@@ -3421,7 +3421,6 @@
EXPORT_SYMBOL(drm_dp_remove_payload_part2);
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -1
  /**
   * drm_dp_add_payload_part2() - Execute payload update part 2
   * @mgr: Manager to use.
- * @state: The global atomic state
   * @payload: The payload to update
   *
   * If @payload was successfully assigned a starting time slot by
drm_dp_add_payload_part1(), this @@ -3430,14 +3429,13 @@
EXPORT_SYMBOL(drm_dp_remove_payload_part2);
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
* Returns: 0 on success, negative error code on failure. */
int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
- struct drm_atomic_state *state,
struct drm_dp_mst_atomic_payload *payload)
  {
          int ret = 0;

          /* Skip failed payloads */
          if (payload->payload_allocation_status !=
DRM_DP_MST_PAYLOAD_ALLOCATION_DFP) {
Quoted 1 line
Quoted 1 line
Quoted 1 line
- drm_dbg_kms(state->dev, "Part 1 of payload creation for %s
failed, skipping part 2\n",
Quoted 1 line
Quoted 1 line
Quoted 1 line
+ drm_dbg_kms(mgr->dev, "Part 1 of payload creation for %s
failed,
Quoted 10 lines
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c static void intel_mst_enable_dp(struct
Quoted 10 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +1 -0
+skipping part 2\n",
                              payload->port->connector->name);
                  return -EIO;
          }
drivers/gpu/drm/i915/display/intel_dp_mst.c +0 -0
index 53aec023ce92..2fba66aec038 100644
@@ -1160,7 +1160,7 @@ static void intel_mst_enable_dp(struct
intel_atomic_state *state,
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c static void intel_mst_enable_dp(struct intel_atomic_state *state, · line 1165
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -1
          if (first_mst_stream)
                  intel_ddi_wait_for_fec_status(encoder, pipe_config, true);
 
- drm_dp_add_payload_part2(&intel_dp->mst_mgr, &state->base,
+ drm_dp_add_payload_part2(&intel_dp->mst_mgr,
 
drm_atomic_get_mst_payload_state(mst_state,
Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/nouveau/dispnv50/disp.c nv50_msto_cleanup(struct drm_atomic_state *state, · line 916
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c +0 -0
 connector->port));
 
          if (DISPLAY_VER(dev_priv) >= 12)
drivers/gpu/drm/nouveau/dispnv50/disp.c +0 -0
index 0c3d88ad0b0e..88728a0b2c25 100644
@@ -915,7 +915,7 @@ nv50_msto_cleanup(struct drm_atomic_state *state,
                  msto->disabled = false;
                  drm_dp_remove_payload_part2(mgr, new_mst_state,
old_payload, new_payload);
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -1
          } else if (msto->enabled) {
-         drm_dp_add_payload_part2(mgr, state, new_payload);
+         drm_dp_add_payload_part2(mgr, new_payload);
                  msto->enabled = false;
Quoted 8 lines
Quoted 8 lines
include/drm/display/drm_dp_mst_helper.h int drm_dp_add_payload_part1(struct
Quoted 8 lines
drivers/gpu/drm/nouveau/dispnv50/disp.c +0 -0
          }
  }
include/drm/display/drm_dp_mst_helper.h +0 -0
index 9b19d8bd520a..6c9145abc7e2 100644
@@ -851,7 +851,6 @@ int drm_dp_add_payload_part1(struct
drm_dp_mst_topology_mgr *mgr,

Quoted 12 lines

Quoted 6 lines

include/drm/display/drm_dp_mst_helper.h int drm_dp_add_payload_part1(struct drm_dp_mst_topology_mgr *mgr,

Quoted 6 lines

include/drm/display/drm_dp_mst_helper.h +0 -1

                               struct drm_dp_mst_topology_state *mst_state,
                               struct drm_dp_mst_atomic_payload *payload);
  int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-                      struct drm_atomic_state *state,
                               struct drm_dp_mst_atomic_payload *payload);
  void drm_dp_remove_payload_part1(struct drm_dp_mst_topology_mgr

*mgr,

Quoted 5 lines

Quoted 4 lines

Quoted 1 line

include/drm/display/drm_dp_mst_helper.h +0 -0

                                   struct drm_dp_mst_topology_state *mst_state,

---
Regards,
Wayne Lin

Jani Nikula

maintainer Acked-by

2024-05-10 09:24 UTC #11 lore raw

Quoted 48 lines · Wayne

[Public]
Quoted 46 lines
-----Original Message-----
From: Limonciello, Mario <[email protected]>
Sent: Friday, May 10, 2024 3:18 AM
To: Linux regressions mailing list <[email protected]>; Wentland, Harry <[email protected]>; Lin, Wayne <[email protected]>
Cc: [email protected]; [email protected]; Leon Weiß <leon.weiss@ruhr-uni- bochum.de>; [email protected]; [email protected]; amd- [email protected]; [email protected]
Subject: Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
Quoted 33 lines · Linux regression tracking (Thorsten Leemhuis)
Quoted 24 lines · Harry Wentland
Quoted 14 lines · Wayne Lin
[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression.
[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().
Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload
allocation/removement")
Reported-by Leon Weiß <[email protected]>
Quoted 8 lines
Link:
https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.c
[email protected]/
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Wayne Lin <[email protected]>
Quoted 4 lines
I haven't been deep in MST code in a while but this all looks pretty straightforward and good.
Reviewed-by Harry Wentland <[email protected]>
Hmmm, that was three weeks ago, but it seems since then nothing happened to fix the linked regression through this or some other patch. Is there a reason? The build failure report from the CI maybe?

Quoted 7 lines

Quoted 2 lines
It touches files outside of amd but only has an ack from AMD. I think we /probably/ want an ack from i915 and nouveau to take it through.
Thanks, Mario!
Hi Thorsten,
Yeah, like what Mario said. Would also like to have ack from i915 and nouveau.

It usually works better if you Cc the folks you want an ack from! ;)

Acked-by Jani Nikula <[email protected]>

Quoted 121 lines

Quoted 106 lines
Quoted 26 lines
Wayne Lin, do you know what's up?
Ciao, Thorsten
Quoted 19 lines
Quoted 19 lines
---
  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
  drivers/gpu/drm/display/drm_dp_mst_topology.c             | 4 +---
  drivers/gpu/drm/i915/display/intel_dp_mst.c               | 2 +-
  drivers/gpu/drm/nouveau/dispnv50/disp.c                   | 2 +-
  include/drm/display/drm_dp_mst_helper.h                   | 1 -
  5 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c index c27063305a13..2c36f3d00ca2 100644
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +0 -0
@@ -363,7 +363,7 @@ void dm_helpers_dp_mst_send_payload_allocation(
          mst_state = to_drm_dp_mst_topology_state(mst_mgr->base.state);
          new_payload = drm_atomic_get_mst_payload_state(mst_state,
 aconnector->mst_output_port);
 
Quoted 1 line
Quoted 1 line
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c void dm_helpers_dp_mst_send_payload_allocation( · line 367
Quoted 1 line
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +0 -1
- ret = drm_dp_add_payload_part2(mst_mgr, mst_state->base.state,
new_payload);
Quoted 10 lines
Quoted 10 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c
Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +1 -0
+ ret = drm_dp_add_payload_part2(mst_mgr, new_payload);
 
          if (ret) {
                  amdgpu_dm_set_mst_status(&aconnector->mst_status,
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -0
index 03d528209426..95fd18f24e94 100644
@@ -3421,7 +3421,6 @@
EXPORT_SYMBOL(drm_dp_remove_payload_part2);
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +0 -1
  /**
   * drm_dp_add_payload_part2() - Execute payload update part 2
   * @mgr: Manager to use.
- * @state: The global atomic state
   * @payload: The payload to update
   *
   * If @payload was successfully assigned a starting time slot by
drm_dp_add_payload_part1(), this @@ -3430,14 +3429,13 @@
EXPORT_SYMBOL(drm_dp_remove_payload_part2);
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
* Returns: 0 on success, negative error code on failure. */
int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
- struct drm_atomic_state *state,
struct drm_dp_mst_atomic_payload *payload)
  {
          int ret = 0;

          /* Skip failed payloads */
          if (payload->payload_allocation_status !=
DRM_DP_MST_PAYLOAD_ALLOCATION_DFP) {
Quoted 1 line
Quoted 1 line
Quoted 1 line
- drm_dbg_kms(state->dev, "Part 1 of payload creation for %s
failed, skipping part 2\n",
Quoted 1 line
Quoted 1 line
Quoted 1 line
+ drm_dbg_kms(mgr->dev, "Part 1 of payload creation for %s
failed,
Quoted 10 lines
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c static void intel_mst_enable_dp(struct
Quoted 10 lines
drivers/gpu/drm/display/drm_dp_mst_topology.c +1 -0
+skipping part 2\n",
                              payload->port->connector->name);
                  return -EIO;
          }
drivers/gpu/drm/i915/display/intel_dp_mst.c +0 -0
index 53aec023ce92..2fba66aec038 100644
@@ -1160,7 +1160,7 @@ static void intel_mst_enable_dp(struct
intel_atomic_state *state,
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c static void intel_mst_enable_dp(struct intel_atomic_state *state, · line 1165
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c +1 -1
          if (first_mst_stream)
                  intel_ddi_wait_for_fec_status(encoder, pipe_config, true);
 
- drm_dp_add_payload_part2(&intel_dp->mst_mgr, &state->base,
+ drm_dp_add_payload_part2(&intel_dp->mst_mgr,
 
drm_atomic_get_mst_payload_state(mst_state,
Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/nouveau/dispnv50/disp.c nv50_msto_cleanup(struct drm_atomic_state *state, · line 916
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_dp_mst.c +0 -0
 connector->port));
 
          if (DISPLAY_VER(dev_priv) >= 12)
drivers/gpu/drm/nouveau/dispnv50/disp.c +0 -0
index 0c3d88ad0b0e..88728a0b2c25 100644
@@ -915,7 +915,7 @@ nv50_msto_cleanup(struct drm_atomic_state *state,
                  msto->disabled = false;
                  drm_dp_remove_payload_part2(mgr, new_mst_state,
old_payload, new_payload);
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/nouveau/dispnv50/disp.c +1 -1
          } else if (msto->enabled) {
-         drm_dp_add_payload_part2(mgr, state, new_payload);
+         drm_dp_add_payload_part2(mgr, new_payload);
                  msto->enabled = false;
Quoted 8 lines
Quoted 8 lines
include/drm/display/drm_dp_mst_helper.h int drm_dp_add_payload_part1(struct
Quoted 8 lines
drivers/gpu/drm/nouveau/dispnv50/disp.c +0 -0
          }
  }
include/drm/display/drm_dp_mst_helper.h +0 -0
index 9b19d8bd520a..6c9145abc7e2 100644
@@ -851,7 +851,6 @@ int drm_dp_add_payload_part1(struct
drm_dp_mst_topology_mgr *mgr,
Quoted 12 lines
Quoted 6 lines
Quoted 6 lines
include/drm/display/drm_dp_mst_helper.h int drm_dp_add_payload_part1(struct drm_dp_mst_topology_mgr *mgr,
Quoted 6 lines
include/drm/display/drm_dp_mst_helper.h +0 -1
                               struct drm_dp_mst_topology_state *mst_state,
                               struct drm_dp_mst_atomic_payload *payload);
  int drm_dp_add_payload_part2(struct drm_dp_mst_topology_mgr *mgr,
-                      struct drm_atomic_state *state,
                               struct drm_dp_mst_atomic_payload *payload);
  void drm_dp_remove_payload_part1(struct drm_dp_mst_topology_mgr
*mgr,
Quoted 5 lines
Quoted 4 lines
Quoted 1 line
include/drm/display/drm_dp_mst_helper.h +0 -0
                                   struct drm_dp_mst_topology_state *mst_state,
---
Regards,
Wayne Lin

Signature · 1 line

Jani Nikula, Intel

Limonciello, Mario

2024-05-12 16:11 UTC #12 lore raw

Quoted 52 lines · Jani Nikula

Quoted 51 lines · Wayne
[Public]
Quoted 48 lines
-----Original Message-----
From: Limonciello, Mario <[email protected]>
Sent: Friday, May 10, 2024 3:18 AM
To: Linux regressions mailing list <[email protected]>; Wentland, Harry <[email protected]>; Lin, Wayne <[email protected]>
Cc: [email protected]; [email protected]; Leon Weiß <leon.weiss@ruhr-uni- bochum.de>; [email protected]; [email protected]; amd- [email protected]; [email protected]
Subject: Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
Quoted 25 lines · Linux regression tracking (Thorsten Leemhuis)
Quoted 24 lines · Harry Wentland
Quoted 22 lines · Wayne Lin
[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression.
[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().
Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload
allocation/removement")
Reported-by Leon Weiß <[email protected]>
Link:
https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.c
[email protected]/
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Wayne Lin <[email protected]>
Quoted 8 lines
Quoted 4 lines
I haven't been deep in MST code in a while but this all looks pretty straightforward and good.
Reviewed-by Harry Wentland <[email protected]>
Hmmm, that was three weeks ago, but it seems since then nothing happened to fix the linked regression through this or some other patch. Is there a reason? The build failure report from the CI maybe?
It touches files outside of amd but only has an ack from AMD. I think we /probably/ want an ack from i915 and nouveau to take it through.

Quoted 9 lines

Quoted 4 lines
Thanks, Mario!
Hi Thorsten,
Yeah, like what Mario said. Would also like to have ack from i915 and nouveau.
It usually works better if you Cc the folks you want an ack from! ;)
Acked-by Jani Nikula <[email protected]>

Thanks! Can someone with commit permissions take this to drm-misc?

Linux regression tracking (Thorsten Leemhuis)

2024-05-21 11:20 UTC #13 lore raw

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone.

Hmm, from here it looks like the patch now that it was reviewed more that a week ago is still not even in -next. Is there a reason?

I know, we are in the merge window. But at the same time this is a fix (that already lingered on the lists for way too long before it was reviewed) for a regression in a somewhat recent kernel, so it in Linus own words should be "expedited"[1].

Or are we again just missing a right person for the job in the CC? Adding Dave and Sima just in case.

Ciao, Thorsten

[1]
https://lore.kernel.org/all/CAHk-=wis_qQy4oDNynNKi5b7Qhosmxtoj1jxo5wmB6SRUwQUBQ@mail.gmail.com/

Quoted 70 lines · Mario

Quoted 56 lines · Jani Nikula
Quoted 55 lines · Wayne
Quoted 45 lines
-----Original Message-----
From: Limonciello, Mario <[email protected]>
Sent: Friday, May 10, 2024 3:18 AM
To: Linux regressions mailing list <[email protected]>; Wentland, Harry
<[email protected]>; Lin, Wayne <[email protected]>
Cc: [email protected]; [email protected]; Leon Weiß <leon.weiss@ruhr-uni-
bochum.de>; [email protected]; [email protected]; amd-
[email protected]; [email protected]
Subject: Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
Quoted 30 lines · Linux regression tracking (Thorsten Leemhuis)
Quoted 28 lines · Harry Wentland
Quoted 14 lines · Wayne Lin
[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression.
[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().
Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload
allocation/removement")
Reported-by Leon Weiß <[email protected]>
Quoted 8 lines
Link:
https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.c
[email protected]/
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Wayne Lin <[email protected]>
I haven't been deep in MST code in a while but this all looks pretty straightforward and good.
Reviewed-by Harry Wentland <[email protected]>
Quoted 7 lines
Quoted 3 lines
Hmmm, that was three weeks ago, but it seems since then nothing happened to fix the linked regression through this or some other patch. Is there a reason? The build failure report from the CI maybe?
It touches files outside of amd but only has an ack from AMD. I think we
/probably/ want an ack from i915 and nouveau to take it through.
Thanks, Mario!
Quoted 8 lines
Quoted 3 lines
Hi Thorsten,
Yeah, like what Mario said. Would also like to have ack from i915 and nouveau.
It usually works better if you Cc the folks you want an ack from! ;)
Acked-by Jani Nikula <[email protected]>
Thanks! Can someone with commit permissions take this to drm-misc?

Alex Deucher

2024-05-21 16:12 UTC #14 lore raw

I've got it teed up. Is drm-misc-fixes the right branch since we are in the merge window?

Alex

Quoted 91 lines · Linux regression tracking (Thorsten Leemhuis)

Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone.
Hmm, from here it looks like the patch now that it was reviewed more that a week ago is still not even in -next. Is there a reason?
I know, we are in the merge window. But at the same time this is a fix (that already lingered on the lists for way too long before it was reviewed) for a regression in a somewhat recent kernel, so it in Linus own words should be "expedited"[1].
Or are we again just missing a right person for the job in the CC? Adding Dave and Sima just in case.
Ciao, Thorsten
[1]
https://lore.kernel.org/all/CAHk-=wis_qQy4oDNynNKi5b7Qhosmxtoj1jxo5wmB6SRUwQUBQ@mail.gmail.com/
Quoted 70 lines · Mario
Quoted 56 lines · Jani Nikula
Quoted 55 lines · Wayne
Quoted 45 lines
-----Original Message-----
From: Limonciello, Mario <[email protected]>
Sent: Friday, May 10, 2024 3:18 AM
To: Linux regressions mailing list <[email protected]>; Wentland, Harry
<[email protected]>; Lin, Wayne <[email protected]>
Cc: [email protected]; [email protected]; Leon Weiß <leon.weiss@ruhr-uni-
bochum.de>; [email protected]; [email protected]; amd-
[email protected]; [email protected]
Subject: Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
Quoted 30 lines · Linux regression tracking (Thorsten Leemhuis)
Quoted 28 lines · Harry Wentland
Quoted 14 lines · Wayne Lin
[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression.
[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().
Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload
allocation/removement")
Reported-by Leon Weiß <[email protected]>
Quoted 8 lines
Link:
https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.c
[email protected]/
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Wayne Lin <[email protected]>
I haven't been deep in MST code in a while but this all looks pretty straightforward and good.
Reviewed-by Harry Wentland <[email protected]>
Quoted 7 lines
Quoted 3 lines
Hmmm, that was three weeks ago, but it seems since then nothing happened to fix the linked regression through this or some other patch. Is there a reason? The build failure report from the CI maybe?
It touches files outside of amd but only has an ack from AMD. I think we
/probably/ want an ack from i915 and nouveau to take it through.
Thanks, Mario!
Quoted 8 lines
Quoted 3 lines
Hi Thorsten,
Yeah, like what Mario said. Would also like to have ack from i915 and nouveau.
It usually works better if you Cc the folks you want an ack from! ;)
Acked-by Jani Nikula <[email protected]>
Thanks! Can someone with commit permissions take this to drm-misc?

Alex Deucher

2024-05-21 17:39 UTC #15 lore raw

Applied and pushed out:
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8a0a7b98d4b6eeeab337ec25daa4bc0a5e710a15

Alex

Quoted 99 lines · Alex Deucher

I've got it teed up. Is drm-misc-fixes the right branch since we are in the merge window?
Alex
Quoted 91 lines · Linux regression tracking (Thorsten Leemhuis)
Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone.
Hmm, from here it looks like the patch now that it was reviewed more that a week ago is still not even in -next. Is there a reason?
I know, we are in the merge window. But at the same time this is a fix (that already lingered on the lists for way too long before it was reviewed) for a regression in a somewhat recent kernel, so it in Linus own words should be "expedited"[1].
Or are we again just missing a right person for the job in the CC? Adding Dave and Sima just in case.
Ciao, Thorsten
[1]
https://lore.kernel.org/all/CAHk-=wis_qQy4oDNynNKi5b7Qhosmxtoj1jxo5wmB6SRUwQUBQ@mail.gmail.com/
Quoted 70 lines · Mario
Quoted 56 lines · Jani Nikula
Quoted 55 lines · Wayne
Quoted 45 lines
-----Original Message-----
From: Limonciello, Mario <[email protected]>
Sent: Friday, May 10, 2024 3:18 AM
To: Linux regressions mailing list <[email protected]>; Wentland, Harry
<[email protected]>; Lin, Wayne <[email protected]>
Cc: [email protected]; [email protected]; Leon Weiß <leon.weiss@ruhr-uni-
bochum.de>; [email protected]; [email protected]; amd-
[email protected]; [email protected]
Subject: Re: [PATCH] drm/mst: Fix NULL pointer dereference at drm_dp_add_payload_part2
Quoted 30 lines · Linux regression tracking (Thorsten Leemhuis)
Quoted 28 lines · Harry Wentland
Quoted 14 lines · Wayne Lin
[Why]
Commit:
- commit 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload allocation/removement") accidently overwrite the commit
- commit 54d217406afe ("drm: use mgr->dev in drm_dbg_kms in drm_dp_add_payload_part2") which cause regression.
[How]
Recover the original NULL fix and remove the unnecessary input parameter 'state' for drm_dp_add_payload_part2().
Fixes 5aa1dfcdf0a4 ("drm/mst: Refactor the flow for payload
allocation/removement")
Reported-by Leon Weiß <[email protected]>
Quoted 8 lines
Link:
https://lore.kernel.org/r/38c253ea42072cc825dc969ac4e6b9b600371cc8.c
[email protected]/
Cc [email protected]
Cc [email protected]
Cc [email protected]
Cc [email protected]
Signed-off-by Wayne Lin <[email protected]>
I haven't been deep in MST code in a while but this all looks pretty straightforward and good.
Reviewed-by Harry Wentland <[email protected]>
Quoted 7 lines
Quoted 3 lines
Hmmm, that was three weeks ago, but it seems since then nothing happened to fix the linked regression through this or some other patch. Is there a reason? The build failure report from the CI maybe?
It touches files outside of amd but only has an ack from AMD. I think we
/probably/ want an ack from i915 and nouveau to take it through.
Thanks, Mario!
Quoted 8 lines
Quoted 3 lines
Hi Thorsten,
Yeah, like what Mario said. Would also like to have ack from i915 and nouveau.
It usually works better if you Cc the folks you want an ack from! ;)
Acked-by Jani Nikula <[email protected]>
Thanks! Can someone with commit permissions take this to drm-misc?