nvmet-fc: remove unused functions nvmet_fc_iodnum and nvmet_fc_fodnum
Subsystems (4)
PATCH 1/1 nvmet-fc: remove unused functions nvmet_fc_iodnum and nvmet_fc_fodnum
The inlined helper functions nvmet_fc_iodnum and nvmet_fc_fodnum are not used and are redundant. They have been in the code since 2016 and never been referenced. Remove them.
Cleans up clang scan warnings such as:drivers/nvme/target/fc.c:177:1: warning: unused function 'nvmet_fc_iodnum' [-Wunused-function]
Signed-off-by Colin Ian King <[email protected]>
--- drivers/nvme/target/fc.c | 14 -------------- 1 file changed, 14 deletions(-)
drivers/nvme/target/fc.c +0 -14
@@ -172,20 +172,6 @@ struct nvmet_fc_tgt_assoc {struct work_struct del_work; }; - -static inline int -nvmet_fc_iodnum (struct nvmet_fc_ls_iod *iodptr) -{ -return (iodptr - iodptr->tgtport->iod); -} - -static inline int -nvmet_fc_fodnum (struct nvmet_fc_fcp_iod *fodptr) -{ -return (fodptr - fodptr->queue->fod); -} - -/* * Association and Connection IDs: *
Signature · 1 line
2.39.2
Reviewed-by Sagi Grimberg <[email protected]>
Quoted 10 lines · Colin Ian King
The inlined helper functions
nvmet_fc_iodnumandnvmet_fc_fodnumare not used and are redundant. They have been in the code since 2016 and never been referenced. Remove them.Cleans up clang scan warnings such as:
drivers/nvme/target/fc.c:177:1: warning: unused function 'nvmet_fc_iodnum' [-Wunused-function]Signed-off-by Colin Ian King <[email protected]>
Looks good.
Reviewed-by Chaitanya Kulkarni <[email protected]>
-ck