tls: fix race between tx work scheduling and socket close
PATCH 1/1 tls: fix race between tx work scheduling and socket close
From: Jakub Kicinski <[email protected]>
[ Upstream commit e01e3934a1b2d122919f73bc6ddbe1cdafc4bbdb ]
Similarly to previous commit, the submitting thread (recvmsg/sendmsg) may exit as soon as the async crypto handler calls complete(). Reorder scheduling the work before calling complete(). This seems more logical in the first place, as it's
the inverse order of what the submitting thread will do.
Reported-by valis <[email protected]>
Fixes a42055e8d2c3 ("net/tls: Add support for async encryption of records for performance")
Signed-off-by Jakub Kicinski <[email protected]>
Reviewed-by Simon Horman <[email protected]>
Reviewed-by Sabrina Dubroca <[email protected]>
Signed-off-by David S. Miller <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
(cherry picked from commit 6db22d6c7a6dc914b12c0469b94eb639b6a8a146)
[Lee: Fixed merge-conflict in Stable branches linux-6.1.y and older]
Signed-off-by Lee Jones <[email protected]>
--- net/tls/tls_sw.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-)
net/tls/tls_sw.c +6 -10
@@ -443,7 +443,6 @@ static void tls_encrypt_done(struct crypto_async_request *req, int err)struct scatterlist *sge;struct sk_msg *msg_en;struct tls_rec *rec; -bool ready = false;int pending; rec = container_of(aead_req, struct tls_rec, aead_req);
@@ -475,8 +474,12 @@ static void tls_encrypt_done(struct crypto_async_request *req, int err)/* If received record is at head of tx_list, schedule tx */ first_rec =list_first_entry (&ctx->tx_list, struct tls_rec, list); -if (rec == first_rec) - ready = true; +if (rec == first_rec) { +/* Schedule the transmission */ +if (!test_and_set_bit (BIT_TX_SCHEDULED , + &ctx->tx_bitmask)) +schedule_delayed_work (&ctx->tx_work.work,1 ); + } }spin_lock_bh (&ctx->encrypt_compl_lock);
@@ -485,13 +488,6 @@ static void tls_encrypt_done(struct crypto_async_request *req, int err)if (!pending && ctx->async_notify)complete (&ctx->async_wait.completion);spin_unlock_bh (&ctx->encrypt_compl_lock); - -if (!ready) -return ; - -/* Schedule the transmission */ -if (!test_and_set_bit (BIT_TX_SCHEDULED , &ctx->tx_bitmask)) -schedule_delayed_work (&ctx->tx_work.work,1 ); } static int tls_do_encryption(struct sock *sk,
Signature · 1 line
2.44.0.278.ge034bb2e1d-goog