Skip to contentSkip to conversation

nvme: change shutdown timeout setting message

PATCH In review Keith Busch 4 participants 4 messages Mar 7, 2024 – Mar 8, 2024 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme: change shutdown timeout setting message

From: Keith Busch <[email protected]>

User visible messages containing the word "timeout" can be alarming. This one nvme is just reporting a potentially informative device configuration, and everything is working as designed. Change the text to report the less concerning "D3 entry latency", which is where this value comes from anyway.

---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
index 2baf5786a92fe..0dcaf3973dc49 100644
@@ -3233,7 +3233,7 @@ static int nvme_init_identify(struct nvme_ctrl *ctrl)
 
 		if (ctrl->shutdown_timeout != shutdown_timeout)
 			dev_info(ctrl->device,
-				 "Shutdown timeout set to %u seconds\n",
+				 "D3 entry latency set to %u seconds\n",
 				 ctrl->shutdown_timeout);
 	} else
 		ctrl->shutdown_timeout = shutdown_timeout;
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Keith Busch

From: Keith Busch <[email protected]>

User visible messages containing the word "timeout" can be alarming. This one nvme is just reporting a potentially informative device configuration, and everything is working as designed. Change the text to report the less concerning "D3 entry latency", which is where this value comes from anyway.

---

Looks good.

-ck