kconfig: lxdialog: fix button color for blackbg theme
PATCH 1/2 kconfig: lxdialog: fix button color for blackbg theme
For MENUCONFIG_COLOR=blackbg, the text in inactive buttons is invisible because both the foreground and background are black.
Change the foreground color to white and remove the highlighting.
Signed-off-by Masahiro Yamada <[email protected]>
---
scripts/kconfig/lxdialog/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/kconfig/lxdialog/util.c +1 -1
@@ -101,7 +101,7 @@ static void set_blackbg_theme(void)DLG_COLOR (button_key_active,COLOR_YELLOW ,COLOR_RED , true);DLG_COLOR (button_key_inactive,COLOR_RED ,COLOR_BLACK , false);DLG_COLOR (button_label_active,COLOR_WHITE ,COLOR_RED , false); -DLG_COLOR (button_label_inactive,COLOR_BLACK ,COLOR_BLACK , true); +DLG_COLOR (button_label_inactive,COLOR_WHITE ,COLOR_BLACK , false);DLG_COLOR (inputbox,COLOR_YELLOW ,COLOR_BLACK , false);DLG_COLOR (inputbox_border,COLOR_YELLOW ,COLOR_BLACK , false);
Signature · 1 line
2.40.1
PATCH 2/2 kconfig: lxdialog: remove unused dialog colors
Remove inputbox_order, searchbox, searchbox_title, searchbox_border because they are initialized, but not used anywhere.
Signed-off-by Masahiro Yamada <[email protected]>
---
scripts/kconfig/lxdialog/dialog.h | 4 ---- scripts/kconfig/lxdialog/util.c | 18 ------------------ 2 files changed, 22 deletions(-)
scripts/kconfig/lxdialog/dialog.h +0 -4
@@ -91,10 +91,6 @@ struct dialog_info {struct dialog_color button_label_active;struct dialog_color button_label_inactive;struct dialog_color inputbox; -struct dialog_color inputbox_border; -struct dialog_color searchbox; -struct dialog_color searchbox_title; -struct dialog_color searchbox_border;struct dialog_color position_indicator;struct dialog_color menubox;struct dialog_color menubox_border;
scripts/kconfig/lxdialog/util.c +0 -18
@@ -29,10 +29,6 @@ static void set_mono_theme(void) dlg.button_label_active.atr =A_REVERSE ; dlg.button_label_inactive.atr =A_NORMAL ; dlg.inputbox.atr =A_NORMAL ; - dlg.inputbox_border.atr =A_NORMAL ; - dlg.searchbox.atr =A_NORMAL ; - dlg.searchbox_title.atr =A_BOLD ; - dlg.searchbox_border.atr =A_NORMAL ; dlg.position_indicator.atr =A_BOLD ; dlg.menubox.atr =A_NORMAL ; dlg.menubox_border.atr =A_NORMAL ;
@@ -69,10 +65,6 @@ static void set_classic_theme(void)DLG_COLOR (button_label_active,COLOR_YELLOW ,COLOR_BLUE , true);DLG_COLOR (button_label_inactive,COLOR_BLACK ,COLOR_WHITE , true);DLG_COLOR (inputbox,COLOR_BLACK ,COLOR_WHITE , false); -DLG_COLOR (inputbox_border,COLOR_BLACK ,COLOR_WHITE , false); -DLG_COLOR (searchbox,COLOR_BLACK ,COLOR_WHITE , false); -DLG_COLOR (searchbox_title,COLOR_YELLOW ,COLOR_WHITE , true); -DLG_COLOR (searchbox_border,COLOR_WHITE ,COLOR_WHITE , true);DLG_COLOR (position_indicator,COLOR_YELLOW ,COLOR_WHITE , true);DLG_COLOR (menubox,COLOR_BLACK ,COLOR_WHITE , false);DLG_COLOR (menubox_border,COLOR_WHITE ,COLOR_WHITE , true);
@@ -104,11 +96,6 @@ static void set_blackbg_theme(void)DLG_COLOR (button_label_inactive,COLOR_WHITE ,COLOR_BLACK , false);DLG_COLOR (inputbox,COLOR_YELLOW ,COLOR_BLACK , false); -DLG_COLOR (inputbox_border,COLOR_YELLOW ,COLOR_BLACK , false); - -DLG_COLOR (searchbox,COLOR_YELLOW ,COLOR_BLACK , false); -DLG_COLOR (searchbox_title,COLOR_YELLOW ,COLOR_BLACK , true); -DLG_COLOR (searchbox_border,COLOR_BLACK ,COLOR_BLACK , true);DLG_COLOR (position_indicator,COLOR_RED ,COLOR_BLACK , false);
@@ -136,7 +123,6 @@ static void set_bluetitle_theme(void)DLG_COLOR (title,COLOR_BLUE ,COLOR_WHITE , true);DLG_COLOR (button_key_active,COLOR_YELLOW ,COLOR_BLUE , true);DLG_COLOR (button_label_active,COLOR_WHITE ,COLOR_BLUE , true); -DLG_COLOR (searchbox_title,COLOR_BLUE ,COLOR_WHITE , true);DLG_COLOR (position_indicator,COLOR_BLUE ,COLOR_WHITE , true);DLG_COLOR (tag,COLOR_BLUE ,COLOR_WHITE , true);DLG_COLOR (tag_key,COLOR_BLUE ,COLOR_WHITE , true);
@@ -189,10 +175,6 @@ static void init_dialog_colors(void)init_one_color (&dlg.button_label_active);init_one_color (&dlg.button_label_inactive);init_one_color (&dlg.inputbox); -init_one_color (&dlg.inputbox_border); -init_one_color (&dlg.searchbox); -init_one_color (&dlg.searchbox_title); -init_one_color (&dlg.searchbox_border);init_one_color (&dlg.position_indicator);init_one_color (&dlg.menubox);init_one_color (&dlg.menubox_border);
Signature · 1 line
2.40.1