usb: typec: tcpm: Correct port source pdo array in pd_set callback
Subsystems (4)
PATCH 1/1 usb: typec: tcpm: Correct port source pdo array in pd_set callback
In tcpm_pd_set, the array of port source capabilities is port->src_pdo, not port->snk_pdo.
Fixes cd099cde4ed2 ("usb: typec: tcpm: Support multiple capabilities")
Signed-off-by Kyle Tso <[email protected]>
--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/typec/tcpm/tcpm.c +1 -1
@@ -6858,7 +6858,7 @@ static int tcpm_pd_set(struct typec_port *p, struct usb_power_delivery *pd)if (data->source_desc.pdo[0 ]) {for (i =0 ; i <PDO_MAX_OBJECTS && data->source_desc.pdo[i]; i++) - port->snk_pdo[i] = data->source_desc.pdo[i]; + port->src_pdo[i] = data->source_desc.pdo[i]; port->nr_src_pdo = i +1 ; }
Signature · 1 line
2.44.0.278.ge034bb2e1d-goog
Quoted 6 lines · Kyle Tso
In
tcpm_pd_set, the array of port source capabilities isport->src_pdo, notport->snk_pdo.Fixes cd099cde4ed2 ("usb: typec: tcpm: Support multiple capabilities")Signed-off-by Kyle Tso <[email protected]>
Acked-by Heikki Krogerus <[email protected]>
Quoted 19 lines
--- drivers/usb/typec/tcpm/tcpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/usb/typec/tcpm/tcpm.c +1
-1@@ -6858,7 +6858,7 @@ static int tcpm_pd_set(struct typec_port *p, struct usb_power_delivery *pd)if (data->source_desc.pdo[0 ]) {for (i =0 ; i <PDO_MAX_OBJECTS && data->source_desc.pdo[i]; i++) - port->snk_pdo[i] = data->source_desc.pdo[i]; + port->src_pdo[i] = data->source_desc.pdo[i]; port->nr_src_pdo = i +1 ; }Signature · 1 line
2.44.0.278.ge034bb2e1d-goog
Signature · 1 line
heikki