Skip to contentSkip to conversation

usb: typec: tcpm: Update PD of Type-C port upon pd_set

PATCH In review Kyle Tso 2 participants 2 messages Mar 11, 2024 – Mar 12, 2024

Subsystems (4)
lore
Share & tools
lore

Kyle Tso

author
#0 lore raw

PATCH 1/1 usb: typec: tcpm: Update PD of Type-C port upon pd_set

The PD of Type-C port needs to be updated in pd_set. Unlink the Type-C port device to the old PD before linking it to a new one.

Fixes cd099cde4ed2 ("usb: typec: tcpm: Support multiple capabilities")
---
 drivers/usb/typec/tcpm/tcpm.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/typec/tcpm/tcpm.c +2 -0
index 3d505614bff1..896f594b9328 100644
@@ -6907,7 +6907,9 @@ static int tcpm_pd_set(struct typec_port *p, struct usb_power_delivery *pd)
 
 	port->port_source_caps = data->source_cap;
 	port->port_sink_caps = data->sink_cap;
+	typec_port_set_usb_power_delivery(p, NULL);
 	port->selected_pd = pd;
+	typec_port_set_usb_power_delivery(p, port->selected_pd);
 unlock:
 	mutex_unlock(&port->lock);
 	return ret;
Signature · 1 line
2.44.0.278.ge034bb2e1d-goog
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Kyle Tso

The PD of Type-C port needs to be updated in pd_set. Unlink the Type-C port device to the old PD before linking it to a new one.

Fixes cd099cde4ed2 ("usb: typec: tcpm: Support multiple capabilities")
Quoted 20 lines
---
 drivers/usb/typec/tcpm/tcpm.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/usb/typec/tcpm/tcpm.c +2 -0
index 3d505614bff1..896f594b9328 100644
@@ -6907,7 +6907,9 @@ static int tcpm_pd_set(struct typec_port *p, struct usb_power_delivery *pd)
 
 	port->port_source_caps = data->source_cap;
 	port->port_sink_caps = data->sink_cap;
+	typec_port_set_usb_power_delivery(p, NULL);
 	port->selected_pd = pd;
+	typec_port_set_usb_power_delivery(p, port->selected_pd);
 unlock:
 	mutex_unlock(&port->lock);
 	return ret;
Signature · 1 line
2.44.0.278.ge034bb2e1d-goog
Signature · 1 line
heikki