Skip to contentSkip to conversation

Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

PATCH Superseded Jiawei Wang 5 participants 22 messages Mar 12, 2024 – Mar 29, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

Please revert my previous two commits:

ASoC: amd: yc: add new YC platform variant (0x63) support [ Upstream commit 316a784839b21b122e1761cdca54677bb19a47fa ]

ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2 [ Upstream commit ed00a6945dc32462c2d3744a3518d2316da66fcc ]

PCI revision id 0x63 is the Pink Sardine (PS) platform, not Yellow Carp (YC). Thanks to Mukunda Vijendar [1] for pointing out that.

The mic on Lenovo 21J2 works after enabling the CONFIG_SND_SOC_AMD_PS flag, which I had not enabled when I was writing these patches. 21J2 does not need to be in this quirk table.

I apologize for the inconvenience caused.

Jiawei Wang (2):
Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2" Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 sound/soc/amd/yc/pci-acp6x.c  | 1 -
 2 files changed, 8 deletions(-)
Signature · 1 line
2.39.2
#1 lore raw

PATCH 1/2 Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2"

This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc.

Lenovo 21J2 uses the Pink Sardine (PS) platform, not Yellow Carp (YC). Thanks to Mukunda Vijendar [1] for pointing this out.

Lenovo 21J2 should not be in YC's quirk table.

---
 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 1 file changed, 7 deletions(-)
sound/soc/amd/yc/acp6x-mach.c +0 -7
index 90360f8b3e81..1d1452c29ed0 100644
@@ -199,13 +199,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
 		}
 	},
-	{
-		.driver_data = &acp6x_card,
-		.matches = {
-			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "21J2"),
-		}
-	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
Signature · 1 line
2.39.2
maintainer
#2 lore raw

Re: [PATCH 1/2] Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2"

Quoted 1 line · Jiawei Wang

This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc.

Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.

Quoted 4 lines

Lenovo 21J2 uses the Pink Sardine (PS) platform, not Yellow Carp (YC). Thanks to Mukunda Vijendar [1] for pointing this out.

Lenovo 21J2 should not be in YC's quirk table.

This doesn't apply against current code, please check and resend - there was another quirk went in yesterday which might also need to be reverted.

#3 lore raw

v2 cover ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

I would like to revert two of my previous commits after realizing they incorrectly enabled the Yellow Carp (YC) driver for Pink Sardine (PS) platforms.

The first commit was reverted because it added a quirk entry that incorrectly enabled the YC driver for the Lenovo 21J2 laptop, which is a PS platform.

The second commit was reverted because it incorrectly enabled the YC driver for PS platforms.

Thanks to Mukunda Vijendar [1] for pointing this out.

Quoted 5 lines · Mark Brown

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.

The patches' subject lines have been changed to
ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

Quoted 8 lines · Mark Brown
Quoted 1 line

This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc.

Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.

I have added descriptions around commit hashes in the updated patch set, copied below for convenience:
1. This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc, which added a quirk entry to enable the Yellow Carp (YC) driver for the Lenovo 21J2 laptop.
2. This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa, that enabled Yellow Carp (YC) driver for PCI revision id 0x63.

Quoted 3 lines

This doesn't apply against current code, please check and resend - there was another quirk went in yesterday which might also need to be reverted.

I have updated the explanation for the first patch for why the quirk entry for Lenovo 21J2 should be removed. Please find my updated explanation in [PATCH v2 1/2].

Thanks for the review.

Jiawei Wang (2):
ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 sound/soc/amd/yc/pci-acp6x.c  | 1 -
 2 files changed, 8 deletions(-)
Signature · 1 line
2.39.2
#4 lore raw

PATCH v2 1/2 ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc, which added a quirk entry to enable the Yellow Carp (YC) driver for the Lenovo 21J2 laptop.

Although the microphone functioned with the YC driver, it resulted in incorrect driver usage. The Lenovo 21J2 is not a Yellow Carp platform, but a Pink Sardine platform, which already has an upstreamed driver.

The microphone on the Lenovo 21J2 operates correctly with the CONFIG_SND_SOC_AMD_PS flag enabled and does not require the quirk entry. So this patch removes the quirk entry.

Thanks to Mukunda Vijendar [1] for pointing this out.

---
 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 1 file changed, 7 deletions(-)
sound/soc/amd/yc/acp6x-mach.c +0 -7
index 90360f8b3e81..1d1452c29ed0 100644
@@ -199,13 +199,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
 		}
 	},
-	{
-		.driver_data = &acp6x_card,
-		.matches = {
-			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "21J2"),
-		}
-	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
Signature · 1 line
2.39.2
maintainer
#5 lore raw

Re: [PATCH v2 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

Quoted 3 lines · Jiawei Wang

This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc, which added a quirk entry to enable the Yellow Carp (YC) driver for the Lenovo 21J2 laptop.

This still doesn't apply against my for-6.9 branch.

#6 lore raw

v3 cover ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

I would like to revert two of my previous commits after realizing they incorrectly enabled the Yellow Carp (YC) driver for Pink Sardine (PS) platforms.

The first commit was reverted because it added a quirk entry that incorrectly enabled the YC driver for the Lenovo 21J2 laptop, which is a PS platform.

The second commit was reverted because it incorrectly enabled the YC driver for PS platforms.

Thanks to Mukunda Vijendar [1] for pointing this out.

v3 -> v2:
- No changes to content.
- Patches re-prepared using the broonie/sound.git tree's for-next branch. v2 -> v1:
- No changes to content. Subject lines and commit messages were revised.

Quoted 1 line · Mark Brown

This still doesn't apply against my for-6.9 branch.

I've updated the patch using your "for-next" tree.

However, it can't be applied to the "for-6.9" branch, because the commits to be reverted are not present in "for-6.9". Below are their hashes:
ed00a69 ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2 316a784 ASoC: amd: yc: add new YC platform variant (0x63) support

Quoted 6 lines · Mukunda,Vijendar

You can prepare patch by cloning below git tree for-next branch.

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

while sending patches, please use --cc-cmd=./scripts/get_maintainer.pl along with cc list.

Thank you for your guidance. I have updated the patch using the "for-next" tree as suggested. Additionally, I've incorporated the cc-cmd as per your instructions.

Jiawei Wang (2):
ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 sound/soc/amd/yc/pci-acp6x.c  | 1 -
 2 files changed, 8 deletions(-)
Signature · 1 line
2.39.2
#7 lore raw

PATCH v3 1/2 ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc, which added a quirk entry to enable the Yellow Carp (YC) driver for the Lenovo 21J2 laptop.

Although the microphone functioned with the YC driver, it resulted in incorrect driver usage. The Lenovo 21J2 is not a Yellow Carp platform, but a Pink Sardine platform, which already has an upstreamed driver.

The microphone on the Lenovo 21J2 operates correctly with the CONFIG_SND_SOC_AMD_PS flag enabled and does not require the quirk entry. So this patch removes the quirk entry.

Thanks to Mukunda Vijendar [1] for pointing this out.

---
 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 1 file changed, 7 deletions(-)
sound/soc/amd/yc/acp6x-mach.c +0 -7
index 1ab69a53174e..69c68d8e7a6b 100644
@@ -199,13 +199,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
 		}
 	},
-	{
-		.driver_data = &acp6x_card,
-		.matches = {
-			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "21J2"),
-		}
-	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
Signature · 1 line
2.39.2
#8 lore raw

PATCH v3 2/2 ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

In reply to Jiawei Wang

This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa, that enabled Yellow Carp (YC) driver for PCI revision id 0x63.

Mukunda Vijendar [1] points out that revision 0x63 is Pink Sardine platform, not Yellow Carp. The YC driver should not be enabled for this platform. This patch prevents the YC driver from being incorrectly enabled.

---
 sound/soc/amd/yc/pci-acp6x.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/amd/yc/pci-acp6x.c +0 -1
index 694b8e313902..7af6a349b1d4 100644
@@ -162,7 +162,6 @@ static int snd_acp6x_probe(struct pci_dev *pci,
 	/* Yellow Carp device check */
 	switch (pci->revision) {
 	case 0x60:
-	case 0x63:
 	case 0x6f:
 		break;
 	default:
Signature · 1 line
2.39.2
maintainer
#9 lore raw

Re: [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

In reply to Jiawei Wang
Quoted 34 lines · Jiawei Wang

I would like to revert two of my previous commits after realizing they incorrectly enabled the Yellow Carp (YC) driver for Pink Sardine (PS) platforms.

The first commit was reverted because it added a quirk entry that incorrectly enabled the YC driver for the Lenovo 21J2 laptop, which is a PS platform.

The second commit was reverted because it incorrectly enabled the YC driver for PS platforms.

Thanks to Mukunda Vijendar [1] for pointing this out.

v3 -> v2:
- No changes to content.
- Patches re-prepared using the broonie/sound.git tree's for-next branch. v2 -> v1:
- No changes to content. Subject lines and commit messages were revised.

Quoted 1 line · Mark Brown

This still doesn't apply against my for-6.9 branch.

I've updated the patch using your "for-next" tree.

However, it can't be applied to the "for-6.9" branch, because the commits to be reverted are not present in "for-6.9". Below are their hashes:
ed00a69 ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2 316a784 ASoC: amd: yc: add new YC platform variant (0x63) support

Quoted 2 lines · Mukunda,Vijendar

You can prepare patch by cloning below git tree for-next branch.

Quoted 7 lines
Quoted 4 lines

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

while sending patches, please use --cc-cmd=./scripts/get_maintainer.pl along with cc list.

Thank you for your guidance. I have updated the patch using the "for-next" tree as suggested. Additionally, I've incorporated the cc-cmd as per your instructions.

Hi Mark,

Could you please apply this patch series? Without these changes, functionality is broken for Pink Sardine (PS) platform.

Quoted 9 lines

Jiawei Wang (2):
ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 sound/soc/amd/yc/pci-acp6x.c  | 1 -
 2 files changed, 8 deletions(-)
maintainer
#10 lore raw

Re: [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

Quoted 2 lines · Mukunda,Vijendar

Could you please apply this patch series? Without these changes, functionality is broken for Pink Sardine (PS) platform.

Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. If there have been review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at all) which is often the problem and since they can't be reviewed directly if something has gone wrong you'll have to resend the patches anyway, so sending again is generally a better approach though there are some other maintainers who like them - if in doubt look at how patches for the subsystem are normally handled.

maintainer
#11 lore raw

Re: [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

In reply to Jiawei Wang
Quoted 9 lines · Jiawei Wang

I would like to revert two of my previous commits after realizing they incorrectly enabled the Yellow Carp (YC) driver for Pink Sardine (PS) platforms.

The first commit was reverted because it added a quirk entry that incorrectly enabled the YC driver for the Lenovo 21J2 laptop, which is a PS platform.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

      commit: 861b3415e4dee06cc00cd1754808a7827b9105bf
[2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
      commit: 37bee1855d0e3b6dbeb8de71895f6f68cad137be

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

#12 lore raw

PATCH v2 2/2 ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"

In reply to Jiawei Wang

This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa, that enabled Yellow Carp (YC) driver for PCI revision id 0x63.

Mukunda Vijendar [1] points out that revision 0x63 is Pink Sardine platform, not Yellow Carp. The YC driver should not be enabled for this platform. This patch prevents the YC driver from being incorrectly enabled.

---
 sound/soc/amd/yc/pci-acp6x.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/amd/yc/pci-acp6x.c +0 -1
index 694b8e313902..7af6a349b1d4 100644
@@ -162,7 +162,6 @@ static int snd_acp6x_probe(struct pci_dev *pci,
 	/* Yellow Carp device check */
 	switch (pci->revision) {
 	case 0x60:
-	case 0x63:
 	case 0x6f:
 		break;
 	default:
Signature · 1 line
2.39.2
maintainer
#13 lore raw

Re: [PATCH v2 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support"

In reply to Jiawei Wang
Quoted 9 lines · Jiawei Wang

I would like to revert two of my previous commits after realizing they incorrectly enabled the Yellow Carp (YC) driver for Pink Sardine (PS) platforms.

The first commit was reverted because it added a quirk entry that incorrectly enabled the YC driver for the Lenovo 21J2 laptop, which is a PS platform.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

      commit: 861b3415e4dee06cc00cd1754808a7827b9105bf
[2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
      commit: 37bee1855d0e3b6dbeb8de71895f6f68cad137be

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

#14 lore raw

PATCH 2/2 Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

In reply to Jiawei Wang

This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa.

PCI revision id 0x63 is the Pink Sardine (PS) platform, not Yellow Carp (YC). Thanks to Mukunda Vijendar [1] for pointing out that.

---
 sound/soc/amd/yc/pci-acp6x.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/amd/yc/pci-acp6x.c +0 -1
index 694b8e313902..7af6a349b1d4 100644
@@ -162,7 +162,6 @@ static int snd_acp6x_probe(struct pci_dev *pci,
 	/* Yellow Carp device check */
 	switch (pci->revision) {
 	case 0x60:
-	case 0x63:
 	case 0x6f:
 		break;
 	default:
Signature · 1 line
2.39.2
maintainer
#15 lore raw
In reply to Jiawei Wang
Quoted 7 lines · Jiawei Wang

Please revert my previous two commits:

ASoC: amd: yc: add new YC platform variant (0x63) support [ Upstream commit 316a784839b21b122e1761cdca54677bb19a47fa ]

ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2 [ Upstream commit ed00a6945dc32462c2d3744a3518d2316da66fcc ]

Please submit patches using subject lines reflecting the style for the subsystem, this makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing. There's no need to resubmit to fix this alone.

#16 lore raw
In reply to Jiawei Wang

Hello everyone,

Can those changes be pulled in stable? They're currently breaking mic input on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the wild.

Thanks, Luca.

Quoted 29 lines · Jiawei Wang

Please revert my previous two commits:

ASoC: amd: yc: add new YC platform variant (0x63) support [ Upstream commit 316a784839b21b122e1761cdca54677bb19a47fa ]

ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2 [ Upstream commit ed00a6945dc32462c2d3744a3518d2316da66fcc ]

PCI revision id 0x63 is the Pink Sardine (PS) platform, not Yellow Carp (YC). Thanks to Mukunda Vijendar [1] for pointing out that.

The mic on Lenovo 21J2 works after enabling the CONFIG_SND_SOC_AMD_PS flag, which I had not enabled when I was writing these patches. 21J2 does not need to be in this quirk table.

I apologize for the inconvenience caused.

Jiawei Wang (2):
Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2" Revert "ASoC: amd: yc: add new YC platform variant (0x63) support"

  sound/soc/amd/yc/acp6x-mach.c | 7 -------
  sound/soc/amd/yc/pci-acp6x.c  | 1 -
  2 files changed, 8 deletions(-)
maintainer
#17 lore raw
Quoted 5 lines · Luca Stefani

Hello everyone,

Can those changes be pulled in stable? They're currently breaking mic input on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the wild.

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

maintainer
#18 lore raw
Quoted 7 lines · Greg KH
Quoted 5 lines · Luca Stefani

Hello everyone,

Can those changes be pulled in stable? They're currently breaking mic input on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the wild.

Quoted 8 lines

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

These patches already got merged in V6.9-rc1 release. Need to be cherry-picked for stable release.

maintainer
#19 lore raw
Quoted 10 lines · Mukunda,Vijendar
Quoted 9 lines · Greg KH
Quoted 5 lines · Luca Stefani

Hello everyone,

Can those changes be pulled in stable? They're currently breaking mic input on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the wild.

<formletter>

Quoted 9 lines
Quoted 6 lines

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

These patches already got merged in V6.9-rc1 release. Need to be cherry-picked for stable release.

What changes exactly? I do not see any git ids here.

confused,

greg k-h

maintainer
#20 lore raw
Quoted 16 lines · Greg KH
Quoted 15 lines · Mukunda,Vijendar
Quoted 14 lines · Greg KH
Quoted 5 lines · Luca Stefani

Hello everyone,

Can those changes be pulled in stable? They're currently breaking mic input on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the wild.

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Quoted 8 lines
Quoted 3 lines

These patches already got merged in V6.9-rc1 release. Need to be cherry-picked for stable release.

What changes exactly? I do not see any git ids here.

confused,

greg k-h

Below are the commits.

37bee1855d0e ASoC: amd: yc: Revert "add new YC platform variant (0x63) support" 861b3415e4de ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

maintainer
#21 lore raw
Quoted 22 lines · Mukunda,Vijendar
Quoted 21 lines · Greg KH
Quoted 9 lines · Mukunda,Vijendar
Quoted 8 lines · Greg KH
Quoted 5 lines · Luca Stefani

Hello everyone,

Can those changes be pulled in stable? They're currently breaking mic input on my 21K9CTO1WW, ThinkPad P16s Gen 2, and probably more devices in the wild.

<formletter>

Quoted 9 lines
Quoted 6 lines

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

These patches already got merged in V6.9-rc1 release. Need to be cherry-picked for stable release.

What changes exactly? I do not see any git ids here.

Quoted 11 lines
Quoted 3 lines

confused,

greg k-h

Below are the commits.

37bee1855d0e ASoC: amd: yc: Revert "add new YC platform variant (0x63) support" 861b3415e4de ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"

Already asked for here:

	https://lore.kernel.org/r/[email protected]