Skip to contentSkip to conversation

iwmon: fix incorrect mask printing HE capabilities

PATCH Applied James Prestwood 2 participants 2 messages Mar 15, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iwmon: fix incorrect mask printing HE capabilities

This was changed from too large of a mask (0xff) in an earlier commit but was masking 5 bits instead of 6.

Fixes 121c2c5653 ("monitor: properly mask HE capabilities bitfield")
---
 monitor/nlmon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
monitor/nlmon.c +1 -1
index 6fe63b8d..9fee5bde 100644
@@ -1689,7 +1689,7 @@ static void print_ie_he_capabilities(unsigned int level,
 {
 	const uint8_t *ptr = data;
 	uint8_t width_set = bit_field((ptr + 6)[0], 1, 7);
-	uint8_t mask = 0x1f;
+	uint8_t mask = 0x3f;
 
 	const char *he_channel_width_bitfield[] = {
 		[0] = "40MHz supported (2.4GHz)",
Signature · 1 line
2.34.1
#1 lore raw

Hi James,

Quoted 8 lines · James Prestwood

This was changed from too large of a mask (0xff) in an earlier commit but was masking 5 bits instead of 6.

Fixes 121c2c5653 ("monitor: properly mask HE capabilities bitfield")
---
  monitor/nlmon.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Regards,
-Denis