Skip to contentSkip to conversation

usb: typec: Return size of buffer if pd_set operation succeeds

PATCH In review Kyle Tso 3 participants 3 messages Mar 19, 2024 – Mar 22, 2024

Subsystems (3)
lore
Share & tools
lore

Kyle Tso

author
#0 lore raw

PATCH 1/1 usb: typec: Return size of buffer if pd_set operation succeeds

The attribute writing should return the number of bytes used from the buffer on success.

Fixes a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
---
 drivers/usb/typec/class.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/usb/typec/class.c +6 -1
index 389c7f0b8d93..9610e647a8d4 100644
@@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
 {
 	struct typec_port *port = to_typec_port(dev);
 	struct usb_power_delivery *pd;
+	int ret;
 
 	if (!port->ops || !port->ops->pd_set)
 		return -EOPNOTSUPP;
@@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
 	if (!pd)
 		return -EINVAL;
 
-	return port->ops->pd_set(port, pd);
+	ret = port->ops->pd_set(port, pd);
+	if (ret)
+		return ret;
+
+	return size;
 }
 
 static ssize_t select_usb_power_delivery_show(struct device *dev,
Signature · 1 line
2.44.0.291.gc1ea87d7ee-goog
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Kyle Tso

The attribute writing should return the number of bytes used from the buffer on success.

Fixes a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
Quoted 29 lines
---
  drivers/usb/typec/class.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)
drivers/usb/typec/class.c +6 -1
index 389c7f0b8d93..9610e647a8d4 100644
@@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
  {
  	struct typec_port *port = to_typec_port(dev);
  	struct usb_power_delivery *pd;
+	int ret;
 
  	if (!port->ops || !port->ops->pd_set)
  		return -EOPNOTSUPP;
@@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
  	if (!pd)
  		return -EINVAL;
 
-	return port->ops->pd_set(port, pd);
+	ret = port->ops->pd_set(port, pd);
+	if (ret)
+		return ret;
+
+	return size;
  }
 
  static ssize_t select_usb_power_delivery_show(struct device *dev,
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Kyle Tso
Quoted 6 lines · Kyle Tso

The attribute writing should return the number of bytes used from the buffer on success.

Fixes a7cff92f0635 ("usb: typec: USB Power Delivery helpers for ports and partners")
Quoted 31 lines
---
 drivers/usb/typec/class.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/usb/typec/class.c +6 -1
index 389c7f0b8d93..9610e647a8d4 100644
@@ -1310,6 +1310,7 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
 {
 	struct typec_port *port = to_typec_port(dev);
 	struct usb_power_delivery *pd;
+	int ret;
 
 	if (!port->ops || !port->ops->pd_set)
 		return -EOPNOTSUPP;
@@ -1318,7 +1319,11 @@ static ssize_t select_usb_power_delivery_store(struct device *dev,
 	if (!pd)
 		return -EINVAL;
 
-	return port->ops->pd_set(port, pd);
+	ret = port->ops->pd_set(port, pd);
+	if (ret)
+		return ret;
+
+	return size;
 }
 
 static ssize_t select_usb_power_delivery_show(struct device *dev,
Signature · 1 line
2.44.0.291.gc1ea87d7ee-goog
Signature · 1 line
heikki