Skip to contentSkip to conversation

] toolchain-shar-relocate.sh: Add check for missing command 'file'

PATCH Superseded Tom Hochstein 1 participant 1 message Mar 21, 2024

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ] toolchain-shar-relocate.sh: Add check for missing command 'file'

On a machine without the file command, the SDK install fails with a cryptic error message.

```
xargs: file: No such file or directory
sed: no input files
Failed to replace perl. Relocate script failed. Abort!
```

Add a test for 'file' to print a clear error message.

```
The command 'file' is required by the relocation script, please install it first. Abort!
```
---
 meta/files/toolchain-shar-relocate.sh | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
meta/files/toolchain-shar-relocate.sh +6 -4
index e8ab357717..b017714df0 100644
@@ -1,7 +1,9 @@
-if ! xargs --version > /dev/null 2>&1; then
-	echo "xargs is required by the relocation script, please install it first. Abort!"
-	exit 1
-fi
+for cmd in xargs file; do
+	if ! command -v $cmd > /dev/null 2>&1; then
+		echo "The command '$cmd' is required by the relocation script, please install it first. Abort!"
+		exit 1
+	fi
+done
 
 # fix dynamic loader paths in all ELF SDK binaries
 # allow symlinks to be accessed via the find command too
Signature · 1 line
2.25.1