dmaengine: owl: fix register access functions
Subsystems (2)
PATCH 1/1 dmaengine: owl: fix register access functions
From: Arnd Bergmann <[email protected]>
When building with 'make W=1', clang notices that the computed register values are never actually written back but instead the wrong variable is set:
drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
244 | u32 regval;
| ^drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
268 | u32 regval;
| ^
Change these to what was most likely intended.
--- drivers/dma/owl-dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/dma/owl-dma.c +2 -2
@@ -250,7 +250,7 @@ static void pchan_update(struct owl_dma_pchan *pchan, u32 reg,else regval &= ~val; -writel (val, pchan->base + reg); +writel (regval, pchan->base + reg); }static void pchan_writel (struct owl_dma_pchan *pchan,u32 reg,u32 data)
@@ -274,7 +274,7 @@ static void dma_update(struct owl_dma *od, u32 reg, u32 val, bool state)else regval &= ~val; -writel (val, od->base + reg); +writel (regval, od->base + reg); }static void dma_writel (struct owl_dma *od,u32 reg,u32 data)
Signature · 1 line
2.39.2
Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnd" == Arnd Bergmann <[email protected]> writes:
From: Arnd Bergmann <[email protected]>
When building with 'make W=1', clang notices that the computed register values are never actually written back but instead the wrong variable is set:
drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
244 | u32 regval;
| ^drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
268 | u32 regval;
| ^
Quoted 4 lines
Change these to what was most likely intended.
Fixes 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")Signed-off-by Arnd Bergmann <[email protected]>
Good catch!
Signature · 1 line
Bye, Peter Korsgaard
Quoted 6 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When building with 'make W=1', clang notices that the computed register values are never actually written back but instead the wrong variable is set:
Quoted 9 lines
drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
244 | u32 regval;
| ^drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
268 | u32 regval;
| ^Change these to what was most likely intended.
Wow... Thanks for spotting. Well thanks to Clang also ;)
Quoted 2 lines
Fixes 47e20577c24d ("dmaengine: Add Actions Semi Owl family S900 DMA driver")Signed-off-by Arnd Bergmann <[email protected]>
- Mani
Quoted 29 lines
--- drivers/dma/owl-dma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/dma/owl-dma.c +2
-2@@ -250,7 +250,7 @@ static void pchan_update(struct owl_dma_pchan *pchan, u32 reg,else regval &= ~val; -writel (val, pchan->base + reg); +writel (regval, pchan->base + reg); }static void pchan_writel (struct owl_dma_pchan *pchan,u32 reg,u32 data)@@ -274,7 +274,7 @@ static void dma_update(struct owl_dma *od, u32 reg, u32 val, bool state)else regval &= ~val; -writel (val, od->base + reg); +writel (regval, od->base + reg); }static void dma_writel (struct owl_dma *od,u32 reg,u32 data)Signature · 1 line
2.39.2
Signature · 1 line
மணிவண்ணன் சதாசிவம்
Quoted 4 lines · Arnd Bergmann
When building with 'make W=1', clang notices that the computed register values are never actually written back but instead the wrong variable is set:
Quoted 8 lines
drivers/dma/owl-dma.c:244:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
244 | u32 regval;
| ^drivers/dma/owl-dma.c:268:6: error: variable 'regval' set but not used [-Werror,-Wunused-but-set-variable]
268 | u32 regval;
| ^[...]
Applied, thanks!
[1/1] dmaengine: owl: fix register access functions
commit: 43c633ef93a5d293c96ebcedb40130df13128428
Best regards,
Signature · 1 line
~Vinod