Skip to contentSkip to conversation

arm64: dts: rockchip: enable gpu on rk3588-jaguar

PATCH Applied Heiko Stuebner 3 participants 7 messages Mar 27, 2024

Subsystems (2)
lore
Share & tools
lore

Heiko Stuebner

author maintainer
#0 lore raw

PATCH 1/2 arm64: dts: rockchip: enable gpu on rk3588-jaguar

From: Heiko Stuebner <[email protected]>

Enable the mali gpu node and add the board-specific supply-regulator.

---
 arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts +5 -0
index b564c7494878..d422bab41b82 100644
@@ -253,6 +253,11 @@ mdot2e-w-disable2-n-hog {
 	};
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu_s0>;
+	status = "okay";
+};
+
 &i2c0 {
 	pinctrl-0 = <&i2c0m2_xfer>;
 	status = "okay";
Signature · 7 lines
2.39.2


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
author maintainer
#1 lore raw

PATCH 2/2 arm64: dts: rockchip: enable gpu on rk3588-tiger

From: Heiko Stuebner <[email protected]>

Enable the mali gpu node and add the som-specific supply-regulator.

---
 arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi +5 -0
index 6417c24f2e8e..78f5bbddabba 100644
@@ -155,6 +155,11 @@ &eth0_pins
 	snps,reset-delays-us = <0 10000 100000>;
 };
 
+&gpu {
+	mali-supply = <&vdd_gpu_s0>;
+	status = "okay";
+};
+
 &i2c1 {
 	pinctrl-0 = <&i2c1m0_xfer>;
 };
Signature · 7 lines
2.39.2


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger

Hi Heiko,

Quoted 5 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

Enable the mali gpu node and add the som-specific supply-regulator.

Thanks,
Quentin

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Reviewed-by on v1 1/2
#3 lore raw
In reply to Heiko Stuebner

Hi Heiko,

Quoted 5 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

Enable the mali gpu node and add the board-specific supply-regulator.

Thanks,
Quentin

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

author maintainer Applied
#4 lore raw
In reply to Heiko Stuebner
Quoted 5 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

Enable the mali gpu node and add the board-specific supply-regulator.

Applied, thanks!

[1/2] arm64: dts: rockchip: enable gpu on rk3588-jaguar

      commit: 51ca6a22c52b10a787fa3fad2343279f11da27bb
[2/2] arm64: dts: rockchip: enable gpu on rk3588-tiger
      commit: f5256f8ed4b729c3ab9d9cd7d406313773484b59

Best regards,

Signature · 6 lines
Heiko Stuebner <[email protected]>

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
maintainer
#5 lore raw
In reply to Heiko Stuebner
Quoted 9 lines · Heiko Stuebner

From: Heiko Stuebner <[email protected]>

Enable the mali gpu node and add the board-specific supply-regulator.

---
 arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 5 +++++
 1 file changed, 5 insertions(+)

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y rockchip/rk3588-jaguar.dtb' for [email protected]:

Error: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts:248.1-5 Label or path gpu not found FATAL ERROR: Syntax error parsing input tree
make[3]: *** [scripts/Makefile.lib:427: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb] Error 1 make[2]: *** [scripts/Makefile.build:485: arch/arm64/boot/dts/rockchip] Error 2 make[2]: Target 'arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb' not remade because of errors. make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1387: rockchip/rk3588-jaguar.dtb] Error 2
make: *** [Makefile:240: __sub-make] Error 2
make: Target 'rockchip/rk3588-jaguar.dtb' not remade because of errors.

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

author maintainer
#6 lore raw

Am Mittwoch, 27. März 2024, 16:41:16 CET schrieb Rob Herring:

Quoted 29 lines · Heiko Stuebner
Quoted 9 lines

From: Heiko Stuebner <[email protected]>

Enable the mali gpu node and add the board-specific supply-regulator.

---
 arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts | 5 +++++
 1 file changed, 5 insertions(+)

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y rockchip/rk3588-jaguar.dtb' for [email protected]:

Quoted 8 lines

Error: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts:248.1-5 Label or path gpu not found FATAL ERROR: Syntax error parsing input tree
make[3]: *** [scripts/Makefile.lib:427: arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb] Error 1 make[2]: *** [scripts/Makefile.build:485: arch/arm64/boot/dts/rockchip] Error 2 make[2]: Target 'arch/arm64/boot/dts/rockchip/rk3588-jaguar.dtb' not remade because of errors. make[1]: *** [/home/rob/proj/linux-dt-testing/Makefile:1387: rockchip/rk3588-jaguar.dtb] Error 2
make: *** [Makefile:240: __sub-make] Error 2
make: Target 'rockchip/rk3588-jaguar.dtb' not remade because of errors.

just for the record, that error fixes itself because the patch gets applied only after the main series adding that gpu node ;-)

Heiko

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip