Skip to contentSkip to conversation

Move liberror-perl to meta-perl

PATCH New Tim Orling 1 participant 3 messages Mar 28, 2024

lore
Share & tools
lore

Tim Orling

author
#0 lore raw

cover Move liberror-perl to meta-perl

This perl package has not seen any updates since 2020.

The upstream author of Error has deprecated it for quite some time.

https://metacpan.org/pod/Error#WARNING

'Using the "Error" module is no longer recommended due to the
black-magical nature of its syntactic sugar, which often tends to break. Its maintainers have stopped actively writing code that uses it, and discourage people from doing so.'

The only recipe in oe-core which had any depdency on it was coreutils-ptest, and that has now been removed. All ptests passed for core-image-ptest-coreutils on qemux86-64.

It is not clear when the dependency in coreutils was present, but it is definitely not needed in the current v9.4 release.

Tim Orling (2):
coreutils: drop obsolete liberror-perl RDEPENDS
liberror-perl: move to meta-perl

 meta/conf/distro/include/maintainers.inc      |  1 -
 .../distro/include/ptest-packagelists.inc     |  1 -
 meta/recipes-core/coreutils/coreutils_9.4.bb  |  4 +-
 .../perl/liberror-perl_0.17029.bb             | 48 -------------------
 4 files changed, 2 insertions(+), 52 deletions(-)
 delete mode 100644 meta/recipes-devtools/perl/liberror-perl_0.17029.bb
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH 1/2 coreutils: drop obsolete liberror-perl RDEPENDS

The upstream maintainer for Error has deprecated it for quite some time [1]. There is no dependency in current coreutils tests for it.

[YOCTO #15461]

[1] https://metacpan.org/pod/Error#WARNING

Using the "Error" module is no longer recommended due to the black-magical nature of its syntactic sugar, which often tends to break. Its maintainers have stopped actively writing code that uses it, and discourage people from doing so.

---
 meta/recipes-core/coreutils/coreutils_9.4.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-core/coreutils/coreutils_9.4.bb +2 -2
index fc51adcd5b1..62ecdea6ec1 100644
@@ -23,7 +23,7 @@ SRC_URI = "${GNU_MIRROR}/coreutils/${BP}.tar.xz \
 SRC_URI[sha256sum] = "ea613a4cf44612326e917201bbbcdfbd301de21ffc3b59b6e5c07e040b275e52"
 
 # http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=v8.27-101-gf5d7c0842
-# 
+#
 CVE_STATUS[CVE-2016-2781] = "disputed: runcon is not really a sandbox command, use `runcon ... setsid ...` to avoid this particular issue."
 
 EXTRA_OECONF:class-target = "--enable-install-program=arch,hostname --libexecdir=${libdir}"
@@ -169,7 +169,7 @@ BBCLASSEXTEND = "native nativesdk"
 
 inherit ptest
 
-RDEPENDS:${PN}-ptest += "bash findutils gawk liberror-perl make perl perl-modules python3-core sed shadow"
+RDEPENDS:${PN}-ptest += "bash findutils gawk make perl perl-modules python3-core sed shadow"
 
 # -dev automatic dependencies fails as we don't want libmodule-build-perl-dev, its too heavy
 # may need tweaking if DEPENDS changes
Signature · 1 line
2.34.1
author
#2 lore raw

PATCH 2/2 liberror-perl: move to meta-perl

In reply to Tim Orling

The upstream maintainer for Error has deprecated it for quite some time [1]. The only dependency in oe-core was coreutils-ptest.

[YOCTO #15461]

[1] https://metacpan.org/pod/Error#WARNING

Using the "Error" module is no longer recommended due to the black-magical nature of its syntactic sugar, which often tends to break. Its maintainers have stopped actively writing code that uses it, and discourage people from doing so. See the "SEE ALSO" section below for better recommendations [2].

[2] https://metacpan.org/pod/Error#SEE-ALSO

SEE ALSO
--------

See Exception::Class for a different module providing Object-Oriented exception handling, along with a convenient syntax for declaring hierarchies for them. It doesn't provide Error's syntactic sugar of try { ... }, catch { ... }, etc. which may be a good thing or a bad thing based on what you want. (Because Error's syntactic sugar tends to break.)

Error::Exception aims to combine Error and Exception::Class "with correct stringification".

TryCatch and Try::Tiny are similar in concept to Error.pm only providing a syntax that hopefully breaks less.

---
 meta/conf/distro/include/maintainers.inc      |  1 -
 .../distro/include/ptest-packagelists.inc     |  1 -
 .../perl/liberror-perl_0.17029.bb             | 48 -------------------
 3 files changed, 50 deletions(-)
 delete mode 100644 meta/recipes-devtools/perl/liberror-perl_0.17029.bb
meta/conf/distro/include/maintainers.inc +0 -1
index 4ca5430a941..2d1f9fdec55 100644
@@ -328,7 +328,6 @@ RECIPE_MAINTAINER:pn-libdrm = "Otavio Salvador <[email protected]
 RECIPE_MAINTAINER:pn-libedit = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER:pn-libepoxy = "Anuj Mittal <[email protected]>"
 RECIPE_MAINTAINER:pn-liberation-fonts = "Alexander Kanavin <[email protected]>"
-RECIPE_MAINTAINER:pn-liberror-perl = "Tim Orling <[email protected]>"
 RECIPE_MAINTAINER:pn-libevdev = "Anuj Mittal <[email protected]>"
 RECIPE_MAINTAINER:pn-libevent = "Anuj Mittal <[email protected]>"
 RECIPE_MAINTAINER:pn-libexif = "Alexander Kanavin <[email protected]>"
meta/conf/distro/include/ptest-packagelists.inc +0 -1
index 0192146dbd0..84f67644437 100644
@@ -28,7 +28,6 @@ PTESTS_FAST = "\
     json-c \
     json-glib \
     libconvert-asn1-perl \
-    liberror-perl \
     libgpg-error\
     libnl \
     libpcre \
meta/recipes-devtools/perl/liberror-perl_0.17029.bb deleted +0 -48

48 lines not on this page · raw message

Signature · 1 line
2.34.1