Staging: rtl8723bs: remove spaces before tabs in rtw_set_key()
PATCH 1/1 Staging: rtl8723bs: remove spaces before tabs in rtw_set_key()
Remove spaces before tabs in order to improve coding style.
--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 36 +++++++++++------------ 1 file changed, 18 insertions(+), 18 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme.c +18 -18
@@ -626,10 +626,10 @@ void rtw_add_network(struct adapter *adapter, struct wlan_bssid_ex *pnetwork)/* select the desired network based on the capability of the (i)bss. */ /* check items: (1) security */ -/* (2) network_type */ -/* (3) WMM */ -/* (4) HT */ -/* (5) others */ +/* (2) network_type */ +/* (3) WMM */ +/* (4) HT */ +/* (5) others */ int rtw_is_desired_network (struct adapter *adapter,struct wlan_network *pnetwork);int rtw_is_desired_network (struct adapter *adapter,struct wlan_network *pnetwork) {
@@ -1052,9 +1052,9 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter, strmemset ((u8 *)&psta->dot11rxpn,0 ,sizeof (union pn48 )); } -/* Commented by Albert 2012/07/21 */ -/* When doing the WPS, the wps_ie_len won't equal to 0 */ -/* And the Wi-Fi driver shouldn't allow the data packet to be transmitted. */ +/* Commented by Albert 2012/07/21 */ +/* When doing the WPS, the wps_ie_len won't equal to 0 */ +/* And the Wi-Fi driver shouldn't allow the data packet to be transmitted. */ if (padapter->securitypriv.wps_ie_len !=0 ) { psta->ieee8021x_blocked = true; padapter->securitypriv.wps_ie_len =0 ;
@@ -1916,7 +1916,7 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypu8 keylen;struct cmd_obj *pcmd;struct setkey_parm *psetkeyparm; -struct cmd_priv *pcmdpriv = &(adapter->cmdpriv); +struct cmd_priv *pcmdpriv = &(adapter->cmdpriv);signed int res = _SUCCESS; psetkeyparm =rtw_zmalloc (sizeof (struct setkey_parm ));
@@ -2021,8 +2021,8 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_/* */ /* Search by BSSID, */ /* Return Value: */ -/* -1 :if there is no pre-auth key in the table */ -/* >= 0 :if there is pre-auth key, and return the entry id */ +/* -1: if there is no pre-auth key in the table */ +/* >= 0: if there is pre-auth key, and return the entry id */ /* */ /* */
@@ -2185,7 +2185,7 @@ void rtw_joinbss_reset(struct adapter *padapter)u8 threshold;struct mlme_priv *pmlmepriv = &padapter->mlmepriv; -struct ht_priv *phtpriv = &pmlmepriv->htpriv; +struct ht_priv *phtpriv = &pmlmepriv->htpriv;/* todo: if you want to do something io/reg/hw setting before join_bss, please add code here */
@@ -2211,11 +2211,11 @@ void rtw_joinbss_reset(struct adapter *padapter)void rtw_ht_use_default_setting (struct adapter *padapter) { -struct mlme_priv *pmlmepriv = &padapter->mlmepriv; -struct ht_priv *phtpriv = &pmlmepriv->htpriv; +struct mlme_priv *pmlmepriv = &padapter->mlmepriv; +struct ht_priv *phtpriv = &pmlmepriv->htpriv;struct registry_priv *pregistrypriv = &padapter->registrypriv; -bool bHwLDPCSupport = false, bHwSTBCSupport = false; -bool bHwSupportBeamformer = false, bHwSupportBeamformee = false; +bool bHwLDPCSupport = false, bHwSTBCSupport = false; +bool bHwSupportBeamformer = false, bHwSupportBeamformee = false;if (pregistrypriv->wifi_spec) phtpriv->bss_coexist =1 ;
@@ -2286,7 +2286,7 @@ unsigned int rtw_restructure_ht_ie(struct adapter *padapter, u8 *in_ie, u8 *out_u8 cbw40_enable =0 , stbc_rx_enable =0 , operation_bw =0 ;struct registry_priv *pregistrypriv = &padapter->registrypriv;struct mlme_priv *pmlmepriv = &padapter->mlmepriv; -struct ht_priv *phtpriv = &pmlmepriv->htpriv; +struct ht_priv *phtpriv = &pmlmepriv->htpriv;struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; phtpriv->ht_option = false;
@@ -2415,7 +2415,7 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *pie, uint ie_len, u8 channestruct ieee80211_ht_cap *pht_capie;/* struct recv_reorder_ctrl *preorder_ctrl; */ struct mlme_priv *pmlmepriv = &padapter->mlmepriv; -struct ht_priv *phtpriv = &pmlmepriv->htpriv; +struct ht_priv *phtpriv = &pmlmepriv->htpriv;/* struct recv_priv *precvpriv = &padapter->recvpriv; */ struct registry_priv *pregistrypriv = &padapter->registrypriv;/* struct wlan_network *pcur_network = &(pmlmepriv->cur_network);; */
@@ -2544,7 +2544,7 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter, struct xmit_frame *pxmitfrvoid rtw_append_exented_cap (struct adapter *padapter,u8 *out_ie,uint *pout_len) {struct mlme_priv *pmlmepriv = &padapter->mlmepriv; -struct ht_priv *phtpriv = &pmlmepriv->htpriv; +struct ht_priv *phtpriv = &pmlmepriv->htpriv;u8 cap_content[8 ] = {0 };if (phtpriv->bss_coexist)
Signature · 1 line
2.34.1
Quoted 13 lines · Meir Elisha
Remove spaces before tabs in order to improve coding style.
Signed-off-by Meir Elisha <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_mlme.c | 36 +++++++++++------------ 1 file changed, 18 insertions(+), 18 deletions(-)drivers/staging/rtl8723bs/core/rtw_mlme.c +0
-0@@ -626,10 +626,10 @@ void rtw_add_network(struct adapter *adapter, struct wlan_bssid_ex *pnetwork)
drivers/staging/rtl8723bs/core/rtw_mlme.c void rtw_add_network(struct adapter *adapter, struct wlan_bssid_ex *pnetwork) · line 632
Quoted 10 lines
drivers/staging/rtl8723bs/core/rtw_mlme.c +4
-4/* select the desired network based on the capability of the (i)bss. */ /* check items: (1) security */ -/* (2) network_type */ -/* (3) WMM */ -/* (4) HT */ -/* (5) others */ +/* (2) network_type */ +/* (3) WMM */ +/* (4) HT */ +/* (5) others */
This comment looks weird.
drivers/staging/rtl8723bs/core/rtw_mlme.c static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter, str · line 1055
Quoted 11 lines
drivers/staging/rtl8723bs/core/rtw_mlme.c +1
-3int rtw_is_desired_network (struct adapter *adapter,struct wlan_network *pnetwork);int rtw_is_desired_network (struct adapter *adapter,struct wlan_network *pnetwork) {@@ -1052,9 +1052,9 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter, strmemset ((u8 *)&psta->dot11rxpn,0 ,sizeof (union pn48 )); } -/* Commented by Albert 2012/07/21 */ -/* When doing the WPS, the wps_ie_len won't equal to 0 */ -/* And the Wi-Fi driver shouldn't allow the data packet to be transmitted. */ +/* Commented by Albert 2012/07/21 */
Nobody knows who Albert is.
drivers/staging/rtl8723bs/core/rtw_mlme.c signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp · line 1920
Quoted 12 lines
drivers/staging/rtl8723bs/core/rtw_mlme.c +3
-1+/* When doing the WPS, the wps_ie_len won't equal to 0 */ +/* And the Wi-Fi driver shouldn't allow the data packet to be transmitted. */ if (padapter->securitypriv.wps_ie_len !=0 ) { psta->ieee8021x_blocked = true; padapter->securitypriv.wps_ie_len =0 ;@@ -1916,7 +1916,7 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecuritypu8 keylen;struct cmd_obj *pcmd;struct setkey_parm *psetkeyparm; -struct cmd_priv *pcmdpriv = &(adapter->cmdpriv); +struct cmd_priv *pcmdpriv = &(adapter->cmdpriv);signed int res = _SUCCESS;
These declarations look bad.
drivers/staging/rtl8723bs/core/rtw_mlme.c int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_ · line 2027
Quoted 12 lines
drivers/staging/rtl8723bs/core/rtw_mlme.c +2
-2psetkeyparm =rtw_zmalloc (sizeof (struct setkey_parm ));@@ -2021,8 +2021,8 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_/* */ /* Search by BSSID, */ /* Return Value: */ -/* -1 :if there is no pre-auth key in the table */ -/* >= 0 :if there is pre-auth key, and return the entry id */ +/* -1: if there is no pre-auth key in the table */ +/* >= 0: if there is pre-auth key, and return the entry id */ /* */ /* */
Bad.
Nobody really cares about spaces before tabs. The more important thing is that it looks ugly. Focus on what matters more.
regards,
dan carpenter