Skip to contentSkip to conversation

arm64: dts: uniphier: ld11-global: use generic node name for audio-codec

PATCH Applied Krzysztof Kozlowski 3 participants 6 messages Apr 1, 2024 – Apr 25, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/4 arm64: dts: uniphier: ld11-global: use generic node name for audio-codec

Devicetree specification expects node names to be generic, representing the class of devices.

---
 arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts +1 -1
index da44a15a8adf..2f88e81b7ee3 100644
@@ -111,7 +111,7 @@ &comp_spdif_hiecout1 {
 &i2c0 {
 	status = "okay";
 
-	tas5707a@1d {
+	audio-codec@1d {
 		compatible = "ti,tas5711";
 		reg = <0x1d>;
 		reset-gpios = <&gpio UNIPHIER_GPIO_PORT(23, 4) GPIO_ACTIVE_LOW>;
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/4 arm64: dts: uniphier: ld11-global: drop audio codec port unit address

Audio codec port does not have "reg", thus it should not have unit address, as reported by dtc W=1 warning:

uniphier-ld11-global.dts:127.10-132.5: Warning (unit_address_vs_reg): /soc@0/i2c@58780000/tas5707a@1d/port@0: node has a unit name, but no reg or ranges property

---
 arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/socionext/uniphier-ld11-global.dts +1 -1
index 2f88e81b7ee3..a251c4343548 100644
@@ -124,7 +124,7 @@ audio-codec@1d {
 		PVDD_C-supply = <&amp_vcc_reg>;
 		PVDD_D-supply = <&amp_vcc_reg>;
 
-		port@0 {
+		port {
 			tas_speaker: endpoint {
 				dai-format = "i2s";
 				remote-endpoint = <&i2s_hpcmout1>;
Signature · 1 line
2.34.1
#2 lore raw

PATCH 3/4 arm64: dts: uniphier: ld20-global: use generic node name for audio-codec

In reply to Krzysztof Kozlowski

Devicetree specification expects node names to be generic, representing the class of devices.

---
 arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts +1 -1
index a01579cb3b79..a4c86137f424 100644
@@ -111,7 +111,7 @@ &comp_spdif_hiecout1 {
 &i2c0 {
 	status = "okay";
 
-	tas5707@1b {
+	audio-codec@1b {
 		compatible = "ti,tas5711";
 		reg = <0x1b>;
 		reset-gpios = <&gpio UNIPHIER_GPIO_PORT(0, 0) GPIO_ACTIVE_LOW>;
Signature · 1 line
2.34.1
#3 lore raw

PATCH 4/4 arm64: dts: uniphier: ld20-global: drop audio codec port unit address

In reply to Krzysztof Kozlowski

Audio codec port does not have "reg", thus it should not have unit address, as reported by dtc W=1 warning:

uniphier-ld20-global.dts:127.10-132.5: Warning (unit_address_vs_reg): /soc@0/i2c@58780000/tas5707@1b/port@0: node has a unit name, but no reg or ranges property

---
 arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/socionext/uniphier-ld20-global.dts +1 -1
index a4c86137f424..79f6db2455c1 100644
@@ -124,7 +124,7 @@ audio-codec@1b {
 		PVDD_C-supply = <&amp_vcc_reg>;
 		PVDD_D-supply = <&amp_vcc_reg>;
 
-		port@0 {
+		port {
 			tas_speaker: endpoint {
 				dai-format = "i2s";
 				remote-endpoint = <&i2s_hpcmout1>;
Signature · 1 line
2.34.1
#4 lore raw
In reply to Krzysztof Kozlowski
Quoted 4 lines · Krzysztof Kozlowski

Devicetree specification expects node names to be generic, representing the class of devices.

Almost a month passed, no replies from maintainers about picking it up. Dunno, looks abandoned, so let me grab this. If anyone else wants to pick it up, let me know.

Applied, thanks!

[1/4] arm64: dts: uniphier: ld11-global: use generic node name for audio-codec

      https://git.kernel.org/krzk/linux-dt/c/345531df1cf864bbdba8d5a31c0b5519296c39cc
[2/4] arm64: dts: uniphier: ld11-global: drop audio codec port unit address
      https://git.kernel.org/krzk/linux-dt/c/2e2798377b8b086832512dc4826b1b4c6a59aa2b
[3/4] arm64: dts: uniphier: ld20-global: use generic node name for audio-codec
      https://git.kernel.org/krzk/linux-dt/c/e505949abaa4f616b166430719767867ce26bdc6
[4/4] arm64: dts: uniphier: ld20-global: drop audio codec port unit address
      https://git.kernel.org/krzk/linux-dt/c/63252893550f75389616d24731c0c6051bb16a77

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>
maintainer
#5 lore raw

Hi Krzysztof,

Quoted 7 lines · Krzysztof Kozlowski
Quoted 4 lines · Krzysztof Kozlowski

Devicetree specification expects node names to be generic, representing the class of devices.

Quoted 5 lines

Almost a month passed, no replies from maintainers about picking it up. Dunno,
looks abandoned, so let me grab this. If anyone else wants to pick it up, let
me know.

Sorry, I couldn't reply your patches due to some problems. They looks to me, so you can keep on picking them up.

Thank you,

---
Best Regards
Kunihiko Hayashi

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel