Skip to contentSkip to conversation

mvebu: Enable preboot start for pci/usb/scsi/nvme

PATCH In review Dennis Gilmore 2 participants 3 messages Apr 2, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mvebu: Enable preboot start for pci/usb/scsi/nvme

While preboot was enabled, it did not work as commands are needed to be run to enable some of the subsystems. This patch starts pci, USB, Sata, and nvme and makes sure that the system will boot no mater what storage is in use.

Applogies for resending, I accidently left the u-boot list off

---
 configs/mvebu_espressobin-88f3720_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/mvebu_espressobin-88f3720_defconfig +1 -0
index 7ecf5ab0d64..f4f7a809609 100644
@@ -21,6 +21,7 @@ CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_USE_PREBOOT=y
+CONFIG_PREBOOT="pci enum; usb start; nvme scan; scsi scan;"
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
Signature · 1 line
2.44.0
#1 lore raw

Does anyone have an alternate email for Konstantin Porotchkin? he is listed as the maintainer for theESPRESSOBin BOARD. and his email is bouncing because his inbox is full.

Dennis

Quoted 28 lines · Dennis Gilmore

While preboot was enabled, it did not work as commands are needed to be run to enable some of the subsystems. This patch starts pci, USB, Sata, and nvme and makes sure that the system will boot no mater what storage is in use.

Applogies for resending, I accidently left the u-boot list off

---
 configs/mvebu_espressobin-88f3720_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/mvebu_espressobin-88f3720_defconfig +1 -1
index 7ecf5ab0d64..fause his inbox is full4f7a809609 100644
@@ -21,6 +21,7 @@ CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_USE_PREBOOT=y
+CONFIG_PREBOOT="pci enum; usb start; nvme scan; scsi scan;"
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
--

2.44.0

#2 lore raw
In reply to Dennis Gilmore

Hi Dennis,

Quoted 28 lines · Dennis Gilmore

While preboot was enabled, it did not work as commands are needed to be run to enable some of the subsystems. This patch starts pci, USB, Sata, and nvme and makes sure that the system will boot no mater what storage is in use.

Applogies for resending, I accidently left the u-boot list off

---
 configs/mvebu_espressobin-88f3720_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/mvebu_espressobin-88f3720_defconfig +1 -1
index 7ecf5ab0d64..f4f7a809609 100644
@@ -21,6 +21,7 @@ CONFIG_AHCI=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_USE_PREBOOT=y
+CONFIG_PREBOOT="pci enum; usb start; nvme scan; scsi scan;"
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
--

2.44.0

Quoted 1 line

The issue is in a different place. This board uses distroboot

approach (based on what I see in [1]), which is supposed to automatically initialize boot media before trying to boot from it [2]. Initialization of media is forced when the CONFIG_<subsystem> symbol is enabled, for example CONFIG_NVMEM=y (check BOOTENV_SET_NVME_NEED_INIT define in [2]). In your final board config "# CONFIG_NVMEM is not set" though.

IMO, with your proposed fix you'll drastically increase boot time (by probing all buses regardless of what boot media is going to be used next),
and hide side effects of misconfiguration.

Hope that helps

Regards,
Igor

[1] include/configs/mvebu_armada-37xx.h
[2] include/config_distro_bootcmd.h

Signature · 7 lines
Best regards - Atentamente - Meilleures salutations

Igor Opaniuk

mailto: [email protected]
skype: igor.opanyuk
https://www.linkedin.com/in/iopaniuk <http://ua.linkedin.com/in/iopaniuk>