Skip to contentSkip to conversation

util-linux: Set the license for util-linux-fcntl-lock to MIT

PATCH In review Peter Kjellerstedt 4 participants 5 messages Apr 2, 2024 – Apr 4, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 util-linux: Set the license for util-linux-fcntl-lock to MIT

This avoids problems if BSD-4-Clause is in INCOMPATIBLE_LICENSE since util-linux-fcntl-lock is now a dependency of run-postinsts.

---
 meta/recipes-core/util-linux/util-linux.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/util-linux/util-linux.inc +1 -0
index f4b547215e..d506783f9a 100644
@@ -7,6 +7,7 @@ disk partitioning, kernel message management, filesystem creation, and system lo
 SECTION = "base"
 
 LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
+LICENSE:${PN}-fcntl-lock = "MIT"
 LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
 LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
 LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
#1 lore raw

Hello,

This caused:

https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/4604/steps/12/logs/stdio
https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240403-u_hyp_wv/packages/diff-html/

I guess we need to bump PR?

Quoted 30 lines · Peter Kjellerstedt

This avoids problems if BSD-4-Clause is in INCOMPATIBLE_LICENSE since util-linux-fcntl-lock is now a dependency of run-postinsts.

---
 meta/recipes-core/util-linux/util-linux.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/util-linux/util-linux.inc +1 -1
index f4b547215e..d506783f9a 100644
@@ -7,6 +7,7 @@ disk partitioning, kernel message management, filesystem creation, and system lo
 SECTION = "base"
 
 LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
+LICENSE:${PN}-fcntl-lock = "MIT"
 LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
 LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
 LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
 
 
-=-=-=-=-=-=-=-=-=-=-=-

Links: You receive all messages sent to this group.
View/Reply Online (#197864): https://lists.openembedded.org/g/openembedded-core/message/197864
Mute This Topic: https://lists.openembedded.org/mt/105282531/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw
Quoted 7 lines

-----Original Message-----
From: Alexandre Belloni <[email protected]>
Sent: den 4 april 2024 01:45
To: Peter Kjellerstedt <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] util-linux: Set the license for util-linux-fcntl-lock to MIT

Quoted 6 lines

Hello,

This caused:

https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/4604/steps/12/logs/stdio
https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240403-u_hyp_wv/packages/diff-html/

Doesn't this type of breakage happen all the time for pure recipe changes that affect the output if the PR server is not enabled?

Quoted 2 lines

I guess we need to bump PR?

Given that RP removed all PR variables from the recipes in OE-Core (see commit d4c346e8ab8f3cae25d1b01c7331ed9f6d4f96ef), I would expect that he is not too keen to see them coming back...

//Peter

Quoted 22 lines · Peter Kjellerstedt
Quoted 20 lines

This avoids problems if BSD-4-Clause is in INCOMPATIBLE_LICENSE since util-linux-fcntl-lock is now a dependency of run-postinsts.

---
 meta/recipes-core/util-linux/util-linux.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/util-linux/util-linux.inc +1 -0
index f4b547215e..d506783f9a 100644
@@ -7,6 +7,7 @@ disk partitioning, kernel message management, filesystem creation, and system lo
 SECTION = "base"
 
 LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
+LICENSE:${PN}-fcntl-lock = "MIT"
 LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
 LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
 LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
#3 lore raw
Quoted 18 lines · Peter Kjellerstedt
Quoted 7 lines

-----Original Message-----
From: Alexandre Belloni <[email protected]>
Sent: den 4 april 2024 01:45
To: Peter Kjellerstedt <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] util-linux: Set the license for util-linux-fcntl-lock to MIT

Quoted 6 lines

Hello,

This caused:

https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/4604/steps/12/logs/stdio
https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240403-u_hyp_wv/packages/diff-html/

Doesn't this type of breakage happen all the time for pure recipe changes that affect the output if the PR server is not enabled?

Quoted 1 line
Quoted 6 lines
Quoted 1 line

I guess we need to bump PR?

Given that RP removed all PR variables from the recipes in OE-Core (see commit d4c346e8ab8f3cae25d1b01c7331ed9f6d4f96ef), I would expect that he is not too keen to see them coming back...

The plan is to take your patch as-is in master and if this causes reop failures bump PR

Quoted 25 lines

//Peter

Quoted 22 lines · Peter Kjellerstedt
Quoted 20 lines

This avoids problems if BSD-4-Clause is in INCOMPATIBLE_LICENSE since util-linux-fcntl-lock is now a dependency of run-postinsts.

---
 meta/recipes-core/util-linux/util-linux.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-core/util-linux/util-linux.inc +1 -0
index f4b547215e..d506783f9a 100644
@@ -7,6 +7,7 @@ disk partitioning, kernel message management, filesystem creation, and system lo
 SECTION = "base"
 
 LICENSE = "GPL-1.0-or-later & GPL-2.0-or-later & LGPL-2.1-or-later & BSD-2-Clause & BSD-3-Clause & BSD-4-Clause & MIT"
+LICENSE:${PN}-fcntl-lock = "MIT"
 LICENSE:${PN}-fdisk = "GPL-1.0-or-later"
 LICENSE:${PN}-libblkid = "LGPL-2.1-or-later"
 LICENSE:${PN}-libfdisk = "LGPL-2.1-or-later"
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw
In reply to Peter Kjellerstedt
Quoted 10 lines · Peter Kjellerstedt
Quoted 10 lines

-----Original Message-----
From: Alexandre Belloni <[email protected]>
Sent: den 4 april 2024 01:45
To: Peter Kjellerstedt <[email protected]>
Cc: [email protected]
Subject: Re: [OE-core] [PATCH] util-linux: Set the license for util-linux-fcntl-lock to MIT

Hello,

Quoted 7 lines
Quoted 4 lines

This caused:

https://autobuilder.yoctoproject.org/typhoon/#/builders/117/builds/4604/steps/12/logs/stdio
https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240403-u_hyp_wv/packages/diff-html/

Doesn't this type of breakage happen all the time for pure recipe changes that affect the output if the PR server is not enabled?

The problem is that bitbake can't "see" that package license variable since it isn't in PACKAGES. It gets added there dynamically by the python module splitting code.

If we add it to PACKAGES, the license change would then be in taskhash and when it changes things would rebuild. As things stand, the taskhash doesn't change and doesn't trigger a rebuild.

Quoted 5 lines
Quoted 1 line

I guess we need to bump PR?

Given that RP removed all PR variables from the recipes in OE-Core (see commit d4c346e8ab8f3cae25d1b01c7331ed9f6d4f96ef), I would expect that he is not too keen to see them coming back...

We do sometimes need them, I just got rid of a load of old obsolete stuff. You're right I'd prefer to avoid them though.

Cheers,

Richard