Skip to contentSkip to conversation

linux-next: Fixes tag needs some work in the sound-current tree

DISCUSSION Stephen Rothwell 2 participants 2 messages Apr 1, 2024 – Apr 2, 2024 Linux-next tree

lore
Share & tools
lore
#0 lore raw

Hi all,

In commit

e1d8acf35ce7 ("Revert "ALSA: emu10k1: fix synthesizer sample playback position and caching"")

Fixes tag

Fixes df335e9a8b (ALSA: emu10k1: fix synthesizer sample playback position and caching, 2023-05-18)

has these problem(s):

- SHA1 should be at least 12 digits long
This can be fixed for the future by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto").
- Subject does not match target commit subject

    Just use
        git log -1 --format='Fixes: %h ("%s")'

The date field adds nothing.

Thus:

Fixes df335e9a8bcb ("ALSA: emu10k1: fix synthesizer sample playback position and caching")
Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 18 lines · Stephen Rothwell

Hi all,

In commit

e1d8acf35ce7 ("Revert "ALSA: emu10k1: fix synthesizer sample playback position and caching"")

Fixes tag

Fixes df335e9a8b (ALSA: emu10k1: fix synthesizer sample playback position and caching, 2023-05-18)

has these problem(s):

- SHA1 should be at least 12 digits long
This can be fixed for the future by setting core.abbrev to 12 (or more) or (for git v2.11 or later) just making sure it is not set (or set to "auto").
- Subject does not match target commit subject

Quoted 8 lines
    Just use
        git log -1 --format='Fixes: %h ("%s")'

The date field adds nothing.

Thus:

Fixes df335e9a8bcb ("ALSA: emu10k1: fix synthesizer sample playback position and caching")

The commit is corrected now. Thanks.

Takashi