Skip to contentSkip to conversation

spi: pxa2xx: Call pxa_ssp_free() after getting the SSP type

PATCH In review Andy Shevchenko 2 participants 2 messages Apr 2, 2024

Subsystems (3)
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 spi: pxa2xx: Call pxa_ssp_free() after getting the SSP type

pxa_ssp_request() implies a reference counting, hence the pxa_ssp_free() must be called when we are done. Add missed call.

Fixes bb77c99ee6d3 ("spi: pxa2xx: Skip SSP initialization if it's done elsewhere")
---
 drivers/spi/spi-pxa2xx.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/spi/spi-pxa2xx.c +3 -1
index 86d0f1064a45..1348249f8178 100644
@@ -1379,8 +1379,10 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev)
 		type = (enum pxa_ssp_type)value;
 	} else {
 		ssp = pxa_ssp_request(pdev->id, pdev->name);
-		if (ssp)
+		if (ssp) {
 			type = ssp->type;
+			pxa_ssp_free(ssp);
+		}
 	}
 
 	/* Validate the SSP type correctness */
Signature · 1 line
2.43.0.rc1.1.gbec44491f096
maintainer
#1 lore raw
Quoted 4 lines · Andy Shevchenko

pxa_ssp_request() implies a reference counting, hence the pxa_ssp_free() must be called when we are done. Add missed call.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: pxa2xx: Call pxa_ssp_free() after getting the SSP type

      commit: 33aa27a09e9df5860fe495032a067504d025db77

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark