Skip to contentSkip to conversation

media: dt-bindings: ovti,ov2680: Fix the power supply names

PATCH In review Fabio Estevam 2 participants 4 messages Apr 2, 2024 – Apr 3, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/2 media: dt-bindings: ovti,ov2680: Fix the power supply names

From: Fabio Estevam <[email protected]>

The original .txt bindings had the OV2680 power supply names correct, but the transition from .txt to yaml spelled them incorrectly.

Fix the OV2680 power supply names as the original .txt bindings as these are the names used by the OV2680 driver and in devicetree.

Fixes 57226cd8c8bf ("media: dt-bindings: ov2680: convert bindings to yaml")

---
Changes since v3:
- Newly introduced.

 .../bindings/media/i2c/ovti,ov2680.yaml        | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml +9 -9
index cf456f8d9ddc..c87677f5e2a2 100644
@@ -37,15 +37,15 @@ properties:
       active low.
     maxItems: 1
 
-  dovdd-supply:
+  DOVDD-supply:
     description:
       Definition of the regulator used as interface power supply.
 
-  avdd-supply:
+  AVDD-supply:
     description:
       Definition of the regulator used as analog power supply.
 
-  dvdd-supply:
+  DVDD-supply:
     description:
       Definition of the regulator used as digital power supply.
 
@@ -59,9 +59,9 @@ required:
   - reg
   - clocks
   - clock-names
-  - dovdd-supply
-  - avdd-supply
-  - dvdd-supply
+  - DOVDD-supply
+  - AVDD-supply
+  - DVDD-supply
   - reset-gpios
   - port
 
@@ -82,9 +82,9 @@ examples:
                 clock-names = "xvclk";
                 reset-gpios = <&gpio1 3 GPIO_ACTIVE_LOW>;
 
-                dovdd-supply = <&sw2_reg>;
-                dvdd-supply = <&sw2_reg>;
-                avdd-supply = <&reg_peri_3p15v>;
+                DOVDD-supply = <&sw2_reg>;
+                DVDD-supply = <&sw2_reg>;
+                AVDD-supply = <&reg_peri_3p15v>;
 
                 port {
                         ov2680_to_mipi: endpoint {
Signature · 1 line
2.34.1
#1 lore raw

PATCH v4 2/2 media: dt-bindings: ovti,ov2680: Document link-frequencies

From: Fabio Estevam <[email protected]>

Document the link-frequencies property as recommended by the following document:

https://www.kernel.org/doc/html/v6.9-rc1/driver-api/media/camera-sensor.html#handling-clocks

---
Changes since v3:
- Only document link-frequencies.

 .../bindings/media/i2c/ovti,ov2680.yaml         | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/media/i2c/ovti,ov2680.yaml +16 -1
index c87677f5e2a2..634d3b821b8c 100644
@@ -50,9 +50,23 @@ properties:
       Definition of the regulator used as digital power supply.
 
   port:
-    $ref: /schemas/graph.yaml#/properties/port
     description:
       A node containing an output port node.
+    $ref: /schemas/graph.yaml#/$defs/port-base
+    additionalProperties: false
+
+    properties:
+      endpoint:
+        $ref: /schemas/media/video-interfaces.yaml#
+        additionalProperties: false
+
+        properties:
+          link-frequencies: true
+
+          remote-endpoint: true
+
+        required:
+          - link-frequencies
 
 required:
   - compatible
@@ -89,6 +103,7 @@ examples:
                 port {
                         ov2680_to_mipi: endpoint {
                                 remote-endpoint = <&mipi_from_sensor>;
+                                link-frequencies = /bits/ 64 <330000000>;
                         };
                 };
         };
Signature · 1 line
2.34.1
maintainer Reviewed-by on v4 2/2
#2 lore raw

Re: [PATCH v4 2/2] media: dt-bindings: ovti,ov2680: Document link-frequencies

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Document the link-frequencies property as recommended by the following document:

https://www.kernel.org/doc/html/v6.9-rc1/driver-api/media/camera-sensor.html#handling-clocks

Quoted 8 lines

---
Changes since v3:
- Only document link-frequencies.

 .../bindings/media/i2c/ovti,ov2680.yaml         | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
maintainer Reviewed-by on v4 1/2
#3 lore raw
In reply to Fabio Estevam
Quoted 8 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The original .txt bindings had the OV2680 power supply names correct, but the transition from .txt to yaml spelled them incorrectly.

Fix the OV2680 power supply names as the original .txt bindings as these are the names used by the OV2680 driver and in devicetree.

Quoted 9 lines
Fixes 57226cd8c8bf ("media: dt-bindings: ov2680: convert bindings to yaml")

---
Changes since v3:
- Newly introduced.

 .../bindings/media/i2c/ovti,ov2680.yaml        | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)