drm/arm/malidp: fix a possible null pointer dereference
Subsystems (3)
PATCH 1/1 drm/arm/malidp: fix a possible null pointer dereference
In malidp_mw_connector_reset, new memory is allocated with kzalloc, but no check is performed. In order to prevent null pointer dereferencing, ensure that mw_state is checked before calling __drm_atomic_helper_connector_reset.
Fixes 8cbc5caf36ef ("drm: mali-dp: Add writeback connector")
Signed-off-by Huai-Yuan Liu <[email protected]>
--- drivers/gpu/drm/arm/malidp_mw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/arm/malidp_mw.c +3 -1
@@ -72,7 +72,9 @@ static void malidp_mw_connector_reset(struct drm_connector *connector)__drm_atomic_helper_connector_destroy_state (connector->state);kfree (connector->state); -__drm_atomic_helper_connector_reset (connector, &mw_state->base); + +if (mw_state) +__drm_atomic_helper_connector_reset (connector, &mw_state->base); } static enum drm_connector_status
Signature · 1 line
2.34.1
Liviu Dudau
maintainerHi,
Quoted 5 lines · Huai-Yuan Liu
In
malidp_mw_connector_reset, new memory is allocated with kzalloc, but no check is performed. In order to prevent null pointer dereferencing, ensure thatmw_stateis checked before calling__drm_atomic_helper_connector_reset.
Thanks for the patch, it does look like an oversight. Can I suggest you respin your patch and add a
connector->state = NULL;
right after kfree(connector->state) ?
That way we can be sure we're not leaving state pointing to freed memory.
Best regards,
Liviu
Quoted 25 lines
Fixes 8cbc5caf36ef ("drm: mali-dp: Add writeback connector")Signed-off-by Huai-Yuan Liu <[email protected]>--- drivers/gpu/drm/arm/malidp_mw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/arm/malidp_mw.c +3
-1@@ -72,7 +72,9 @@ static void malidp_mw_connector_reset(struct drm_connector *connector)__drm_atomic_helper_connector_destroy_state (connector->state);kfree (connector->state); -__drm_atomic_helper_connector_reset (connector, &mw_state->base); + +if (mw_state) +__drm_atomic_helper_connector_reset (connector, &mw_state->base); } static enum drm_connector_statusSignature · 1 line
2.34.1
Signature · 8 lines
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯