Skip to contentSkip to conversation

arm64: dts: ti: k3-j722s-evm: Enable eMMC support

PATCH Applied Michael Walle 3 participants 4 messages Apr 3, 2024 – Apr 9, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64: dts: ti: k3-j722s-evm: Enable eMMC support

The J722S EVM has an on-board eMMC. Enable the SDHC interface for it. There is no pinmuxing required because the interface has dedicated pins.

---
v2:
- move status="okay" last

---
 arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/ti/k3-j722s-evm.dts +7 -0
index cee3a8661d5e..6b148da2bcdc 100644
@@ -369,6 +369,13 @@ partition@3fc0000 {
 
 };
 
+&sdhci0 {
+	ti,driver-strength-ohm = <50>;
+	disable-wp;
+	bootph-all;
+	status = "okay";
+};
+
 &sdhci1 {
 	/* SD/MMC */
 	vmmc-supply = <&vdd_mmc1>;
Signature · 1 line
2.39.2
#1 lore raw

Hello Michael,

Quoted 16 lines · Michael Walle

The J722S EVM has an on-board eMMC. Enable the SDHC interface for it. There is no pinmuxing required because the interface has dedicated pins.

---
v2:
- move status="okay" last

---
 arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/ti/k3-j722s-evm.dts +0 -0
index cee3a8661d5e..6b148da2bcdc 100644

arch/arm64/boot/dts/ti/k3-j722s-evm.dts partition@3fc0000 { · line 373

Quoted 5 lines
arch/arm64/boot/dts/ti/k3-j722s-evm.dts +2 -0
@@ -369,6 +369,13 @@ partition@3fc0000 {
 
 };
 
+&sdhci0 {
+	ti,driver-strength-ohm = <50>;

According to the latest DTS coding style guidelines this needs to be just before status.

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node

Yes, we would need a checker, I know and I agree. At least now we moved out of the tribal knowledge way of working with every maintainer having slightly different expectation on this topic ... one step at a time :-)

arch/arm64/boot/dts/ti/k3-j722s-evm.dts partition@3fc0000 { · line 377

Quoted 4 lines
arch/arm64/boot/dts/ti/k3-j722s-evm.dts +4 -0
+	disable-wp;
+	bootph-all;
+	status = "okay";
+};

Francesco

maintainer
#2 lore raw
Quoted 28 lines · Francesco Dolcini

Hello Michael,

Quoted 16 lines · Michael Walle

The J722S EVM has an on-board eMMC. Enable the SDHC interface for it. There is no pinmuxing required because the interface has dedicated pins.

---
v2:
- move status="okay" last

---
 arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/ti/k3-j722s-evm.dts +0 -0
index cee3a8661d5e..6b148da2bcdc 100644

arch/arm64/boot/dts/ti/k3-j722s-evm.dts partition@3fc0000 { · line 373

Quoted 5 lines
arch/arm64/boot/dts/ti/k3-j722s-evm.dts +2 -0
@@ -369,6 +369,13 @@ partition@3fc0000 {
 
 };
 
+&sdhci0 {
+	ti,driver-strength-ohm = <50>;

According to the latest DTS coding style guidelines this needs to be just before status.

Quoted 5 lines

https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node

Yes, we would need a checker, I know and I agree. At least now we moved out of the tribal knowledge way of working with every maintainer having slightly different expectation on this topic ... one step at a time :-)

Since this is the first cycle, I have done this fixup locally.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
maintainer Applied
#3 lore raw
In reply to Michael Walle

Hi Michael Walle,

Quoted 4 lines · Michael Walle

The J722S EVM has an on-board eMMC. Enable the SDHC interface for it. There is no pinmuxing required because the interface has dedicated pins.

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[1/1] arm64: dts: ti: k3-j722s-evm: Enable eMMC support

      commit: ab833a6478e5376f8076be41109d74387ab8460e

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D