Skip to contentSkip to conversation

fabrics : allow host to create duplicate connections to target

PATCH Applied Nilay Shroff 3 participants 3 messages Apr 3, 2024 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fabrics : allow host to create duplicate connections to target

Apparently the nvmf connect code doesn't allow creating duplicate connections from a host to the same target even though user specifies option "--duplicate-connect" or "-D". This patch help fix this issue.

Fixes 07d6b911e081 ("fabrics: Do not attempt to reconnect to already connected ctrls")
---
 fabrics.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fabrics.c +1 -1
index 14682907..0f55c617 100644
@@ -1001,7 +1001,7 @@ int nvmf_connect(const char *desc, int argc, char **argv)
 	};
 
 	c = lookup_ctrl(h, &trcfg);
-	if (c && nvme_ctrl_get_name(c)) {
+	if (c && nvme_ctrl_get_name(c) && !cfg.duplicate_connect) {
 		fprintf(stderr, "already connected\n");
 		errno = EALREADY;
 		goto out_free;
Signature · 1 line
2.44.0
#1 lore raw
Quoted 6 lines · Nilay Shroff

Apparently the nvmf connect code doesn't allow creating duplicate connections from a host to the same target even though user specifies option "--duplicate-connect" or "-D". This patch help fix this issue.

Applied, thanks!

[1/1] fabrics : allow host to create duplicate connections to target

      commit: fd8ecb054ce53acae504e54666bec6c9976a82dd

Best regards,

Signature · 1 line
Daniel Wagner <[email protected]>
Applied
#2 lore raw

Looks good, thank you!

Internal Use - Confidential
-----Original Message-----
From: Daniel Wagner <[email protected]>
Sent: Wednesday, 3 April 2024 16:52
To: [email protected]; Nilay Shroff <[email protected]>
Cc: Daniel Wagner <[email protected]>; Engel, Amit <[email protected]>; [email protected]; [email protected]; Engel, Amit <[email protected]>
Subject: Re: [PATCH] fabrics : allow host to create duplicate connections to target

[EXTERNAL EMAIL]

Quoted 6 lines · Nilay Shroff

Apparently the nvmf connect code doesn't allow creating duplicate connections from a host to the same target even though user specifies option "--duplicate-connect" or "-D".
This patch help fix this issue.

Applied, thanks!

[1/1] fabrics : allow host to create duplicate connections to target

      commit: fd8ecb054ce53acae504e54666bec6c9976a82dd

Best regards,
--
Daniel Wagner <[email protected]>