build: exclude rather than include libs in MSVC build
Subsystems (2)
PATCH 1/1 build: exclude rather than include libs in MSVC build
Some libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
With this change we now get immediate CI build coverage for the libs meter, timer, pci, cfgfile
Tyler Retzlaff (1):
build: exclude rather than include libs in MSVC build
lib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 7 files changed, 36 insertions(+), 10 deletions(-)
Signature · 1 line
1.8.3.1
PATCH 1/1 build: exclude rather than include libs in MSVC build
Some libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
--- lib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 7 files changed, 36 insertions(+), 10 deletions(-)
lib/argparse/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2024 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_argparse.c') headers = files('rte_argparse.h')
lib/dmadev/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2021 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_dmadev.c', 'rte_dmadev_trace_points.c') headers = files('rte_dmadev.h') indirect_headers += files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h')
lib/mbuf/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files( 'rte_mbuf.c', 'rte_mbuf_ptype.c',
lib/mempool/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + extra_flags = [] foreach flag: extra_flags
lib/meson.build +0 -10
@@ -68,16 +68,6 @@ libraries = [ 'node', ] -if is_ms_compiler - libraries = [ - 'log', - 'kvargs', - 'telemetry', - 'eal', - 'ring', - ] -endif - always_enable = [ 'cmdline', 'eal',
lib/rcu/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Arm Limited +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_rcu_qsbr.c') headers = files('rte_rcu_qsbr.h')
lib/stack/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c') headers = files('rte_stack.h') # subheaders, not for direct inclusion by apps
Signature · 1 line
1.8.3.1
Quoted 6 lines · On Tue, 2 Apr 2024 09:55:48 -0700 Tyler Retzlaff…
Some libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
Signed-off-by Tyler Retzlaff <[email protected]>
For mbuf, since it requires mempool, you might not need to explicitly exclude it. But the change looks good.
Quoted 5 lines · Stephen Hemminger
Quoted 2 lines · On Tue, 2 Apr 2024 09:55:48 -0700 Tyler Retzlaff…
Some libraries that could be built with MSVC were not being built.
Quoted 7 lines
Quoted 4 lines
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
Signed-off-by Tyler Retzlaff <[email protected]>For mbuf, since it requires mempool, you might not need to explicitly exclude it. But the change looks good.
interesting, i wonder if the dependency isn't properly working. the way i chose to exclude libs was to just enable them all and then selectively disable those that were attempted build but failed. mbuf did not complain of missing mempool and there was an attempt to build it.
with your changes mempool will build though, just need to wait for it to merge.
Quoted 1 line
Recheck-request: iol-intel-Functional
Sorry about the spam!
Quoted 143 lines · Tyler Retzlaff
Some libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
Signed-off-by Tyler Retzlaff <[email protected]>--- lib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 7 files changed, 36 insertions(+), 10 deletions(-)lib/argparse/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2024 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_argparse.c') headers = files('rte_argparse.h')lib/dmadev/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2021 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_dmadev.c', 'rte_dmadev_trace_points.c') headers = files('rte_dmadev.h') indirect_headers += files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h')lib/mbuf/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files( 'rte_mbuf.c', 'rte_mbuf_ptype.c',lib/mempool/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + extra_flags = [] foreach flag: extra_flagslib/meson.build +0
-10@@ -68,16 +68,6 @@ libraries = [ 'node', ] -if is_ms_compiler - libraries = [ - 'log', - 'kvargs', - 'telemetry', - 'eal', - 'ring', - ] -endif - always_enable = [ 'cmdline', 'eal',lib/rcu/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Arm Limited +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_rcu_qsbr.c') headers = files('rte_rcu_qsbr.h')lib/stack/meson.build +6
-1@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c') headers = files('rte_stack.h') # subheaders, not for direct inclusion by apps --1.8.3.1
PATCH v2 1/1 build: exclude rather than include libs in MSVC build
In reply to Tyler RetzlaffSome libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
With this change we now get immediate CI build coverage for the libs meter, timer, pci, cfgfile
v2:
* add a few more explicit exclusions for now as they are known to require more than trivial work and avoid needing to disable them later as the dependent libraries are enabled.
Tyler Retzlaff (1):
build: exclude rather than include libs in MSVC build
lib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/fib/meson.build | 6 ++++++ lib/lpm/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/mldev/meson.build | 6 ++++++ lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 10 files changed, 54 insertions(+), 10 deletions(-)
Signature · 1 line
1.8.3.1
PATCH v2 1/1 build: exclude rather than include libs in MSVC build
Some libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
--- lib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/fib/meson.build | 6 ++++++ lib/lpm/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/mldev/meson.build | 6 ++++++ lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 10 files changed, 54 insertions(+), 10 deletions(-)
lib/argparse/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2024 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_argparse.c') headers = files('rte_argparse.h')
lib/dmadev/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2021 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_dmadev.c', 'rte_dmadev_trace_points.c') headers = files('rte_dmadev.h') indirect_headers += files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h')
lib/fib/meson.build +6 -0
@@ -2,6 +2,12 @@ # Copyright(c) 2018 Vladimir Medvedkin <[email protected]> # Copyright(c) 2019 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_fib.c', 'rte_fib6.c', 'dir24_8.c', 'trie.c') headers = files('rte_fib.h', 'rte_fib6.h') deps += ['rib']
lib/lpm/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_lpm.c', 'rte_lpm6.c') headers = files('rte_lpm.h', 'rte_lpm6.h') # since header files have different names, we can install all vector headers
lib/mbuf/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files( 'rte_mbuf.c', 'rte_mbuf_ptype.c',
lib/mempool/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + extra_flags = [] foreach flag: extra_flags
lib/meson.build +0 -10
@@ -68,16 +68,6 @@ libraries = [ 'node', ] -if is_ms_compiler - libraries = [ - 'log', - 'kvargs', - 'telemetry', - 'eal', - 'ring', - ] -endif - always_enable = [ 'cmdline', 'eal',
lib/mldev/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright (c) 2022 Marvell. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files( 'rte_mldev_pmd.c', 'rte_mldev.c',
lib/rcu/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Arm Limited +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_rcu_qsbr.c') headers = files('rte_rcu_qsbr.h')
lib/stack/meson.build +6 -0
@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c') headers = files('rte_stack.h') # subheaders, not for direct inclusion by apps
Signature · 1 line
1.8.3.1
Quoted 11 lines
From: Tyler Retzlaff [mailto:[email protected]]
Sent: Wednesday, 3 April 2024 20.23Some libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
Signed-off-by Tyler Retzlaff <[email protected]>---
Thomas Monjalon
Applied03/04/2024 20:50, Morten Brørup:
Quoted 5 lines
Quoted 5 lines
From: Tyler Retzlaff [mailto:[email protected]]
Sent: Wednesday, 3 April 2024 20.23Some libraries that could be built with MSVC were not being built.
Quoted 7 lines
Quoted 5 lines
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
Signed-off-by Tyler Retzlaff <[email protected]>Acked-by Morten Brørup <[email protected]>
Applied, thanks.
Having an exclude list looks closer to our final goal :)
Recheck-request: iol-intel-Functional
Quoted 198 lines · Tyler Retzlaff
Some libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
Signed-off-by Tyler Retzlaff <[email protected]>--- lib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/fib/meson.build | 6 ++++++ lib/lpm/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/mldev/meson.build | 6 ++++++ lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 10 files changed, 54 insertions(+), 10 deletions(-)lib/argparse/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2024 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_argparse.c') headers = files('rte_argparse.h')lib/dmadev/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2021 HiSilicon Limited. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_dmadev.c', 'rte_dmadev_trace_points.c') headers = files('rte_dmadev.h') indirect_headers += files('rte_dmadev_core.h', 'rte_dmadev_trace_fp.h')lib/fib/meson.build +6
-0@@ -2,6 +2,12 @@ # Copyright(c) 2018 Vladimir Medvedkin <[email protected]> # Copyright(c) 2019 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_fib.c', 'rte_fib6.c', 'dir24_8.c', 'trie.c') headers = files('rte_fib.h', 'rte_fib6.h') deps += ['rib']lib/lpm/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_lpm.c', 'rte_lpm6.c') headers = files('rte_lpm.h', 'rte_lpm6.h') # since header files have different names, we can install all vector headerslib/mbuf/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files( 'rte_mbuf.c', 'rte_mbuf_ptype.c',lib/mempool/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2017 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + extra_flags = [] foreach flag: extra_flagslib/meson.build +0
-10@@ -68,16 +68,6 @@ libraries = [ 'node', ] -if is_ms_compiler - libraries = [ - 'log', - 'kvargs', - 'telemetry', - 'eal', - 'ring', - ] -endif - always_enable = [ 'cmdline', 'eal',lib/mldev/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright (c) 2022 Marvell. +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files( 'rte_mldev_pmd.c', 'rte_mldev.c',lib/rcu/meson.build +6
-0@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Arm Limited +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_rcu_qsbr.c') headers = files('rte_rcu_qsbr.h')lib/stack/meson.build +6
-1@@ -1,6 +1,12 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2019 Intel Corporation +if is_ms_compiler + build = false + reason = 'not supported building with Visual Studio Toolset' + subdir_done() +endif + sources = files('rte_stack.c', 'rte_stack_std.c', 'rte_stack_lf.c') headers = files('rte_stack.h') # subheaders, not for direct inclusion by apps --1.8.3.1
Quoted 5 lines · On Wed, 3 Apr 2024 11:23:19 -0700 Tyler Retzlaff…
Some libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
Quoted 7 lines
With this change we now get immediate CI build coverage for the libs meter, timer, pci, cfgfile
v2:
* add a few more explicit exclusions for now as they are known to require more than trivial work and avoid needing to disable them later as the dependent libraries are enabled.
If you need to do another revision, it might be good idea to add comment to the meson.build file when doing exclusions as to what is missing.
Recheck-request: iol-intel-Functional
checking for lab infra failure
Quoted 19 lines · Stephen Hemminger
Quoted 5 lines · On Wed, 3 Apr 2024 11:23:19 -0700 Tyler Retzlaff…
Some libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
Quoted 7 lines
With this change we now get immediate CI build coverage for the libs meter, timer, pci, cfgfile
v2:
* add a few more explicit exclusions for now as they are known to require more than trivial work and avoid needing to disable them later as the dependent libraries are enabled.If you need to do another revision, it might be good idea to add comment to the meson.build file when doing exclusions as to what is missing.
Recheck-request: iol-intel-Functional
Replied to the wrong version before
Quoted 32 lines · Tyler Retzlaff
Some libraries that could be built with MSVC were not being built.
Switch from explicit include to exclude of libs to get immediate CI coverage of libraries that already work with MSVC Windows builds.
With this change we now get immediate CI build coverage for the libs meter, timer, pci, cfgfile
v2:
* add a few more explicit exclusions for now as they are known to require more than trivial work and avoid needing to disable them later as the dependent libraries are enabled.Tyler Retzlaff (1):
build: exclude rather than include libs in MSVC buildlib/argparse/meson.build | 6 ++++++ lib/dmadev/meson.build | 6 ++++++ lib/fib/meson.build | 6 ++++++ lib/lpm/meson.build | 6 ++++++ lib/mbuf/meson.build | 6 ++++++ lib/mempool/meson.build | 6 ++++++ lib/meson.build | 10 ---------- lib/mldev/meson.build | 6 ++++++ lib/rcu/meson.build | 6 ++++++ lib/stack/meson.build | 6 ++++++ 10 files changed, 54 insertions(+), 10 deletions(-)--
1.8.3.1