ref_tracker: Print allocator task name.
Subsystems (3)
PATCH 1/1 ref_tracker: Print allocator task name.
Even after syzkaller has triggered a bug, it often takes a long time to find a repro. In such a case, I usually try to find a repro with syz-prog2c based on the syz-lang program in the log.
When ref_tracker detects a leaked reference, it shows a stack trace where the tracker is allocated. However, the stack trace does not include the process name.
If a stack trace prints the allocator name, it would be easier to salvage one syz-executor.X out of several candidates.
20:58:00 executing program 5:
...
[ 2792.008275][T406785] CPU: 0 PID: 406785 Comm: syz-executor.5
To make debug easier, let's save the task name to ref_tracker and print it with the stack trace.
Tested with a buggy module [0]:
# unshare -n insmod ./kern_sk.ko
kern_sk: loading out-of-tree module taints kernel.
ref_tracker: net notrefcnt@0000000019e0eaac was allocated by insmod and has 1/1 users at
sk_alloc+0x498/0x4c0
inet_create+0x128/0x530
__sock_create+0x17a/0x3a0
do_one_initcall+0x57/0x2a0
do_init_module+0x5f/0x210
init_module_from_file+0x86/0xc0
idempotent_init_module+0x178/0x230
__x64_sys_finit_module+0x56/0x90
do_syscall_64+0xc4/0x1d0
entry_SYSCALL_64_after_hwframe+0x46/0x4e------------[ cut here ]------------ WARNING: CPU: 2 PID: 48 at lib/ref_tracker.c:184 ref_tracker_dir_exit+0xfb/0x160 Modules linked in: kern_sk(O) CPU: 2 PID: 48 Comm: kworker/u16:2 Tainted: G O 6.9.0-rc1-00371-g48dca48885cd-dirty #8
--- lib/ref_tracker.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
lib/ref_tracker.c +9 -2
@@ -5,6 +5,7 @@#include <linux/export.h> #include <linux/list_sort.h> #include <linux/ref_tracker.h> +#include <linux/sched.h> #include <linux/slab.h> #include <linux/stacktrace.h> #include <linux/stackdepot.h>
@@ -17,6 +18,7 @@ struct ref_tracker {bool dead;depot_stack_handle_t alloc_stack_handle;depot_stack_handle_t free_stack_handle; +char comm[TASK_COMM_LEN ]; };struct ref_tracker_dir_stats {
@@ -25,6 +27,7 @@ struct ref_tracker_dir_stats {struct {depot_stack_handle_t stack_handle;unsigned int count; +char comm[TASK_COMM_LEN ]; } stacks[]; };
@@ -54,6 +57,7 @@ ref_tracker_get_stats(struct ref_tracker_dir *dir, unsigned int limit)if (i >= stats->count) { stats->stacks[i].stack_handle = stack; stats->stacks[i].count =0 ; +memcpy (stats->stacks[i].comm, tracker->comm,TASK_COMM_LEN ); ++stats->count; } ++stats->stacks[i].count;
@@ -107,7 +111,8 @@ __ref_tracker_dir_pr_ostream(struct ref_tracker_dir *dir, stack = stats->stacks[i].stack_handle;if (sbuf && !stack_depot_snprint (stack, sbuf,STACK_BUF_SIZE ,4 )) sbuf[0 ] =0 ; -pr_ostream (s,"%s@%pK has %d/%d users at\n%s\n" , dir->name, dir, +pr_ostream (s,"%s@%pK was allocated by %s and has %d/%d users at\n%s\n" , + dir->name, dir, stats->stacks[i].comm, stats->stacks[i].count, stats->total, sbuf); skipped -= stats->stacks[i].count; }
@@ -208,6 +213,8 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir, } nr_entries =stack_trace_save (entries,ARRAY_SIZE (entries),1 ); tracker->alloc_stack_handle =stack_depot_save (entries, nr_entries, gfp); +if (in_task ()) +get_task_comm (tracker->comm, current);spin_lock_irqsave (&dir->lock, flags);list_add (&tracker->head, &dir->list);
@@ -244,7 +251,7 @@ int ref_tracker_free(struct ref_tracker_dir *dir,if (tracker->dead) {pr_err ("reference already released.\n" );if (tracker->alloc_stack_handle) { -pr_err ("allocated in:\n" ); +pr_err ("allocated by %s in:\n" , tracker->comm);stack_depot_print (tracker->alloc_stack_handle); }if (tracker->free_stack_handle) {
Signature · 1 line
2.30.2
Paolo Abeni
maintainerlib/ref_tracker.c int ref_tracker_alloc(struct ref_tracker_dir *dir, · line 217
Quoted 6 lines · Kuniyuki Iwashima
lib/ref_tracker.c +2
-0@@ -208,6 +213,8 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir, } nr_entries =stack_trace_save (entries,ARRAY_SIZE (entries),1 ); tracker->alloc_stack_handle =stack_depot_save (entries, nr_entries, gfp); +if (in_task ()) +get_task_comm (tracker->comm, current);
This apparently causes a lockdep splat, hit by the CI:
https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/537021/16-vrf-route-leaking-sh/stderr
it looks like get_task_comm() is for BH-only scope.
Cheers,
Paolo
From: Paolo Abeni <[email protected]>
Date: Thu, 04 Apr 2024 16:42:55 +0200
Quoted 10 lines · Kuniyuki Iwashima
lib/ref_tracker.c int ref_tracker_alloc(struct ref_tracker_dir *dir, · line 217
Quoted 6 lines
lib/ref_tracker.c +2
-0@@ -208,6 +213,8 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir, } nr_entries =stack_trace_save (entries,ARRAY_SIZE (entries),1 ); tracker->alloc_stack_handle =stack_depot_save (entries, nr_entries, gfp); +if (in_task ()) +get_task_comm (tracker->comm, current);This apparently causes a lockdep splat, hit by the CI:
Quoted 3 lines
https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/537021/16-vrf-route-leaking-sh/stderr
it looks like
get_task_comm()is for BH-only scope.
Ah exectly, I'll move it down to the spin_lock_irqsave() section below.
Thanks!