Skip to contentSkip to conversation

nilfs2-fix-out-of-range-warning.patch removed from -mm tree

merged Andrew Morton 1 participant 1 message Apr 4, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: nilfs2: fix out-of-range warning
has been removed from the -mm tree. Its filename was
nilfs2-fix-out-of-range-warning.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Arnd Bergmann <[email protected]>
Subject: nilfs2: fix out-of-range warning
Date: Thu, 28 Mar 2024 15:30:44 +0100

clang-14 points out that v_size is always smaller than a 64KB page size if that is configured by the CPU architecture:

fs/nilfs2/ioctl.c:63:19: error: result of comparison of constant 65536 with expression of type '__u16' (aka 'unsigned short') is always false [-Werror,-Wtautological-constant-out-of-range-compare]

        if (argv->v_size > PAGE_SIZE)
            ~~~~~~~~~~~~ ^ ~~~~~~~~~

This is ok, so just shut up that warning with a cast.

Fixes 3358b4aaa84f ("nilfs2: fix problems of memory allocation in ioctl")
Cc Bill Wendling <[email protected]>
Cc Christian Brauner <[email protected]>
Cc Jeff Layton <[email protected]>
Cc Nathan Chancellor <[email protected]>
Cc Nick Desaulniers <[email protected]>
Cc Philipp Stanner <[email protected]>
Cc Thorsten Blum <[email protected]>

---

 fs/nilfs2/ioctl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/nilfs2/ioctl.c renamed from fs/nilfs2/ioctl.c~nilfs2-fix-out-of-range-warning +1 -1
@@ -60,7 +60,7 @@ static int nilfs_ioctl_wrap_copy(struct
 	if (argv->v_nmembs == 0)
 		return 0;
 
-	if (argv->v_size > PAGE_SIZE)
+	if ((size_t)argv->v_size > PAGE_SIZE)
 		return -EINVAL;
 
 	/*

_

Patches currently in -mm which might be from [email protected] are

kcov-avoid-clang-out-of-range-warning.patch