Skip to contentSkip to conversation

dt-bindings: media: imx-jpeg: add clocks,clock-names,slot to fix warning

PATCH In review Frank Li 4 participants 7 messages Apr 4, 2024 – Apr 8, 2024

Subsystems (4)
lore
Share & tools
lore

Frank Li

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: media: imx-jpeg: add clocks,clock-names,slot to fix warning

Fix below DTB_CHECK warning.

make CHECK_DTBS=y freescale/imx8qxp-mek.dtb
DTC_CHK arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb
arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'slot' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#

Add 'clocks' and 'clock-names' property.
Add 'slot' to choose which physical jpeg slot.

---

Notes:
Pass dtb_binding check

make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 dt_binding_check DT_SCHEMA_FILES=nxp,imx8-jpeg.yaml
LINT Documentation/devicetree/bindings
DTEX Documentation/devicetree/bindings/media/nxp,imx8-jpeg.example.dts
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTC_CHK Documentation/devicetree/bindings/media/nxp,imx8-jpeg.example.dtb

 .../devicetree/bindings/media/nxp,imx8-jpeg.yaml  | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml +15 -0
index 3d9d1db37040d..32820ec42de9d 100644
@@ -31,6 +31,15 @@ properties:
   reg:
     maxItems: 1
 
+  clocks:
+    minItems: 2
+    maxItems: 2
+
+  clock-names:
+    items:
+      - const: per
+      - const: ipg
+
   interrupts:
     description: |
       There are 4 slots available in the IP, which the driver may use
@@ -46,6 +55,12 @@ properties:
     minItems: 2               # Wrapper and 1 slot
     maxItems: 5               # Wrapper and 4 slots
 
+  slot:
+    description: Certain slot number is used.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 3
+
 required:
   - compatible
   - reg
Signature · 1 line
2.34.1
#1 lore raw
Quoted 6 lines · Frank Li

Fix below DTB_CHECK warning.

make CHECK_DTBS=y freescale/imx8qxp-mek.dtb
DTC_CHK arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb
arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'slot' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#

No, that's not the reason to add properties. Add them if they are valid.

Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml properties: · line 62

Quoted 6 lines
Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml +5 -0
+  slot:
+    description: Certain slot number is used.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 3

NAK. Every time.

Fix your DTS instead.

Please read the feedback instead of pushing this stuff for the third time!

https://lore.kernel.org/all/[email protected]/

Can NXP take responsibility for this piece of code?

Best regards,
Krzysztof

#2 lore raw
Quoted 9 lines · Krzysztof Kozlowski
Quoted 6 lines · Frank Li

Fix below DTB_CHECK warning.

make CHECK_DTBS=y freescale/imx8qxp-mek.dtb
DTC_CHK arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb
arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'slot' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#

No, that's not the reason to add properties. Add them if they are valid.

And for the clocks, instead pick up this patch:
https://lore.kernel.org/all/[email protected]/

Please check for same work on lore before working on old issues. dfn in lore is your friend.

Best regards,
Krzysztof

#4 lore raw
Quoted 8 lines · Fabio Estevam
Quoted 2 lines · Krzysztof Kozlowski

And for the clocks, instead pick up this patch:
https://lore.kernel.org/all/[email protected]/

Or maybe this one:
https://lore.kernel.org/linux-devicetree/DB9PR04MB923493D0DA82C9EC4386BC2A8FF1A@DB9PR04MB9234.eurprd04.prod.outlook.com/

Three people were fixing same clocks issue... and three or more people were trying to fix the slot property.

This is really bad binding maintenance and driver upstreaming, NXP.

Best regards,
Krzysztof

author maintainer
#5 lore raw
Quoted 7 lines · Krzysztof Kozlowski
Quoted 6 lines · Fabio Estevam
Quoted 2 lines · Krzysztof Kozlowski

And for the clocks, instead pick up this patch:
https://lore.kernel.org/all/[email protected]/

Quoted 8 lines
Quoted 2 lines

Or maybe this one:
https://lore.kernel.org/linux-devicetree/DB9PR04MB923493D0DA82C9EC4386BC2A8FF1A@DB9PR04MB9234.eurprd04.prod.outlook.com/

Three people were fixing same clocks issue... and three or more people were trying to fix the slot property.

This is really bad binding maintenance and driver upstreaming, NXP.

Thanks everyone help make imx dts and binding better. I should google before send.

Patchwork for imx already was created.
https://patchwork.kernel.org/project/imx/list/?series=&submitter=150701&state=&q=&archive=&delegate=

I hope to patchwork help reduce duplicate work.

Frank

Quoted 4 lines

Best regards,
Krzysztof

maintainer
#6 lore raw
In reply to Krzysztof Kozlowski

Hi Krzysztof,

Quoted 21 lines · Krzysztof Kozlowski

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button

Quoted 6 lines · Frank Li

Fix below DTB_CHECK warning.

make CHECK_DTBS=y freescale/imx8qxp-mek.dtb
DTC_CHK arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb
arch/arm64/boot/dts/freescale/imx8qxp-mek.dtb: jpegdec@58400000: 'assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'slot' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/media/nxp,imx8-jpeg.yaml#

No, that's not the reason to add properties. Add them if they are valid.

Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml properties: · line 62

Quoted 5 lines
Documentation/devicetree/bindings/media/nxp,imx8-jpeg.yaml +5 -0
+  slot:
+    description: Certain slot number is used.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 0
+    maximum: 3

NAK. Every time.

Quoted 7 lines

Fix your DTS instead.

Please read the feedback instead of pushing this stuff for the third time!

https://lore.kernel.org/all/[email protected]/

Can NXP take responsibility for this piece of code?

Thanks for feedback.

For the clocks issue, I looked at the patches sent previously by Alexander Stein and Fabio Estevam, and the current one:

https://lore.kernel.org/linux-devicetree/?q=dfblob%3A3d9d1db3704+dfblob%3A7899e17aff3

As I also said in the past, I think Fabio's patch was more complete, so I took his _v3, I tried to incorporate all the feedback given, and I sent a subsequent _v4, here (bindings & dtb):

https://lore.kernel.org/linux-devicetree/[email protected]/

For the slots issue, I will consult with Ming and get back.

Thanks for your patience, and sorry for the inconvenience.

Regards,

Mirela

Quoted 4 lines

Best regards,
Krzysztof