clk: keystone: sci-clk: Adding support for non contiguous clocks
Subsystems (4)
PATCH 1/1 clk: keystone: sci-clk: Adding support for non contiguous clocks
commit ad3ac13c6ec318b43e769cc9ffde67528e58e555 upstream.
Most of clocks and their parents are defined in contiguous range, But in few cases, there is gap in clock numbers[0]. Driver assumes clocks to be in contiguous range, and add their clock ids incrementally.
New firmware started returning error while calling get_freq and is_on API for non-available clock ids.
In this fix, driver checks and adds only valid clock ids.
[0] https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/j7200/clocks.html
Section Clocks for NAVSS0_CPTS_0 Device, clock id 12-15 not present.
Fixes 3c13933c6033 ("clk: keystone: sci-clk: add support for dynamically probing clocks")
Signed-off-by Udit Kumar <[email protected]>
Reviewed-by Nishanth Menon <[email protected]>
Signed-off-by Stephen Boyd <[email protected]>
---
Patch needs manual backporting only for LTS kernel version 4.19
drivers/clk/keystone/sci-clk.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/clk/keystone/sci-clk.c +10 -0
@@ -516,6 +516,7 @@ static int ti_sci_scan_clocks_from_dt(struct sci_clk_provider *provider)struct sci_clk *sci_clk, *prev;int num_clks =0 ;int num_parents; +bool state;int clk_id;const char *const clk_names[] = {"clocks" ,"assigned-clocks" ,"assigned-clock-parents" ,NULL
@@ -586,6 +587,15 @@ static int ti_sci_scan_clocks_from_dt(struct sci_clk_provider *provider) clk_id = args.args[1 ] +1 ;while (num_parents--) { +/* Check if this clock id is valid */ + ret = provider->ops->is_auto (provider->sci, + sci_clk->dev_id, clk_id, &state); + +if (ret) { + clk_id++; +continue ; + } + sci_clk =devm_kzalloc (dev,sizeof (*sci_clk),GFP_KERNEL );
Signature · 1 line
2.34.1