Skip to contentSkip to conversation

package/python-yamllint: new package

PATCH Superseded Heiko Thiery 2 participants 7 messages Apr 4, 2024 – Apr 11, 2024

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Heiko Thiery

author
#0 lore raw

PATCH v2 1/3 package/python-yamllint: new package

This host package is needed since u-boot 2024.04 for building ti defconfigs.

This is an requirement for using buildman/binman [1].

[1] https://source.denx.de/u-boot/u-boot/-/blob/v2024.04/tools/buildman/requirements.txt?ref_type=tags#L3

Signed-off-by Heiko Thiery <[email protected]>
---
 package/Config.in                            |  1 +
 package/python-yamllint/Config.in            |  6 ++++++
 package/python-yamllint/python-yamllint.hash |  3 +++
 package/python-yamllint/python-yamllint.mk   | 15 +++++++++++++++
 4 files changed, 25 insertions(+)
 create mode 100644 package/python-yamllint/Config.in
 create mode 100644 package/python-yamllint/python-yamllint.hash
 create mode 100644 package/python-yamllint/python-yamllint.mk
package/Config.in +1 -0
index 87767993a2..a02370a2ad 100644
@@ -1437,6 +1437,7 @@ menu "External python modules"
 	source "package/python-xmljson/Config.in"
 	source "package/python-xmltodict/Config.in"
 	source "package/python-xmodem/Config.in"
+	source "package/python-yamllint/Config.in"
 	source "package/python-yarl/Config.in"
 	source "package/python-yatl/Config.in"
 	source "package/python-zc-lockfile/Config.in"
package/python-yamllint/Config.in new file +6 -0
new file mode 100644
index 0000000000..cb67b355c3
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_YAMLLINT
+	bool "python-yamllint"
+	help
+	  A linter for YAML files.
+
+	  https://github.com/adrienverge/yamllint
package/python-yamllint/python-yamllint.hash new file +3 -0
new file mode 100644
index 0000000000..d80e0fdf42
@@ -0,0 +1,3 @@
+# Locally computed sha256 checksums
+sha256  7a003809f88324fd2c877734f2d575ee7881dd9043360657cc8049c809eba6cd  yamllint-1.35.1.tar.gz
+sha256  3972dc9744f6499f0f9b2dbf76696f2ae7ad8af9b23dde66d6af86c9dfb36986  LICENSE
package/python-yamllint/python-yamllint.mk new file +15 -0
new file mode 100644
index 0000000000..ceaca3b0b8
@@ -0,0 +1,15 @@
+################################################################################
+#
+# python-yamllint
+#
+################################################################################
+
+PYTHON_YAMLLINT_VERSION = 1.35.1
+PYTHON_YAMLLINT_SOURCE = yamllint-$(PYTHON_YAMLLINT_VERSION).tar.gz
+PYTHON_YAMLLINT_SITE = https://files.pythonhosted.org/packages/da/06/d8cee5c3dfd550cc0a466ead8b321138198485d1034130ac1393cc49d63e
+PYTHON_YAMLLINT_SETUP_TYPE = pep517
+PYTHON_YAMLLINT_LICENSE = GPL-3.0
+PYTHON_YAMLLINT_LICENSE_FILES = LICENSE
+
+$(eval $(python-package))
+$(eval $(host-python-package))

--
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

author
#1 lore raw

PATCH v2 2/3 boot/ti-k3-r5-loader: add dependency to yamllint

Since U-Boot 2024.04 [1] binman also uses yamllint as dependency [2].

[1] https://source.denx.de/u-boot/u-boot/-/commit/10fee88d42f
[2] https://source.denx.de/u-boot/u-boot/-/blob/v2024.04/tools/buildman/requirements.txt?ref_type=tags#L3

Signed-off-by Heiko Thiery <[email protected]>
---
 boot/ti-k3-r5-loader/ti-k3-r5-loader.mk | 1 +
 1 file changed, 1 insertion(+)
boot/ti-k3-r5-loader/ti-k3-r5-loader.mk +1 -0
index b3c48109c8..3f1000caad 100644
@@ -48,6 +48,7 @@ TI_K3_R5_LOADER_DEPENDENCIES = \
 	host-python-pylibfdt \
 	host-python-pyyaml \
 	host-python-setuptools \
+	host-python-yamllint \
 	ti-k3-boot-firmware
 
 TI_K3_R5_LOADER_MAKE = $(BR2_MAKE)
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH v2 2/3] boot/ti-k3-r5-loader: add dependency to yamllint

Hello Heiko,

Le 04/04/2024 à 10:17, Heiko Thiery a écrit :

Quoted 4 lines

Since U-Boot 2024.04 [1] binman also uses yamllint as dependency [2].

[1] https://source.denx.de/u-boot/u-boot/-/commit/10fee88d42f
[2] https://source.denx.de/u-boot/u-boot/-/blob/v2024.04/tools/buildman/requirements.txt?ref_type=tags#L3

Don't forget to update the two url in ti-k3-r5-loader.mk

https://gitlab.com/buildroot.org/buildroot/-/blob/master/boot/ti-k3-r5-loader/ti-k3-r5-loader.mk?ref_type=heads#L38

Best regards,
Romain

Quoted 11 lines
Signed-off-by Heiko Thiery <[email protected]>
---
 boot/ti-k3-r5-loader/ti-k3-r5-loader.mk | 1 +
 1 file changed, 1 insertion(+)
boot/ti-k3-r5-loader/ti-k3-r5-loader.mk +0 -0
index b3c48109c8..3f1000caad 100644

boot/ti-k3-r5-loader/ti-k3-r5-loader.mk TI_K3_R5_LOADER_DEPENDENCIES = \ · line 54

Quoted 7 lines
boot/ti-k3-r5-loader/ti-k3-r5-loader.mk +1 -0
@@ -48,6 +48,7 @@ TI_K3_R5_LOADER_DEPENDENCIES = \
 	host-python-pylibfdt \
 	host-python-pyyaml \
 	host-python-setuptools \
+	host-python-yamllint \
 	ti-k3-boot-firmware
 
 TI_K3_R5_LOADER_MAKE = $(BR2_MAKE)

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

author
#3 lore raw

PATCH v2 3/3 uboot/uboot: add new dependency to yamllint

In reply to Heiko Thiery

Since U-Boot 2024.04 [1] binman also uses yamllint as dependency [2].

[1] https://source.denx.de/u-boot/u-boot/-/commit/10fee88d42f
[2] https://source.denx.de/u-boot/u-boot/-/blob/v2024.04/tools/buildman/requirements.txt?ref_type=tags#L3

Signed-off-by Heiko Thiery <[email protected]>
---
 boot/uboot/uboot.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
boot/uboot/uboot.mk +2 -1
index 14502d4db2..26b9afdb00 100644
@@ -279,7 +279,8 @@ ifeq ($(BR2_TARGET_UBOOT_USE_BINMAN),y)
 # https://source.denx.de/u-boot/u-boot/-/blob/v2024.01/tools/buildman/requirements.txt
 UBOOT_DEPENDENCIES += \
 	host-python-jsonschema \
-	host-python-pyyaml
+	host-python-pyyaml \
+	host-python-yamllint
 UBOOT_MAKE_OPTS += BINMAN_INDIRS=$(BINARIES_DIR)
 endif
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

Re: [Buildroot] [PATCH v2 3/3] uboot/uboot: add new dependency to yamllint

Hello Heiko,

Le 04/04/2024 à 10:17, Heiko Thiery a écrit :

Quoted 4 lines

Since U-Boot 2024.04 [1] binman also uses yamllint as dependency [2].

[1] https://source.denx.de/u-boot/u-boot/-/commit/10fee88d42f
[2] https://source.denx.de/u-boot/u-boot/-/blob/v2024.04/tools/buildman/requirements.txt?ref_type=tags#L3

Same comment as for ti-k3-r5-loader.

The second url is missing in the comment. Maybe you can add it?

Best regards,
Romain

Quoted 11 lines
Signed-off-by Heiko Thiery <[email protected]>
---
 boot/uboot/uboot.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
boot/uboot/uboot.mk +0 -0
index 14502d4db2..26b9afdb00 100644

boot/uboot/uboot.mk ifeq ($(BR2_TARGET_UBOOT_USE_BINMAN),y) · line 286

Quoted 9 lines
boot/uboot/uboot.mk +2 -1
@@ -279,7 +279,8 @@ ifeq ($(BR2_TARGET_UBOOT_USE_BINMAN),y)
 # https://source.denx.de/u-boot/u-boot/-/blob/v2024.01/tools/buildman/requirements.txt
 UBOOT_DEPENDENCIES += \
 	host-python-jsonschema \
-	host-python-pyyaml
+	host-python-pyyaml \
+	host-python-yamllint
 UBOOT_MAKE_OPTS += BINMAN_INDIRS=$(BINARIES_DIR)
 endif

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Tested-by on v2 1/3
#5 lore raw
In reply to Heiko Thiery

Hello Heiko,

Le 04/04/2024 à 10:17, Heiko Thiery a écrit :

Quoted 35 lines

This host package is needed since u-boot 2024.04 for building ti defconfigs.

This is an requirement for using buildman/binman [1].

[1] https://source.denx.de/u-boot/u-boot/-/blob/v2024.04/tools/buildman/requirements.txt?ref_type=tags#L3

Signed-off-by Heiko Thiery <[email protected]>
---
 package/Config.in                            |  1 +
 package/python-yamllint/Config.in            |  6 ++++++
 package/python-yamllint/python-yamllint.hash |  3 +++
 package/python-yamllint/python-yamllint.mk   | 15 +++++++++++++++
 4 files changed, 25 insertions(+)
 create mode 100644 package/python-yamllint/Config.in
 create mode 100644 package/python-yamllint/python-yamllint.hash
 create mode 100644 package/python-yamllint/python-yamllint.mk
package/Config.in +1 -0
index 87767993a2..a02370a2ad 100644
@@ -1437,6 +1437,7 @@ menu "External python modules"
 	source "package/python-xmljson/Config.in"
 	source "package/python-xmltodict/Config.in"
 	source "package/python-xmodem/Config.in"
+	source "package/python-yamllint/Config.in"
 	source "package/python-yarl/Config.in"
 	source "package/python-yatl/Config.in"
 	source "package/python-zc-lockfile/Config.in"
package/python-yamllint/Config.in new file +0 -0
new file mode 100644
index 0000000000..cb67b355c3

package/python-yamllint/Config.in line 2

Quoted 2 lines
package/python-yamllint/Config.in new file +2 -0
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_YAMLLINT
+	bool "python-yamllint"

You are adding the target variant here but python-pyyaml and python-pathspec runtime dependencies are missing:

https://github.com/adrienverge/yamllint/blob/master/pyproject.toml#L20

Since python package easily break at runtime, it would be great if you can add a runtime test.

I tested the host variant to build uboot 2024.04 for the SK-TDA4VM board.

Tested-by Romain Naour <[email protected]>

Best regards,
Romain

Quoted 35 lines
package/python-yamllint/Config.in new file +4 -0
+	help
+	  A linter for YAML files.
+
+	  https://github.com/adrienverge/yamllint
package/python-yamllint/python-yamllint.hash new file +3 -0
new file mode 100644
index 0000000000..d80e0fdf42
@@ -0,0 +1,3 @@
+# Locally computed sha256 checksums
+sha256  7a003809f88324fd2c877734f2d575ee7881dd9043360657cc8049c809eba6cd  yamllint-1.35.1.tar.gz
+sha256  3972dc9744f6499f0f9b2dbf76696f2ae7ad8af9b23dde66d6af86c9dfb36986  LICENSE
package/python-yamllint/python-yamllint.mk new file +15 -1
new file mode 100644
index 0000000000..ceaca3b0b8
@@ -0,0 +1,15 @@
+################################################################################
+#
+# python-yamllint
+#
+################################################################################
+
+PYTHON_YAMLLINT_VERSION = 1.35.1
+PYTHON_YAMLLINT_SOURCE = yamllint-$(PYTHON_YAMLLINT_VERSION).tar.gz
+PYTHON_YAMLLINT_SITE = https://files.pythonhosted.org/packages/da/06/d8cee5c3dfd550cc0a466ead8b321138198485d1034130ac1393cc49d63e
+PYTHON_YAMLLINT_SETUP_TYPE = pep517
+PYTHON_YAMLLINT_LICENSE = GPL-3.0
+PYTHON_YAMLLINT_LICENSE_FILES = LICENSE
+
+$(eval $(python-package))
+$(eval $(host-python-package))
--
Quoted 2 lines

2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

author
#6 lore raw

Hi Romain,

Am Mi., 10. Apr. 2024 um 23:58 Uhr schrieb Romain Naour <[email protected]>:

Quoted 36 lines

Hello Heiko,

Quoted 32 lines · Heiko Thiery

This host package is needed since u-boot 2024.04 for building ti defconfigs.

This is an requirement for using buildman/binman [1].

[1] https://source.denx.de/u-boot/u-boot/-/blob/v2024.04/tools/buildman/requirements.txt?ref_type=tags#L3

Signed-off-by Heiko Thiery <[email protected]>
---
 package/Config.in                            |  1 +
 package/python-yamllint/Config.in            |  6 ++++++
 package/python-yamllint/python-yamllint.hash |  3 +++
 package/python-yamllint/python-yamllint.mk   | 15 +++++++++++++++
 4 files changed, 25 insertions(+)
 create mode 100644 package/python-yamllint/Config.in
 create mode 100644 package/python-yamllint/python-yamllint.hash
 create mode 100644 package/python-yamllint/python-yamllint.mk
package/Config.in +1 -0
index 87767993a2..a02370a2ad 100644
@@ -1437,6 +1437,7 @@ menu "External python modules"
      source "package/python-xmljson/Config.in"
      source "package/python-xmltodict/Config.in"
      source "package/python-xmodem/Config.in"
+     source "package/python-yamllint/Config.in"
      source "package/python-yarl/Config.in"
      source "package/python-yatl/Config.in"
      source "package/python-zc-lockfile/Config.in"
package/python-yamllint/Config.in new file +0 -0
new file mode 100644
index 0000000000..cb67b355c3
Quoted 8 lines

package/python-yamllint/Config.in line 2

Quoted 5 lines
package/python-yamllint/Config.in new file +2 -0
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PYTHON_YAMLLINT
+     bool "python-yamllint"

You are adding the target variant here but python-pyyaml and python-pathspec runtime dependencies are missing:

You are right. Just added this here.

Quoted 5 lines

https://github.com/adrienverge/yamllint/blob/master/pyproject.toml#L20

Since python package easily break at runtime, it would be great if you can add a runtime test.

As expected the target package breaks becauset pythspec is not present because it is not available as target package. I will fix that, add the testcase and prepare for v2.

Quoted 1 line

I tested the host variant to build uboot 2024.04 for the SK-TDA4VM board.

thanks

Quoted 35 lines
Tested-by Romain Naour <[email protected]>

Best regards,
Romain

Quoted 29 lines
package/python-yamllint/Config.in new file +4 -0
+     help
+       A linter for YAML files.
+
+       https://github.com/adrienverge/yamllint
package/python-yamllint/python-yamllint.hash new file +3 -0
new file mode 100644
index 0000000000..d80e0fdf42
@@ -0,0 +1,3 @@
+# Locally computed sha256 checksums
+sha256  7a003809f88324fd2c877734f2d575ee7881dd9043360657cc8049c809eba6cd  yamllint-1.35.1.tar.gz
+sha256  3972dc9744f6499f0f9b2dbf76696f2ae7ad8af9b23dde66d6af86c9dfb36986  LICENSE
package/python-yamllint/python-yamllint.mk new file +10 -0
new file mode 100644
index 0000000000..ceaca3b0b8
@@ -0,0 +1,15 @@
+################################################################################
+#
+# python-yamllint
+#
+################################################################################
+
+PYTHON_YAMLLINT_VERSION = 1.35.1
+PYTHON_YAMLLINT_SOURCE = yamllint-$(PYTHON_YAMLLINT_VERSION).tar.gz
+PYTHON_YAMLLINT_SITE = https://files.pythonhosted.org/packages/da/06/d8cee5c3dfd550cc0a466ead8b321138198485d1034130ac1393cc49d63e
+PYTHON_YAMLLINT_SETUP_TYPE = pep517
Quoted 9 lines
Quoted 8 lines
package/python-yamllint/python-yamllint.mk new file +5 -1
+PYTHON_YAMLLINT_LICENSE = GPL-3.0
+PYTHON_YAMLLINT_LICENSE_FILES = LICENSE
+
+$(eval $(python-package))
+$(eval $(host-python-package))
--

2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot