platform/x86: quickstart: fix Kconfig selects
PATCH 1/1 platform/x86: quickstart: fix Kconfig selects
From: Arnd Bergmann <[email protected]>
The new driver Kconfig entry has a typo that causes a link failure when CONFIG_INPUT_SPARSEKMAP is disabled:
x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_notify':
quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event'
x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_probe':
quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup'
Select this symbol instead of the incorrect INPUT_SPARSE_KEYMAP.
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -647,7 +647,7 @@ config ACPI_QUICKSTART tristate "ACPI Quickstart button driver" depends on ACPI depends on INPUT - select INPUT_SPARSE_KEYMAP + select INPUT_SPARSEKMAP help This driver adds support for ACPI quickstart button (PNP0C32) devices. The button emits a manufacturer-specific key value when pressed, so
Signature · 1 line
2.39.2
Am 04.04.24 um 14:34 schrieb Arnd Bergmann:
Quoted 23 lines
From: Arnd Bergmann <[email protected]>
The new driver
Kconfigentry has a typo that causes a link failure whenCONFIG_INPUT_SPARSEKMAPis disabled:x86_64-linux-ld:
drivers/platform/x86/quickstart.o: in function `quickstart_notify':
quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event'
x86_64-linux-ld:drivers/platform/x86/quickstart.o: in function `quickstart_probe':
quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup'Select this symbol instead of the incorrect
INPUT_SPARSE_KEYMAP.Fixes afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/Kconfig +0
-0
drivers/platform/x86/Kconfig config ACPI_QUICKSTART · line 653
Quoted 8 lines
drivers/platform/x86/Kconfig +1
-1@@ -647,7 +647,7 @@ config ACPI_QUICKSTART tristate "ACPI Quickstart button driver" depends on ACPI depends on INPUT - select INPUT_SPARSE_KEYMAP + select INPUT_SPARSEKMAP help This driver adds support for ACPI quickstart button (PNP0C32) devices. The button emits a manufacturer-specific key value when pressed, so
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The new driver
Kconfigentry has a typo that causes a link failure whenCONFIG_INPUT_SPARSEKMAPis disabled:x86_64-linux-ld:
drivers/platform/x86/quickstart.o: in function `quickstart_notify':
quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event'
x86_64-linux-ld:drivers/platform/x86/quickstart.o: in function `quickstart_probe':
quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup'
Quoted 5 lines
Select this symbol instead of the incorrect
INPUT_SPARSE_KEYMAP.Fixes afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver")Signed-off-by Arnd Bergmann <[email protected]>---
LGTM
Quoted 16 lines
drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/Kconfig +1
-1@@ -647,7 +647,7 @@ config ACPI_QUICKSTART tristate "ACPI Quickstart button driver" depends on ACPI depends on INPUT - select INPUT_SPARSE_KEYMAP + select INPUT_SPARSEKMAP help This driver adds support for ACPI quickstart button (PNP0C32) devices. The button emits a manufacturer-specific key value when pressed, so
Signature · 2 lines
Sathyanarayanan Kuppuswamy Linux Kernel Developer
Hi,
Quoted 10 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
The new driver
Kconfigentry has a typo that causes a link failure whenCONFIG_INPUT_SPARSEKMAPis disabled:x86_64-linux-ld:
drivers/platform/x86/quickstart.o: in function `quickstart_notify':
quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event'
x86_64-linux-ld:drivers/platform/x86/quickstart.o: in function `quickstart_probe':
quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup'
Quoted 4 lines
Select this symbol instead of the incorrect
INPUT_SPARSE_KEYMAP.Fixes afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver")Signed-off-by Arnd Bergmann <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
Quoted 17 lines
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/x86/Kconfig +1
-1@@ -647,7 +647,7 @@ config ACPI_QUICKSTART tristate "ACPI Quickstart button driver" depends on ACPI depends on INPUT - select INPUT_SPARSE_KEYMAP + select INPUT_SPARSEKMAP help This driver adds support for ACPI quickstart button (PNP0C32) devices. The button emits a manufacturer-specific key value when pressed, so