parport: mfc3: avoid empty-body warning
PATCH v3 1/1 parport: mfc3: avoid empty-body warning
From: Arnd Bergmann <[email protected]>
on m68k builds, the mfc3 driver causes a warning about an empty if() block:
drivers/parport/parport_mfc3.c: In function 'control_pc_to_mfc3':drivers/parport/parport_mfc3.c:106:37: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
Remove it in favor of a simpler comment.
---
This one was still missing from my series to enable more warnings by default in Makefile.extrawarn.
Greg, can you take this through the char-misc tree for 6.10?
--- drivers/parport/parport_mfc3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/parport/parport_mfc3.c +1 -2
@@ -102,8 +102,7 @@ static unsigned char control_pc_to_mfc3(unsigned char control) ret |=128 ;if (control &PARPORT_CONTROL_AUTOFD )/* AUTOLF */ ret &= ~64 ; -if (control &PARPORT_CONTROL_STROBE )/* Strobe */ -/* Handled directly by hardware */ ; +/* PARPORT_CONTROL_STROBE handled directly by hardware */ return ret; }
Signature · 1 line
2.39.2
Hi Arnd,
Thanks for your patch!
Quoted 11 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
on m68k builds, the mfc3 driver causes a warning about an empty
if()block:
drivers/parport/parport_mfc3.c: In function 'control_pc_to_mfc3':drivers/parport/parport_mfc3.c:106:37: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]Remove it in favor of a simpler comment.
Why the Link-tag, pointing to v2?
Quoted 1 line
Signed-off-by Arnd Bergmann <[email protected]>
For the actual patch:
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds