dmaengine: idxd: Check for driver name match before sva user feature
Subsystems (2)
PATCH v2 1/1 dmaengine: idxd: Check for driver name match before sva user feature
Currently if the user driver is probed on a workqueue configured for another driver with SVA not enabled on the system, it will print out a number of probe failing messages like the following:
[ 264.831140] user: probe of wq13.0 failed with error -95
On some systems, such as GNR, the number of messages can reach over 100.
Move the SVA feature check to be after the driver name match check.
---
v2:
- Fix typo.
- Add Reviewed-by tags for Dave and Fenghua
drivers/dma/idxd/cdev.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
drivers/dma/idxd/cdev.c +9 -8
@@ -517,6 +517,14 @@ static int idxd_user_drv_probe(struct idxd_dev *idxd_dev)if (idxd->state !=IDXD_DEV_ENABLED )return -ENXIO ; +mutex_lock (&wq->wq_lock); + +if (!idxd_wq_driver_name_match (wq, dev)) { + idxd->cmd_status =IDXD_SCMD_WQ_NO_DRV_NAME ; + rc = -ENODEV ; + goto wq_err; + } +/* * User type WQ is enabled only when SVA is enabled for two reasons: * - If no IOMMU or IOMMU Passthrough without SVA, userspace
@@ -532,14 +540,7 @@ static int idxd_user_drv_probe(struct idxd_dev *idxd_dev)dev_dbg (&idxd->pdev->dev,"User type WQ cannot be enabled without SVA.\n" ); -return -EOPNOTSUPP ; - } - -mutex_lock (&wq->wq_lock); - -if (!idxd_wq_driver_name_match (wq, dev)) { - idxd->cmd_status =IDXD_SCMD_WQ_NO_DRV_NAME ; - rc = -ENODEV ; + rc = -EOPNOTSUPP ; goto wq_err; }
Signature · 1 line
2.44.0
Quoted 10 lines · Jerry Snitselaar
Currently if the user driver is probed on a workqueue configured for another driver with SVA not enabled on the system, it will print out a number of probe failing messages like the following:
[ 264.831140] user: probe of wq13.0 failed with error -95On some systems, such as GNR, the number of messages can reach over 100.
[...]
Applied, thanks!
[1/1] dmaengine: idxd: Check for driver name match before sva user feature
commit: c863062cf8250d8330859fc1d730b2aed3313bcd
Best regards,
Signature · 1 line
~Vinod