Skip to contentSkip to conversation

scsi: FlashPoint: remove redundant assignment to pointer currTar_Info

PATCH Applied Colin Ian King 2 participants 3 messages Apr 6, 2024 – Apr 12, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: FlashPoint: remove redundant assignment to pointer currTar_Info

Pointer currTar_Info is being assigned a value that is never read, it is being re-assigned a few lines later in the start of a following do-while loop. The assignment is redundant and can be removed.

---
 drivers/scsi/FlashPoint.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/FlashPoint.c +0 -1
index 3d9c56ac8224..9e77b8e1ea7c 100644
@@ -2631,7 +2631,6 @@ static void FPT_sres(u32 port, unsigned char p_card,
 	WRW_HARPOON((port + hp_fiforead), (unsigned short)0x00);
 
 	our_target = (unsigned char)(RD_HARPOON(port + hp_select_id) >> 4);
-	currTar_Info = &FPT_sccbMgrTbl[p_card][our_target];
 
 	msgRetryCount = 0;
 	do {
Signature · 1 line
2.39.2
#1 lore raw

Colin,

Quoted 3 lines

Pointer currTar_Info is being assigned a value that is never read, it is being re-assigned a few lines later in the start of a following do-while loop. The assignment is redundant and can be removed.

Applied to 6.10/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Colin Ian King
Quoted 5 lines · Colin Ian King

Pointer currTar_Info is being assigned a value that is never read, it is being re-assigned a few lines later in the start of a following do-while loop. The assignment is redundant and can be removed.

Applied to 6.10/scsi-queue, thanks!

[1/1] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info

      https://git.kernel.org/mkp/scsi/c/9bd8e41358a5
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering