Skip to contentSkip to conversation

power: supply: cros_usbpd: Don't show messages for no charging ports found

PATCH In review Mario Limonciello 2 participants 2 messages Apr 6, 2024 – Apr 8, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power: supply: cros_usbpd: Don't show messages for no charging ports found

From: Mario Limonciello <[email protected]>

Framework 13 and 16 don't use cros_usbpd but do use cros_ec. The following sequence of messages is totally unnecessary.

[    5.545352] cros-usbpd-charger cros-usbpd-charger.4.auto: No USB PD
charging ports found
[    5.546722] cros-usbpd-charger cros-usbpd-charger.4.auto: Unexpected
number of charge port count
[    5.546730] cros-usbpd-charger cros-usbpd-charger.4.auto: Failing
probe (err:0xffffffb9)
[    5.546735] cros-usbpd-charger cros-usbpd-charger.4.auto: probe with

driver cros-usbpd-charger failed with error -71

---
 drivers/power/supply/cros_usbpd-charger.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/power/supply/cros_usbpd-charger.c +2 -1
index b6c96376776a..4e69da2cce7b 100644
@@ -570,7 +570,8 @@ static int cros_usbpd_charger_probe(struct platform_device *pd)
 		 * This can happen on a system that doesn't support USB PD.
 		 * Log a message, but no need to warn.
 		 */
-		dev_info(dev, "No USB PD charging ports found\n");
+		dev_dbg(dev, "No USB PD charging ports found\n");
+		return -ENODEV;
 	}
 
 	charger->num_charger_ports = cros_usbpd_charger_get_num_ports(charger);
Signature · 1 line
2.34.1