nvme/rc: fix shellcheck warning SC2086
PATCH 2/2 nvme/rc: fix shellcheck warning SC2086
tests/nvme/rc:1056:7: note: Double quote to prevent globbing and word splitting. [SC2086] tests/nvme/rc:1057:7: note: Double quote to prevent globbing and word splitting. [SC2086]
Fixes 369d310 ("nvme: Add passthru error logging tests to nvme/039")
Signed-off-by Yi Zhang <[email protected]>
--- tests/nvme/rc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tests/nvme/rc +2 -2
@@ -1053,8 +1053,8 @@ _nvme_passthru_logging_setup() _nvme_passthru_logging_cleanup() { - echo $ctrl_dev_passthru_logging > /sys/class/nvme/"$2"/passthru_err_log_enabled - echo $ns_dev_passthru_logging > /sys/class/nvme/"$2"/"$1"/passthru_err_log_enabled + echo "$ctrl_dev_passthru_logging" > /sys/class/nvme/"$2"/passthru_err_log_enabled + echo "$ns_dev_passthru_logging" > /sys/class/nvme/"$2"/"$1"/passthru_err_log_enabled } _nvme_err_inject_setup()
Signature · 1 line
2.34.3
Shinichiro Kawasaki
AppliedQuoted 5 lines · Yi Zhang
tests/nvme/rc:1056:7: note: Double quote to prevent globbing and word splitting. [SC2086] tests/nvme/rc:1057:7: note: Double quote to prevent globbing and word splitting. [SC2086]
Fixes 369d310 ("nvme: Add passthru error logging tests to nvme/039")Signed-off-by Yi Zhang <[email protected]>
Thanks, applied.
Of note is that the warnings are observed with ShellCheck version 0.8.0, but not observed with ShellCheck version 0.9.0 and 0.10.0. I added this note to the commit message.