f2fs: compress: fix to relocate check condition in f2fs_{release,reserve}_compress_blocks()
Chao Yu
maintainerPATCH 1/2 f2fs: compress: fix to relocate check condition in f2fs_{release,reserve}_compress_blocks()
Compress flag should be checked after inode lock held to avoid racing w/ f2fs_setflags_common(), fix it.
--- fs/f2fs/file.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
fs/f2fs/file.c +4 -8
@@ -3549,9 +3549,6 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg)if (!f2fs_sb_has_compression (sbi))return -EOPNOTSUPP ; -if (!f2fs_compressed_file (inode)) -return -EINVAL ; -if (f2fs_readonly (sbi->sb))return -EROFS ;
@@ -3570,7 +3567,8 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg) goto out; } -if (is_inode_flag_set (inode,FI_COMPRESS_RELEASED )) { +if (!f2fs_compressed_file (inode) || +is_inode_flag_set (inode,FI_COMPRESS_RELEASED )) { ret = -EINVAL ; goto out; }
@@ -3731,9 +3729,6 @@ static int f2fs_reserve_compress_blocks(struct file *filp, unsigned long arg)if (!f2fs_sb_has_compression (sbi))return -EOPNOTSUPP ; -if (!f2fs_compressed_file (inode)) -return -EINVAL ; -if (f2fs_readonly (sbi->sb))return -EROFS ;
@@ -3745,7 +3740,8 @@ static int f2fs_reserve_compress_blocks(struct file *filp, unsigned long arg)inode_lock (inode); -if (!is_inode_flag_set (inode,FI_COMPRESS_RELEASED )) { +if (!f2fs_compressed_file (inode) || + !is_inode_flag_set (inode,FI_COMPRESS_RELEASED )) { ret = -EINVAL ; goto unlock_inode; }
Signature · 1 line
2.40.1
Chao Yu
maintainerPATCH 2/2 f2fs: compress: fix to relocate check condition in f2fs_ioc_{,de}compress_file()
Compress flag should be checked after inode lock held to avoid racing w/ f2fs_setflags_common() , fix it.
--- fs/f2fs/file.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
fs/f2fs/file.c +4 -8
@@ -4142,9 +4142,6 @@ static int f2fs_ioc_decompress_file(struct file *filp)if (!(filp->f_mode &FMODE_WRITE ))return -EBADF ; -if (!f2fs_compressed_file (inode)) -return -EINVAL ; -f2fs_balance_fs (sbi, true);file_start_write (filp);
@@ -4155,7 +4152,8 @@ static int f2fs_ioc_decompress_file(struct file *filp) goto out; } -if (is_inode_flag_set (inode,FI_COMPRESS_RELEASED )) { +if (!f2fs_compressed_file (inode) || +is_inode_flag_set (inode,FI_COMPRESS_RELEASED )) { ret = -EINVAL ; goto out; }
@@ -4220,9 +4218,6 @@ static int f2fs_ioc_compress_file(struct file *filp)if (!(filp->f_mode &FMODE_WRITE ))return -EBADF ; -if (!f2fs_compressed_file (inode)) -return -EINVAL ; -f2fs_balance_fs (sbi, true);file_start_write (filp);
@@ -4233,7 +4228,8 @@ static int f2fs_ioc_compress_file(struct file *filp) goto out; } -if (is_inode_flag_set (inode,FI_COMPRESS_RELEASED )) { +if (!f2fs_compressed_file (inode) || +is_inode_flag_set (inode,FI_COMPRESS_RELEASED )) { ret = -EINVAL ; goto out; }
Signature · 1 line
2.40.1
Re: [f2fs-dev] [PATCH 1/2] f2fs: compress: fix to relocate check condition in f2fs_{release, reserve}_compress_blocks()
In reply to Chao YuThis series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This series was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 9 lines · On Sun, 7 Apr 2024 15:26:03 +0800 you wrote:
Compress flag should be checked after inode lock held to avoid racing w/
f2fs_setflags_common(), fix it.Fixes 4c8ff7095bef ("f2fs: support data compression")Reported-by Zhiguo Niu <[email protected]>Closes https://lore.kernel.org/linux-f2fs-devel/CAHJ8P3LdZXLc2rqeYjvymgYHr2+YLuJ0sLG9DdsJZmwO7deuhw@mail.gmail.com open hereSigned-off-by Chao Yu <[email protected]>[...]
Here is the summary with links:
- [f2fs-dev,1/2] f2fs: compress: fix to relocate check condition in f2fs_{release, reserve}_compress_blocks()
https://git.kernel.org/jaegeuk/f2fs/c/7c5dffb3d90c - [f2fs-dev,2/2] f2fs: compress: fix to relocate check condition in f2fs_ioc_{, de}compress_file() https://git.kernel.org/jaegeuk/f2fs/c/bd9ae4ae9e58
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html