Skip to contentSkip to conversation

kconfig/lxdialog: fix check() with GCC14

PATCH Applied Robert Marko 4 participants 4 messages Apr 8, 2024 – May 15, 2024

lore
Share & tools
lore

Robert Marko

author
#0 lore raw

PATCH v2 1/1 kconfig/lxdialog: fix check() with GCC14

GCC14 now treats implicit int types as error so when check() from check-lxdialog.sh is called to check whether we can link against ncurses it will fail silently and the help text indicating to install ncurses is printed.

However, this is not due to missing ncurses but once the stderr redirect to /dev/null is removed we can see the root cause:
<stdin>:2:1: error: return type defaults to ‘int’ [-Wimplicit-int]

So, in order for menuconfig to work with GCC14 lets just specify the return type of main() as int.

Signed-off-by Robert Marko <[email protected]>
Reviewed-by Petr Vorel <[email protected]>
Tested-by Petr Vorel <[email protected]>
---
 support/kconfig/lxdialog/check-lxdialog.sh    |  2 +-
 ...config-lxdialog-fix-check-with-GCC14.patch | 43 +++++++++++++++++++
 support/kconfig/patches/series                |  1 +
 3 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 support/kconfig/patches/22-kconfig-lxdialog-fix-check-with-GCC14.patch
support/kconfig/lxdialog/check-lxdialog.sh +1 -1
index 16cd9a3186..27d6c30a57 100755
@@ -48,7 +48,7 @@ trap "rm -f $tmp" 0 1 2 3 15
 check() {
         $cc -x c - -o $tmp 2>/dev/null <<'EOF'
 #include CURSES_LOC
-main() {}
+int main() {}
 EOF
 	if [ $? != 0 ]; then
 	    echo " *** Unable to find the ncurses libraries or the"       1>&2
support/kconfig/patches/22-kconfig-lxdialog-fix-check-with-GCC14.patch new file +43 -0

43 lines not on this page · raw message

support/kconfig/patches/series +1 -0
index e5a6f69d8f..f120e323b7 100644
@@ -10,3 +10,4 @@
 19-merge_config.sh-add-br2-external-support.patch
 20-merge_config.sh-Allow-to-define-config-prefix.patch
 21-Avoid-false-positive-matches-from-comment-lines.patch
+22-kconfig-lxdialog-fix-check-with-GCC14.patch
Signature · 6 lines
2.44.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hi Robert, Thomas,

Quoted 9 lines

GCC14 now treats implicit int types as error so when check() from check-lxdialog.sh is called to check whether we can link against ncurses it will fail silently and the help text indicating to install ncurses is printed.

However, this is not due to missing ncurses but once the stderr redirect to /dev/null is removed we can see the root cause:
<stdin>:2:1: error: return type defaults to ‘int’ [-Wimplicit-int]

Quoted 6 lines

So, in order for menuconfig to work with GCC14 lets just specify the return type of main() as int.

Signed-off-by Robert Marko <[email protected]>
Reviewed-by Petr Vorel <[email protected]>
Tested-by Petr Vorel <[email protected]>

Thanks for quickly adding v2.

BTW there were whitespace issues (but fixed by git am):

Description: [v2,1/1] kconfig/lxdialog: fix check() with GCC14
Applying: kconfig/lxdialog: fix check() with GCC14 .git/rebase-apply/patch:65: space before tab in indent.
if [ $? != 0 ]; then
.git/rebase-apply/patch:66: space before tab in indent.
echo " *** Unable to find the ncurses libraries or the" 1>&2
.git/rebase-apply/patch:67: trailing whitespace.
--
.git/rebase-apply/patch:69: new blank line at EOF.
+
warning: 3 lines applied after fixing whitespace errors.

Otherwise LGTM.

And I see the toolchain warnings for gconfig and xconfig (which are likely fixed in newer kconfig in the Linux kernel).

Kind regards,
Petr

Quoted 74 lines
---
 support/kconfig/lxdialog/check-lxdialog.sh    |  2 +-
 ...config-lxdialog-fix-check-with-GCC14.patch | 43 +++++++++++++++++++
 support/kconfig/patches/series                |  1 +
 3 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 support/kconfig/patches/22-kconfig-lxdialog-fix-check-with-GCC14.patch
support/kconfig/lxdialog/check-lxdialog.sh +1 -1
index 16cd9a3186..27d6c30a57 100755
@@ -48,7 +48,7 @@ trap "rm -f $tmp" 0 1 2 3 15
 check() {
         $cc -x c - -o $tmp 2>/dev/null <<'EOF'
 #include CURSES_LOC
-main() {}
+int main() {}
 EOF
 	if [ $? != 0 ]; then
 	    echo " *** Unable to find the ncurses libraries or the"       1>&2
support/kconfig/patches/22-kconfig-lxdialog-fix-check-with-GCC14.patch new file +43 -0
new file mode 100644
index 0000000000..41081bb45d
@@ -0,0 +1,43 @@
+From 3ae91337b53fa3ccf0bad7f181fcaf483fab22ee Mon Sep 17 00:00:00 2001
+From: Robert Marko <[email protected]>
+Date: Wed, 3 Apr 2024 14:18:07 +0200
+Subject: [PATCH] kconfig/lxdialog: fix check() with GCC14
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+GCC14 now treats implicit int types as error so when check() from
+check-lxdialog.sh is called to check whether we can link against ncurses
+it will fail silently and the help text indicating to install ncurses is
+printed.
+
+However, this is not due to missing ncurses but once the stderr redirect
+to /dev/null is removed we can see the root cause:
+<stdin>:2:1: error: return type defaults to ‘int’ [-Wimplicit-int]
+
+So, in order for menuconfig to work with GCC14 lets just specify the
+return type of main() as int.
+
+Signed-off-by: Robert Marko <[email protected]>
+Reviewed-by: Petr Vorel <[email protected]>
+Tested-by: Petr Vorel <[email protected]>
+---
+ kconfig/lxdialog/check-lxdialog.sh | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/kconfig/lxdialog/check-lxdialog.sh b/kconfig/lxdialog/check-lxdialog.sh
+index 16cd9a3186..27d6c30a57 100755
+--- a/kconfig/lxdialog/check-lxdialog.sh
++++ b/kconfig/lxdialog/check-lxdialog.sh
+@@ -48,7 +48,7 @@ trap "rm -f $tmp" 0 1 2 3 15
+ check() {
+         $cc -x c - -o $tmp 2>/dev/null <<'EOF'
+ #include CURSES_LOC
+-main() {}
++int main() {}
+ EOF
+ 	if [ $? != 0 ]; then
+ 	    echo " *** Unable to find the ncurses libraries or the"       1>&2
+-- 
+2.44.0
+
support/kconfig/patches/series +0 -0
index e5a6f69d8f..f120e323b7 100644

support/kconfig/patches/series line 13

Quoted 4 lines
support/kconfig/patches/series +1 -0
@@ -10,3 +10,4 @@
 19-merge_config.sh-add-br2-external-support.patch
 20-merge_config.sh-Allow-to-define-config-prefix.patch
 21-Avoid-false-positive-matches-from-comment-lines.patch
+22-kconfig-lxdialog-fix-check-with-GCC14.patch

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Applied
#2 lore raw
In reply to Robert Marko

Robert, All,

On 2024-04-08 23:16 +0200, Robert Marko spake thusly:

Quoted 11 lines

GCC14 now treats implicit int types as error so when check() from check-lxdialog.sh is called to check whether we can link against ncurses it will fail silently and the help text indicating to install ncurses is printed.

However, this is not due to missing ncurses but once the stderr redirect to /dev/null is removed we can see the root cause:
<stdin>:2:1: error: return type defaults to ‘int’ [-Wimplicit-int]

So, in order for menuconfig to work with GCC14 lets just specify the return type of main() as int.

I've also added a little note that there is no commit from the kernel tree that we can backport, because the kernel tree no longer has that script.

Quoted 3 lines
Signed-off-by Robert Marko <[email protected]>
Reviewed-by Petr Vorel <[email protected]>
Tested-by Petr Vorel <[email protected]>

Applied to master with the little note abouve added, thanks.

Regards,
Yann E. MORIN.

Quoted 85 lines
---
 support/kconfig/lxdialog/check-lxdialog.sh    |  2 +-
 ...config-lxdialog-fix-check-with-GCC14.patch | 43 +++++++++++++++++++
 support/kconfig/patches/series                |  1 +
 3 files changed, 45 insertions(+), 1 deletion(-)
 create mode 100644 support/kconfig/patches/22-kconfig-lxdialog-fix-check-with-GCC14.patch
support/kconfig/lxdialog/check-lxdialog.sh +1 -1
index 16cd9a3186..27d6c30a57 100755
@@ -48,7 +48,7 @@ trap "rm -f $tmp" 0 1 2 3 15
 check() {
         $cc -x c - -o $tmp 2>/dev/null <<'EOF'
 #include CURSES_LOC
-main() {}
+int main() {}
 EOF
 	if [ $? != 0 ]; then
 	    echo " *** Unable to find the ncurses libraries or the"       1>&2
support/kconfig/patches/22-kconfig-lxdialog-fix-check-with-GCC14.patch new file +43 -0
new file mode 100644
index 0000000000..41081bb45d
@@ -0,0 +1,43 @@
+From 3ae91337b53fa3ccf0bad7f181fcaf483fab22ee Mon Sep 17 00:00:00 2001
+From: Robert Marko <[email protected]>
+Date: Wed, 3 Apr 2024 14:18:07 +0200
+Subject: [PATCH] kconfig/lxdialog: fix check() with GCC14
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+GCC14 now treats implicit int types as error so when check() from
+check-lxdialog.sh is called to check whether we can link against ncurses
+it will fail silently and the help text indicating to install ncurses is
+printed.
+
+However, this is not due to missing ncurses but once the stderr redirect
+to /dev/null is removed we can see the root cause:
+<stdin>:2:1: error: return type defaults to ‘int’ [-Wimplicit-int]
+
+So, in order for menuconfig to work with GCC14 lets just specify the
+return type of main() as int.
+
+Signed-off-by: Robert Marko <[email protected]>
+Reviewed-by: Petr Vorel <[email protected]>
+Tested-by: Petr Vorel <[email protected]>
+---
+ kconfig/lxdialog/check-lxdialog.sh | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/kconfig/lxdialog/check-lxdialog.sh b/kconfig/lxdialog/check-lxdialog.sh
+index 16cd9a3186..27d6c30a57 100755
+--- a/kconfig/lxdialog/check-lxdialog.sh
++++ b/kconfig/lxdialog/check-lxdialog.sh
+@@ -48,7 +48,7 @@ trap "rm -f $tmp" 0 1 2 3 15
+ check() {
+         $cc -x c - -o $tmp 2>/dev/null <<'EOF'
+ #include CURSES_LOC
+-main() {}
++int main() {}
+ EOF
+ 	if [ $? != 0 ]; then
+ 	    echo " *** Unable to find the ncurses libraries or the"       1>&2
+-- 
+2.44.0
+
support/kconfig/patches/series +1 -0
index e5a6f69d8f..f120e323b7 100644
@@ -10,3 +10,4 @@
 19-merge_config.sh-add-br2-external-support.patch
 20-merge_config.sh-Allow-to-define-config-prefix.patch
 21-Avoid-false-positive-matches-from-comment-lines.patch
+22-kconfig-lxdialog-fix-check-with-GCC14.patch
Signature · 6 lines
2.44.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw
Quoted 20 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Robert, All,
On 2024-04-08 23:16 +0200, Robert Marko spake thusly:

Quoted 11 lines

GCC14 now treats implicit int types as error so when check() from check-lxdialog.sh is called to check whether we can link against ncurses it will fail silently and the help text indicating to install ncurses is printed.

However, this is not due to missing ncurses but once the stderr redirect to /dev/null is removed we can see the root cause:
<stdin>:2:1: error: return type defaults to ‘int’ [-Wimplicit-int]

So, in order for menuconfig to work with GCC14 lets just specify the return type of main() as int.

I've also added a little note that there is no commit from the kernel tree that we can backport, because the kernel tree no longer has that script.

Quoted 5 lines
Quoted 3 lines
Signed-off-by Robert Marko <[email protected]>
Reviewed-by Petr Vorel <[email protected]>
Tested-by Petr Vorel <[email protected]>

Applied to master with the little note abouve added, thanks.

Committed to 2024.02.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot