Skip to contentSkip to conversation

spi: Add documentation for last_cs_index_mask

PATCH In review Ruben Wauters 2 participants 3 messages Apr 9, 2024 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 spi: Add documentation for last_cs_index_mask

Documentation was missing for last_cs_index_mask, this was shown by a warning in make htmldocs.

I have based the documentation off the docs for cs_index_mask, given that they should be similar.

This is my first patch, so I hope I did everything right, please let me know if I need to change something, and I shall endevour to do it properly.

---
 include/linux/spi/spi.h | 2 ++
 1 file changed, 2 insertions(+)
include/linux/spi/spi.h +2 -0
index c459809efee4..ed941e65791a 100644
@@ -453,6 +453,8 @@ extern struct spi_device *spi_new_ancillary_device(struct spi_device *spi, u8 ch
  * @last_cs_mode_high: was (mode & SPI_CS_HIGH) true on the last call to set_cs.
  * @last_cs: the last chip_select that is recorded by set_cs, -1 on non chip
  *           selected
+ * @last_cs_index_mask: the last active chip select bit masks in the chip select
+ *                      array
  * @xfer_completion: used by core transfer_one_message()
  * @busy: message pump is busy
  * @running: message pump is running
Signature · 1 line
2.40.1
maintainer
#2 lore raw
Quoted 3 lines · Ruben Wauters

This is my first patch, so I hope I did everything right, please let me know if I need to change something, and I shall endevour to do it properly.

Everything looks good, only issue I can see is that this question (which is adminstrative stuff rather than part of the changelog) should have gone after the --- below:

Quoted 3 lines

---

so that tooling can automatically remove it when applying.

However a patch for this issue has already been applied but not yet merged into Linus' tree.

#3 lore raw
Quoted 14 lines · Mark Brown
Quoted 5 lines · Ruben Wauters

This is my first patch, so I hope I did everything right, please let
me know if I need to change something, and I shall endevour to do it
properly.

Everything looks good, only issue I can see is that this question (which
is adminstrative stuff rather than part of the changelog) should have gone after the --- below:

Quoted 1 line
Quoted 7 lines
Quoted 2 lines

---

so that tooling can automatically remove it when applying.

However a patch for this issue has already been applied but not yet merged into Linus' tree.

My apologies, I should have checked before submitting the patch, will do this in the future, and noted on the message, will also keep that in mind.