Skip to contentSkip to conversation

scsi: ufs: exynos: Support module autoloading

PATCH Applied Will McVicker 3 participants 5 messages Apr 9, 2024 – Apr 25, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: exynos: Support module autoloading

Export the module alias information using the MODULE_DEVICE_TABLE() macro in order to support auto-loading this module for devices that support it.

$ modinfo -F alias out/linux/drivers/ufs/host/ufs-exynos.ko
of:N*T*Ctesla,fsd-ufsC*
of:N*T*Ctesla,fsd-ufs
of:N*T*Csamsung,exynosautov9-ufs-vhC*
of:N*T*Csamsung,exynosautov9-ufs-vh
of:N*T*Csamsung,exynosautov9-ufsC*
of:N*T*Csamsung,exynosautov9-ufs
of:N*T*Csamsung,exynos7-ufsC*
of:N*T*Csamsung,exynos7-ufs
---
 drivers/ufs/host/ufs-exynos.c | 1 +
 1 file changed, 1 insertion(+)

Note, I tested this on a Pixel 6 device with the UFS patch series in [1]. With both this patch and [1], the ufs-exynos module autoloads on boot.

[1] https://lore.kernel.org/all/[email protected]/

drivers/ufs/host/ufs-exynos.c +1 -0
index 734d40f99e31..1795860a2f06 100644
@@ -1748,6 +1748,7 @@ static const struct of_device_id exynos_ufs_of_match[] = {
 	  .data       = &fsd_ufs_drvs },
 	{},
 };
+MODULE_DEVICE_TABLE(of, exynos_ufs_of_match);
 
 static const struct dev_pm_ops exynos_ufs_pm_ops = {
 	SET_SYSTEM_SLEEP_PM_OPS(ufshcd_system_suspend, ufshcd_system_resume)

base-commit: 2c71fdf02a95b3dd425b42f28fd47fb2b1d22702

Signature · 1 line
2.44.0.683.g7961c838ac-goog
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Will McVicker

Export the module alias information using the MODULE_DEVICE_TABLE() macro in order to support auto-loading this module for devices that support it.

Quoted 9 lines
$ modinfo -F alias out/linux/drivers/ufs/host/ufs-exynos.ko
of:N*T*Ctesla,fsd-ufsC*
of:N*T*Ctesla,fsd-ufs
of:N*T*Csamsung,exynosautov9-ufs-vhC*
of:N*T*Csamsung,exynosautov9-ufs-vh
of:N*T*Csamsung,exynosautov9-ufsC*
of:N*T*Csamsung,exynosautov9-ufs
of:N*T*Csamsung,exynos7-ufsC*
of:N*T*Csamsung,exynos7-ufs

That part is redundant, you just copied result of of_device_id. No need to resend just for this.

Best regards,
Krzysztof

#2 lore raw
Quoted 15 lines · Krzysztof Kozlowski
Quoted 4 lines · Will McVicker

Export the module alias information using the MODULE_DEVICE_TABLE() macro in order to support auto-loading this module for devices that support it.

Quoted 9 lines
$ modinfo -F alias out/linux/drivers/ufs/host/ufs-exynos.ko
of:N*T*Ctesla,fsd-ufsC*
of:N*T*Ctesla,fsd-ufs
of:N*T*Csamsung,exynosautov9-ufs-vhC*
of:N*T*Csamsung,exynosautov9-ufs-vh
of:N*T*Csamsung,exynosautov9-ufsC*
of:N*T*Csamsung,exynosautov9-ufs
of:N*T*Csamsung,exynos7-ufsC*
of:N*T*Csamsung,exynos7-ufs
Quoted 2 lines

That part is redundant, you just copied result of of_device_id. No need to resend just for this.

Well the point of including this snippet is to show that it's working. Without this patch, modinfo -F alias ufs-exynos.ko doesn't return anything. I'm fine with not including it either way though.

Thanks,
Will

Quoted 6 lines

Best regards,
Krzysztof

#3 lore raw
In reply to Will McVicker

Will,

Quoted 3 lines

Export the module alias information using the MODULE_DEVICE_TABLE() macro in order to support auto-loading this module for devices that support it.

Applied to 6.10/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#4 lore raw
In reply to Will McVicker
Quoted 14 lines · Will McVicker

Export the module alias information using the MODULE_DEVICE_TABLE() macro in order to support auto-loading this module for devices that support it.

$ modinfo -F alias out/linux/drivers/ufs/host/ufs-exynos.ko
of:N*T*Ctesla,fsd-ufsC*
of:N*T*Ctesla,fsd-ufs
of:N*T*Csamsung,exynosautov9-ufs-vhC*
of:N*T*Csamsung,exynosautov9-ufs-vh
of:N*T*Csamsung,exynosautov9-ufsC*
of:N*T*Csamsung,exynosautov9-ufs
of:N*T*Csamsung,exynos7-ufsC*
of:N*T*Csamsung,exynos7-ufs
Quoted 1 line

[...]

Applied to 6.10/scsi-queue, thanks!

[1/1] scsi: ufs: exynos: Support module autoloading

      https://git.kernel.org/mkp/scsi/c/2810702f2cbc
Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering